Commit Graph

15 Commits

Author SHA1 Message Date
Michal Čihař
8490161073 Share code for testing FormLists
The tests were same anyway, so avoid duplicating code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:10 +02:00
Michal Čihař
09642df6fc Avoid using abstract static functions
This does not work in PHP 5, only in PHP 7.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:09 +02:00
Michal Čihař
8490d3a571 Rewrite Setup settings forms as classes
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:09 +02:00
Michal Čihař
1fb2887a2a Bring User settings in sync with Setup
- add server navigation configuration, it makes no sense to hide this
  from user as it configures just UI
- reorganize Features form a bit to be in sync with Setup
- add DisableShortcutKeys settings to User
- remove LoginCookieValidity from User settings (there are more cookie
  related settings and all should be handled same)

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:09 +02:00
Michal Čihař
73d1599a1a Rewrite Page settings forms as classes
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:02:07 +02:00
Michal Čihař
df7f328f79 Rewrite User preferences forms as clases
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:02:07 +02:00
Michal Čihař
4b983d6648 Remove unused strings
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Michal Čihař
94219fffab Wrap function_exists in ServerConfigChecks to allow testing
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Michal Čihař
89fc550862 Use Url::getCommon to generate full URLs
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Michal Čihař
0b81218a10 Refactor configuration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Michal Čihař
dc6d06f5ca Avoid defining error messages centrally in server config check
- better load them only when needed
- avoid using PMA_lang which really serves different purpose

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Michal Čihař
541e72a019 Fix parameter description
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 09:12:25 +02:00
Michal Čihař
1f02f85b29 Avoid usage of soon deprecated $php_errormsg
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-22 09:30:22 +02:00
Michal Čihař
0983378e29 Replace PMA_SETUP define by configuration variable
This way we don't need runkit for testing and it's anyway a bit cleaner
approach.

Issue #13484

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-12 17:35:09 +02:00
Maurício Meneghini Fauth
5e7f6a1bab Move config classes to PhpMyAdmin namespace
- Move ConfigFile to PhpMyAdmin namespace
- Move FormDisplay to PhpMyAdmin namespace
- Move Form to PhpMyAdmin namespace
- Move PageSettings to PhpMyAdmin namespace
- Move ServerConfigChecks to PhpMyAdmin namespace
- Move Validator to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-09 15:16:37 -03:00