gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
122,207 Commits 12 Branches 481 Tags 2.4 GiB
87c6181568
Commit Graph

328 Commits

Author SHA1 Message Date
William Desportes
87c6181568
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-08 02:49:47 +02:00
Lukas Bixen
c0fe75bc67 Fix DEL character in generated random strings 
Apply suggestions from code review:
Use identical operator and improve comment

Signed-off-by: Lukas Bixen <lrb2_@outlook.com>
 2021-08-07 12:07:30 -05:00
Maurício Meneghini Fauth
04d3c83559
Fix some errors found by PHPStan/Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-05 16:09:08 -03:00
William Desportes
9373c8ec70
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 14:51:35 +02:00
William Desportes
d281dcc0bd
Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 12:59:54 +02:00
Maximilian Krög
c1c6b01195
Use correct min MySQL version for axis-order (8.0.1) 
There was no version 8.0.10
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-07-20 01:28:29 +02:00
William Desportes
b4652b108e
Remove non used Util::getFirstOccurringRegularExpression 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 03:17:29 +02:00
William Desportes
34acbcdc38
Fix calls to fetchRow using two parameters but function has only one parameter 
None of our fetchRow methods have more than one parameter

Thank you Psalm for catching this !

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:28:03 +02:00
William Desportes
d1ed1a10d4
Ref #15247 - Remove defined('TESTSUITE') from Util::date 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:39:14 +02:00
Maurício Meneghini Fauth
1835ebb4fc
Replace mb_strpos !== false with str_contains 
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
William Desportes
280a201f79
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-28 17:42:02 +02:00
William Desportes
6699fb1923
Fix 32-bit issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-24 22:03:41 +02:00
Maurício Meneghini Fauth
878ab12dec
Change Util::getUrlForOption fallback to base route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-11 20:19:05 -03:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
41e0d4dfb7
Use the Query\Compatibility class to simply and remove duplicate checks 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:57:10 +02:00
William Desportes
d99da46f7a
Move isVirtualColumnsSupported to Query\Compatibility and simplify the code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 20:31:38 +02:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 21:51:45 +02:00
Saksham Gupta
43e39ab08b
Fix #16777 - Non-UTF8 Primary Key fix 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-04-19 16:45:17 +02:00
William Desportes
9f0fc40cdb
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-02 13:40:28 +02:00
William Desportes
a127061655
Fix #16773 - Do not use cast as binary for an empty text value 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-01 02:09:32 +02:00
Maurício Meneghini Fauth
3d539b78e6
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 16:07:09 -03:00
Maurício Meneghini Fauth
5335b3feb8
Fix PHP 8.1 failing tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 14:51:33 -03:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-23 01:13:58 +01:00
William Desportes
942a252b46
Fix #16694 - Do not escape _ for TABLE_NAME in information schema 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-22 23:20:23 +01:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class 
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-22 15:03:39 -03:00
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class 
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-21 15:25:45 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
3a161651ea
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-07 14:58:49 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
7943c8a497
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-05 16:21:32 +01:00
Sven Strickroth
965c124d96
Fix #16698 - Wrong Absolute Links In Navigation ("/" instead of "./") 
Fixes: #16698

Signed-off-by: Sven Strickroth <email@cs-ware.de>
 2021-03-05 14:33:11 +01:00
Sven Strickroth
0754a34411
Fix #16713 - Add backward compatibility for DefaultTabServer, DefaultTabDatabase, DefaultTabTable, NavigationTreeDefaultTabTable and NavigationTreeDefaultTabTable2 
Fixes: #16713

Signed-off-by: Sven Strickroth <email@cs-ware.de>
 2021-03-05 14:31:57 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-24 23:56:33 +01:00
Maurício Meneghini Fauth
9f5a72f45e
Upgrade phpseclib to version 3 
Signed-off-by: Maurício Meneghini Fauth <mauricio@php.net>
 2021-02-22 18:01:03 -03:00
William Desportes
2e63d8f99b
Fix breadcrumbs urls 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-17 14:18:21 +01:00
William Desportes
fb53951a2d
Cover Util::handleDisableFKCheckInit and Util::handleDisableFKCheckCleanup 
Ref: #16353

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-09 17:22:58 +01:00
Saksham Gupta
8e8b7df450 Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/15389 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add Unit Test

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-01-28 16:37:07 +05:30
William Desportes
b4f1e14e80
fix or ignore phpstan 0.12.63 errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-18 22:17:18 +01:00
William Desportes
d402c0fd6b
Ref #16429 - PHP 8 error TypeError: Unsupported operand types: string / int 
1) PhpMyAdmin\Tests\Engines\PbxtTest::testResolveTypeSize with data set #2 ('A4', array('0', 'B'))
TypeError: Unsupported operand types: string / int

libraries/classes/Util.php:528
libraries/classes/Engines/Pbxt.php:156
test/classes/Engines/PbxtTest.php:175
vendor/phpunit/phpunit/phpunit:61

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-20 00:07:38 +01:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
William Desportes
5abcae9255
Fixed some typos in the code base 
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
e4e274976e Extract cache methods from Util to SessionCache class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-25 22:45:56 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
William Desportes
0d97b16d16
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-10-13 14:13:03 +02:00
Saksham Gupta
280188f1fb
Fix #16326 - Latitude and Longitudes swap 
Fixes: #16326

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2020-10-13 13:38:28 +02:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00