gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
114,367 Commits 12 Branches 481 Tags 2.4 GiB
89fbcd7c39
Commit Graph

70 Commits

Author SHA1 Message Date
William Desportes
b6e1ea68f3
Fix issue reported by Scrutinizer 
It seems like ... can also be of type null; however, parameter $existrel_foreign of PhpMyAdmin\Table::updateForeignKeys does only seem to accept array

Link: https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/72ec4952-c554-485c-b2f9-0898330b9368/issues/files/libraries/classes/Controllers/Table/RelationController.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=42062672

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-24 15:56:54 +01:00
William Desportes
28d76482b8
Fix #15591 - Undefined index: foreign_keys_data 
Fixes: #15591

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-24 14:53:21 +01:00
William Desportes
a11f0f22c8
Fix a minor error found while reviewing diffs 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-10 20:57:28 +01:00
William Desportes
8aad190ae0
Fix #14951 - Moving Columns with DEFAULT NULL doesn't work on MariaDB 10.2+ 
Ref: 98a7479174
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-09 23:08:54 +01:00
William Desportes
e9ad2bc153
Fix #14951 - Moving Columns with type INT and default CURRENT_TIMESTAMP 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-09 23:08:08 +01:00
R. Gurung
9d2eeb9378 Update libraries/classes/Controllers/Table/TableStructureController.php 
Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
 2019-08-29 13:25:57 +05:30
Rahul Gurung
517b47e0a0 fixed error in change button for column names with backslash 
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
 2019-08-22 21:17:32 +05:30
William Desportes
bef259c510
Fix NULL wrongly checked on field change 
Pull-request: #15445

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 10:04:42 +02:00
Hugues Peccatte
98a7479174 Fix NULL wrongly checked on field change 
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-19 18:00:18 +02:00
William Desportes
b4d3b07476
Fix #15363 - Remove unexpected quotes on text fields 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-15 22:13:17 +02:00
William Desportes
aab50ab37a
Replace $_REQUEST by $_GET and $_POST for GIS visualisation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:16:42 +02:00
William Desportes
bbac072fb5
Fix #15334 - export of GIS visualisation not working 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:14:52 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns 
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 20:10:57 +02:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns 
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
 2019-05-19 14:10:52 +02:00
William Desportes
35fcea7df6
Fix #14621 - add "Propose table structure" on MariaDB 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 00:33:11 +02:00
William Desportes
c745aab360
Fix php notice Undefined index: mysqlVersion 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-16 13:21:30 +02:00
William Desportes
3399e5babd
Fix spatial functions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-16 11:11:28 +02:00
William Desportes
9ed068aacb
Fix #14383 #12865 - Fix GIS functions for mysql 8.0 
Fixes: #14383
Fixes: #12865
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-16 11:11:28 +02:00
William Desportes
ab748e2fac
Fix some potential php notices after merge of #15040 
[ci skip]
See: 3d3d1a2b08
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-01 23:27:15 +02:00
apoorv
bca847f227 Fix #15010 - Sql preview show empty modal 
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
 2019-03-26 23:48:58 +01:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view 
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
75eb905727 Fix wrong property name on TableStructureController 
Introduced by 963ace6ada

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-19 14:31:10 -03:00
Maurício Meneghini Fauth
6fd9bfb75b Retrieve parameters from $_POST in table search 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d1d90b59b2 Retrieve parameters from $_POST in table relation 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d01ece698a Retrieve parameters from $_POST in tbl_indexes.php 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
9219b28f47 Retrieve parameters from $_POST in table structure 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:58 -02:00
Alessandro Dolci
fd3dde47a6 Fixed condition on the emptiness of enum type criteriaValues array (#14648) 
The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci@pm.me>
(cherry picked from commit 3f5fff3f4d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-10-30 21:09:02 -03:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125) 
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-12 03:54:28 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp() 
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-08 07:39:53 -03:00
Madhura Jayaratne
7b27484897 Fix #14239 Line and some other charts ignore result set order of values chosen for the x-axis 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-05-06 08:59:06 +10:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
741a50a905 Merge branch 'QA_4_7' 2018-03-12 19:24:44 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods 
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-27 17:39:16 -03:00
Maurício Meneghini Fauth
79ab4f4a50 Use DI for DatabaseInterface instance 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-15 15:04:37 -02:00
Maurício Meneghini Fauth
dc04987a68 Replace static methods with instance methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-15 12:31:04 -02:00
Maurício Meneghini Fauth
4c661bd1fd Move current server user global to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
e2a648881c Move DatabaseInterface object to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
dc2b2d4f6c Replace static methods with instance methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
39198725fe Use CSS to hide table structure action buttons 
Fix #13694

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-31 18:25:21 -02:00
Michal Čihař
c162a75b9b Improve javascript loading 
- jquery-ui-timepicker-addon.js is loaded in Header, no need to load it
  elsewhere
- jquery.validate.js is needed on way to many pages to benefit of
  loading only on some of them

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-15 08:36:23 +01:00
Michal Čihař
77f0d50bea Add missing dependency on jquery.validate.js 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-29 15:09:43 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage 
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
5a70c1d895 Replace globals with DI in CentralColumns class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-05 22:21:58 -02:00
Maurício Meneghini Fauth
e631affbf3 Remove unnecessary include_once 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-04 16:10:22 -02:00
Maurício Meneghini Fauth
452b624dc4 Move dependencies to outside of abstract controllers 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-04 12:41:57 -02:00
Maurício Meneghini Fauth
9b653cbba3 Port table/relation/common_form template to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-29 16:46:52 -02:00
Michal Čihař
99e47a90d9 Always define correct connection type 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-25 10:21:18 +02:00
Scrutinizer Auto-Fixer
40f56c0a95 Remove not needed use statements 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-23 18:49:37 +02:00
Maurício Meneghini Fauth
c244264092 Port table/structure/display_structure to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-23 11:31:58 -02:00
Maurício Meneghini Fauth
43bf9e5e78 Port table/structure/partition_definition_form to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-17 23:03:32 -02:00