gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,415 Commits 12 Branches 481 Tags 2.4 GiB
8a33ea334c
Commit Graph

21855 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
ee9c9a0300
Merge pull request #18297 from kamil-tekiela/measure-time-only-for-user-queries 
Measure time only for user queries
 2023-03-30 10:23:36 -03:00
Maximilian Krög
c5343eeed9 Fix gis extent calculation 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-29 21:14:40 -03:00
Kamil Tekiela
ef0ea05a8f Measure time only for user queries 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-30 00:41:38 +01:00
Maurício Meneghini Fauth
d25780fe20
Merge pull request #18255 from kamil-tekiela/Fix-ENGINE-escaping 
Fix ENGINE escaping
 2023-03-29 17:04:17 -03:00
Maurício Meneghini Fauth
46df80f58f
Merge pull request #18281 from kamil-tekiela/getTrackingIcon 
Optimize getTrackingIcon
 2023-03-29 14:14:39 -03:00
Maurício Meneghini Fauth
0301e48a27
Add ChangeLog entry for #17702 
- Closes #17702

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-24 16:35:15 -03:00
Nicolas Hervouet
e4d9a1a66a
Fix for handle large number of tables in a single database (more than 10k) 
getTablesFull was taking too much time, because MySQL do not have a real table where it stores all tables information.
So when it runs a query like select * from information_schema.TABLES ORDER BY Name limit 250 offset 0, MySQL has to read information about all tables to build his in memory table, then sort it by name, and then return 250 first tables.
But reading information about one table takes time, and that's why the query is very slow when you have a lot of tables.
Note that the problem is the same with 'SHOW TABLE STATUS'.

So, in order to speed up this query, we have to limit it to a small list of tables, as it, MySQL has to read table information only for few tables.
Note that SHOW TABLES is not that long, even with a large amount of tables.

The idea here is to use the result of SHOW TABLES query, to apply paging on this table list, and then to run the query on information_schema.TABLES only on tables we want.

Signed-off-by: Nicolas Hervouet <github@pico12.fr>
 2023-03-24 11:55:30 -03:00
Kamil Tekiela
b5ae50454d Optimize getTrackingIcon 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-22 13:07:22 +00:00
Kamil Tekiela
8550db2d11 Don't parse SQL if no tracking is in progress 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-20 16:24:35 +00:00
Kamil Tekiela
e9b9c120af Fix getTablesFull() and related tests 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-15 19:59:35 +00:00
Kamil Tekiela
3db245f462 Optimize export of many tables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-15 19:59:35 +00:00
Kamil Tekiela
d7f599df00 Accept table with name 0 in getTablesFull 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-14 22:11:05 +00:00
Kamil Tekiela
282dc9a27e Fix a bug with numerical table name 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-14 21:35:10 +00:00
Kamil Tekiela
e0e3748723 Fix ENGINE escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-13 11:58:15 +00:00
William Desportes
ae355d99b1
Merge #18177 - Fix "IS NULL" is shown for non-nullable columns on search page 
Pull-request: #18177

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-03-10 15:58:02 +01:00
Yuval Haor Noga
b305ec30fa
Ref #16451 - Increase max password length from 1000 to 2000 
Signed-off-by: Yuval Haor Noga <yuvalhnoga@gmail.com>
 2023-03-10 15:45:30 +01:00
Maurício Meneghini Fauth
29c7705e80
Merge pull request #18197 from kamil-tekiela/Fix-warning-on-non-existent-table 
Fix warning on non-existent table
 2023-03-08 10:10:28 -03:00
Maurício Meneghini Fauth
12b924d4e3
Fix wrong time zone when handling Git information 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-04 11:55:29 -03:00
Kamil Tekiela
80d7f0dfa3 Fix warning on non-existent table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-02 16:23:07 +00:00
Kamil Tekiela
7b20f58a0c Bug: IS NULL is shown for non-nullable columns 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 23:17:53 +00:00
William Desportes
f3aa3639b3
Remove chdir from GitTest after fixing #18112 
Ref: d9a6f82bc1

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-26 23:57:54 +01:00
William Desportes
d9a6f82bc1
Fix #18112 - open base dir warning on git version class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-26 23:31:28 +01:00
Kamil Tekiela
aa63c6821a Fix bug related to tables with numerical names 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-22 13:18:06 +00:00
William Desportes
496bd0f3d0
Remove non used code of explain button (Generator::generateRowQueryOutput) 
Since: f1581cfe9b

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:51:26 +01:00
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314 
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:47:59 +01:00
William Desportes
7d4eafd188
Fix #16851 - Default column order doesn't have have any effect ($cfg['Order']) since phpMyAdmin 4.2.0 
Introduced by a05ab9640b

See: a05ab9640b (diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dL2022-L2040)

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-20 23:52:38 +01:00
William Desportes
f3bd71d937
Fix a coding-standard issue 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-20 23:52:37 +01:00
William Desportes
4ce69f3a3d
Nicely exit in case of an early PHP type crash 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-20 23:51:21 +01:00
Maurício Meneghini Fauth
6eb4b4d5ad
Merge pull request #18120 from kamil-tekiela/bug-with-numerical-table-names-during-rename 
Fix bug with numerical tables during renaming DB
 2023-02-20 13:43:51 -03:00
Kamil Tekiela
fa339143ea
Fix renaming db with a view (#18106) 
* Fix renaming DB with a view

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add test for the bug

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-20 13:36:46 -03:00
Kamil Tekiela
69f7a915eb Replace getTablesFull with getTables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-18 14:33:41 +00:00
Liviu-Mihail Concioiu
a6e0957d94 Update links 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-02-17 18:42:01 +01:00
Maurício Meneghini Fauth
b4f15ab6a0
Fix missing default_action parameter when copying rows 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17923

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-15 16:37:05 -03:00
Maurício Meneghini Fauth
ae560e0ffb
Prepare for version 5.2.2-dev 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-08 11:28:34 -03:00
William Desportes
9d92dafdcb
Merge #17923 - Fix #17766 - Allow to open in a new tab copy and edit row actions 
Pull-request: #17923
Fixes: #17766

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:13:39 +01:00
William Desportes
2443570ce6
Merge #17851 - Fix #17028, #17683 - Re build query count management 
Pull-request: #17851
Fixes: #17028
Fixes: #17683

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:12:00 +01:00
Isaac Bennetch
372185c302 Prepare for version 5.2.1 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2023-02-07 16:20:27 -05:00
Liviu-Mihail Concioiu
f45cd23222 Remove double quotes 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-01-31 22:57:56 +01:00
William Desportes
6d482de7b8
Add back UUID and UUID_SHORT to functions on MySQL and all MariaDB versions 
Ref: https://github.com/phpmyadmin/phpmyadmin/pull/17767

It was a mistake to remove the UUID functions, they are not the UUID type

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-20 20:18:55 +04:00
William Desportes
305fe52d9e
Fix #18019 - Error: "Call to a member function fetchAssoc() on bool" with SQL mode ONLY_FULL_GROUP_BY 
Fixes: #18019

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-20 19:36:52 +04:00
William Desportes
89adbcfe9b
Fix PSR-7 implementation for GET and test implementation for POST 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-20 13:17:12 +04:00
Daniel Kesselberg
79eacd6040
fix: remove analyze explain button 
The service mariadb.org/explain_analyzer is unavailable.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-01-17 17:14:38 +04:00
Maurício Meneghini Fauth
f143d2a709
Add support for Web Authentication API 
Adds a two factor authentication plugin that supports FIDO2/WebAuthn
security keys.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-16 18:20:05 -03:00
Liviu-Mihail Concioiu
38deec06cd Fix uuid column move 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-01-07 18:05:14 +01:00
Maurício Meneghini Fauth
dfd5f13078
Fix some errors detected by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-05 16:27:20 -03:00
William Desportes
9eec5d8be8
Add a reservation of 1 second to allow interrupt shutdown code to render 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-01 09:54:52 +04:00
William Desportes
19c4657f39
#17999 - Remove modals from the login page 
It shows weird buttons

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-12-30 15:52:16 +04:00
Maurício Meneghini Fauth
f6a03d405d
Improve type inference of TwoFactor::$config 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-28 15:50:43 -03:00
Maurício Meneghini Fauth
4e49c7760a
Add support for more PSR-7 packages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-19 01:40:05 -03:00
Maurício Meneghini Fauth
63102c1253
Add unit test for Plugins\TwoFactor\Key::getRegistrations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-15 22:54:33 -03:00