gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,748 Commits 12 Branches 481 Tags 2.4 GiB
8bb312514e
Commit Graph

32 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
78be90b34b
Merge pull request #18418 from kamil-tekiela/strlen 
Remove strlen in boolean conditions
 2023-05-16 17:23:58 -03:00
Kamil Tekiela
4ec3b99ba3
Improve boolean conditions with arrays (#18417) 
* Remove empty() on array

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove boolean count()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 15:16:26 -03:00
Kamil Tekiela
c13f68ccc7 Remove strlen in boolean conditions 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 17:45:07 +01:00
William Desportes
25bd2ac711
Merge #18223 - Add a configuration option to allow shared bookmarks: $cfg['AllowSharedBookmarks'] 
Pull-request: #18223

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-06 12:02:50 +02:00
Maurício Meneghini Fauth
5ffe2847ac
Remove Config::checkServers() method 
Removes the Config::checkServers() method as it's duplicated in
Config\Settings class.
Also uses the Settings class to filter invalid config keys when loading
a config file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-29 14:50:18 -03:00
Maurício Meneghini Fauth
74ba4f17b0
Remove config global var from Logging class 
Uses the Settings class to access the log settings.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-27 14:38:18 -03:00
Erki Aring
c716102d09
Add configuration option to allow shared bookmarks 
Signed-off-by: Erki Aring <erki@example.ee>
 2023-04-14 12:09:01 +03:00
Erki Aring
b7ce755f07 Make database and web server info separately configurable 
Signed-off-by: Erki Aring <erki@example.ee>
 2023-03-10 10:12:24 +02:00
Maurício Meneghini Fauth
8123a81235
Remove $GLOBALS['cfg'] from BrowseForeigners class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-03 16:15:40 -03:00
Maurício Meneghini Fauth
687c51dc1e
Replace $GLOBALS['cfg']['ZeroConf'] in Common class 
Replaces it with PhpMyAdmin\Config\Settings::$zeroConf access.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-02 17:55:58 -03:00
Maurício Meneghini Fauth
5c5e8c2de1
Replace $GLOBALS['cfg']['MysqlMinVersion'] in Common class 
Replaces with PhpMyAdmin\Config\Settings::$mysqlMinVersion access.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-02 17:29:54 -03:00
Maurício Meneghini Fauth
a035b5173d
Refactor Config\Settings::toArray() method 
Rename it to asArray() and remove get_object_vars() function call.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:55:40 -03:00
Maurício Meneghini Fauth
684d8973ec
Add Config\Settings\Transformations::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:30:35 -03:00
Maurício Meneghini Fauth
afcb4e406d
Add Config\Settings\SqlQueryBox::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:22:56 -03:00
Maurício Meneghini Fauth
51a20c09fc
Add Config\Settings\Server::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:16:26 -03:00
Maurício Meneghini Fauth
7fde991c6a
Add Config\Settings\Schema::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:01:53 -03:00
Maurício Meneghini Fauth
2ef2e44201
Add Config\Settings\Import::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 14:54:28 -03:00
Maurício Meneghini Fauth
395e46d637
Add Config\Settings\Export::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 14:45:38 -03:00
Maurício Meneghini Fauth
50f9a90275
Add Config\Settings\Debug::asArray() method 
Refactor the test to test each property individually.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 14:28:01 -03:00
Maurício Meneghini Fauth
7f5a1b799f
Add Config\Settings\Console::asArray() method 
Refactor the test to test each property individually.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-28 17:52:40 -03:00
Maurício Meneghini Fauth
25cce47ae2
Merge config.default.php with Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-28 12:19:02 -03:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Kamil Tekiela
69f8d9f85c Replace switch with match 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-14 13:07:00 +00:00
Maurício Meneghini Fauth
700db7e72b
Update the docs to reflect the blowfish_secret changes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:34:13 -03:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
229d8dfb5e
Extract Console, Debug and SqlQueryBox classes from Settings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-19 13:17:32 -03:00
Maurício Meneghini Fauth
73034e43e1
Extract setter methods from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-18 12:44:48 -03:00
Maurício Meneghini Fauth
229767bc30
Add more tests for Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-02 19:29:45 -03:00
Maurício Meneghini Fauth
437bd7c974
Create Settings value object for $cfg global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-31 15:59:24 -03:00