gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,748 Commits 12 Branches 481 Tags 2.4 GiB
8bb312514e
Commit Graph

57 Commits

Author SHA1 Message Date
Kamil Tekiela
c4421d064d Improve type hint 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:29:34 +01:00
Maurício Meneghini Fauth
e7d1ecbeae
Merge pull request #18419 from kamil-tekiela/UseIdenticalOverEqualWithSameTypeRector 
UseIdenticalOverEqualWithSameTypeRector
 2023-05-16 17:28:52 -03:00
Kamil Tekiela
4ec3b99ba3
Improve boolean conditions with arrays (#18417) 
* Remove empty() on array

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove boolean count()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 15:16:26 -03:00
Kamil Tekiela
0f351a5822 UseIdenticalOverEqualWithSameTypeRector 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 19:13:49 +01:00
Kamil Tekiela
dc471985b9
Short boolean conditions (#18413) 
* Short boolean conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 11:09:21 -03:00
Kamil Tekiela
c94657bf77 Use empty string as sentinel instead of false 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 12:36:55 +01:00
Kamil Tekiela
82427ce600 Update psalm-baseline.xml 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-03 15:25:05 +01:00
Maurício Meneghini Fauth
e104f66d97
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-11 15:46:30 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-08 13:42:44 +02:00
Maurício Meneghini Fauth
656474179d
Merge pull request #18318 from kamil-tekiela/refactor-relation 
Refactor relation
 2023-04-05 10:43:03 -03:00
Maurício Meneghini Fauth
9d844613d0
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-05 10:24:00 -03:00
Kamil Tekiela
357680474e Memoize Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-04 11:59:29 +01:00
Kamil Tekiela
e7717ed186 Fix bug preventing disabling tracking feature 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-03 12:22:31 +01:00
Kamil Tekiela
9fcafd2504 Improve method name 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:50:46 +01:00
Kamil Tekiela
cd9ca8419a Use array_fill_keys 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:38:25 +01:00
Kamil Tekiela
49cb7e89b2 Invert the logic to make it easier to understand 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:38:25 +01:00
Kamil Tekiela
aef2a96012 Move getDefaultPmaTableNames out of the loop 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 23:38:24 +01:00
Kamil Tekiela
850e867136 Extract getTableReplacementNames 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-02 22:08:07 +01:00
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints 
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:47:43 +00:00
Kamil Tekiela
3774c29604 Fix implicit nulls 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb Add native param types 
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
e8c5eef6f8
Remove annoying empty statements (#18114) 
* Remove annoying empty statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make $extra strict and stop passing false to it

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make $page strict and stop passing null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 20:11:37 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Kamil Tekiela
912f179432 Add Connection::TYPE_CONTROL to quoteString 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 22:36:01 +00:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Kamil Tekiela
98cfc64667 Remove escapeString from Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-10 16:32:00 -03:00
Maurício Meneghini Fauth
41dec1effc
Extract connection type constants to the Connection class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-17 02:21:27 -03:00
Kamil Tekiela
9a8dc40ae9 Remove usage of elvis operator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 19:50:58 +00:00
Kamil Tekiela
3b49a5bedb Implement quoteString() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-06 19:06:48 +00:00
Kamil Tekiela
2c416128e5 Pass as argument to Table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 22:30:33 +01:00
Maurício Meneghini Fauth
e453c57fb8
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-17 16:24:34 -03:00
Rodrigo Pokemaobr
5a57873744 Removing types from in RelationExtension for avoid null error on global 
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
 2022-05-17 15:11:46 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
1faab7119d
Fix bug when renaming tables with config storage enabled 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17359

Introduced by https://github.com/phpmyadmin/phpmyadmin/pull/17256

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-09 13:58:35 -03:00
Isaac Bennetch
985912f58f Fix merge conflicts from security branch 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:41:16 -03:00
Kamil Tekiela
a4b2d7e524 Deimplement fetchRow() helper 
This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
4e0141e19f
Merge pull request #17253 from kamil-tekiela/fetchValue 
Remove $row_number from DatabaseInterface::fetchValue
 2021-12-23 11:40:25 -03:00