gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,748 Commits 12 Branches 481 Tags 2.4 GiB
8bb312514e
Commit Graph

1523 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5a344966a9
Move trigger row foreach loop into the list.twig template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 16:03:45 -03:00
Maurício Meneghini Fauth
81e988aac8
Inline Triggers::main() into the Triggers\IndexController 
The main() method is handling the request/response, so it's better to
move this code to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:40:16 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers 
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
62ec1bcc2c
Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4 
InsertEdit refactoring - part 4
 2023-05-24 21:16:01 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2 
Replace superglobals with serverrequest in GetFieldController
 2023-05-24 15:31:24 -03:00
Kamil Tekiela
7838a42a34 Move buildInsertSqlQuery to Generator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Kamil Tekiela
1d180c5482 Use null as sentinel value in getColumn 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
3b611f3945 Implement ColumnFull DTO 
This is MVP. In following commits the DTO will be expanded and improved.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:29:34 +01:00
Kamil Tekiela
231ec1ba8b Remove QBE 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 11:21:46 +01:00
Maurício Meneghini Fauth
2bf3cb587d
Merge pull request #18426 from kamil-tekiela/variableless-exceptions 
Don't catch exception into variable
 2023-05-18 20:45:12 -03:00
Kamil Tekiela
97da6c9721 Don't catch exception into variable 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 23:09:51 +01:00
Kamil Tekiela
15a83c32af $db in addNewRelation() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 22:50:32 +01:00
Kamil Tekiela
4ec3b99ba3
Improve boolean conditions with arrays (#18417) 
* Remove empty() on array

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove boolean count()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 15:16:26 -03:00
Maurício Meneghini Fauth
64b0fd54c7
Merge pull request #18397 from kamil-tekiela/Fix-18396 
Fix #18396 - Export page always exports data
 2023-05-12 13:51:28 -03:00
Kamil Tekiela
94eee89a60
Remove unused param (#18398) 
* Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Removed unused param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Narrow return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 13:49:28 -03:00
Maurício Meneghini Fauth
58c3e059c2
Merge pull request #18407 from kamil-tekiela/Useless-foreach 
Remove useless foreach
 2023-05-12 12:16:47 -03:00
Maurício Meneghini Fauth
20d206a705
Merge pull request #18412 from kamil-tekiela/ShortenElseIfRector 
Shorten else/if to elseif
 2023-05-12 11:16:00 -03:00
Kamil Tekiela
dc471985b9
Short boolean conditions (#18413) 
* Short boolean conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 11:09:21 -03:00
Kamil Tekiela
176645be7b Shorten else/if to elseif 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 00:12:58 +01:00
Kamil Tekiela
4a4f8ae063 Remove useless foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-11 23:02:29 +01:00
Evgeny Skorlov
9590ba6bc1 Replace superglobals with serverrequest in GetFieldController with fixes 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-05-10 23:03:11 +11:00
Maurício Meneghini Fauth
8bbb1edbea
Remove ThemeManager::getInstance() method 
Remove singleton from the Theme\ThemeManager class and uses DI where
possible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-09 21:29:49 -03:00
Kamil Tekiela
2e3de28080 Fix #18396 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-09 13:29:01 +01:00
William Desportes
b5899c2d53
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-06 11:25:42 +02:00
Liviu-Mihail Concioiu
4951bc7fea Update CVE link with the new one 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-05-06 01:06:11 +02:00
William Desportes
66f607c608
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-04 22:30:56 +02:00
Kamil Tekiela
a01eefc4c2 Remove $timestampSeen which was always false 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
36481a0dca Change if into its short form 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
ae5b5a1a86 Remove $jsvkey and $vkey 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
fbb185e7a9 Remove globals 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
9124c19539 Remove $GLOBALS['columns_cnt'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
bfe1f4facf Remove redundant argument 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
b2357568a1 Use str_ends_with and str_starts_with 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
269535a7a5 Change $tabindex into a private property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
a8070b5498 $tabindexForValue was always 0 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
62459b33e5 Change RW param into a private property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
747941ece1 Move $returnToSqlQuery out of the method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:04 +01:00
William Desportes
99881debb5
Fix lint route not working correctly 
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-04-22 14:52:35 +02:00
Kamil Tekiela
5cd6c16684 Instead of returning array, use array cast 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
a852acb3e9 Move $isInsertignore out of getParamsForUpdateOrInsert 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
56d1eed358 Remove MAX_FILE_SIZE 
This is not used anywhere in frontend or backend.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
8367af19be Remove unused $biggestMaxFileSize param 
Not sure if it should have been a global, but judging by the rest of the code, I believe it's no longer needed.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:18 +01:00
Maurício Meneghini Fauth
45c7d30093
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 16:38:00 -03:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
8c7c87f524
Merge pull request #18308 from win20/navigation-panel-settings-icon-issues 
Fix issues with settings icon in nav panel
 2023-04-12 16:17:48 -03:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 15:49:31 -03:00
Maurício Meneghini Fauth
514ed287c6
Merge pull request #18328 from MoonE/fieldmetadata 
Refactor DbiDummy and improve FieldMetadata
 2023-04-12 14:13:20 -03:00