Commit Graph

100 Commits

Author SHA1 Message Date
William Desportes
f4c6ec504c
Fix #15697 - Uncaught Error: Call to a member function get() on null in db_export.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-25 10:44:42 +01:00
Hugues Peccatte
df847d7121 Remove useless 'use'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-15 21:40:21 +02:00
Hugues Peccatte
a395bd2823 Remove as much as possible the old DI system
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-15 21:39:21 +02:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Maurício Meneghini Fauth
3a7a0c6e58 Remove $url_query global from PHPStan ignored list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 22:18:58 -03:00
Maurício Meneghini Fauth
82a03931d6 Remove $table global from ignored errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 15:17:57 -03:00
Maurício Meneghini Fauth
45546661aa Remove $db from ignore errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 14:54:21 -03:00
Maurício Meneghini Fauth
17195fbe72 Get $dbi from DIC instead of global in entry points
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-18 01:09:38 -03:00
Maurício Meneghini Fauth
7f793cdd59 Use DI for $dbi global in Export class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-17 22:10:43 -03:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
f367a1b98d
Merge pull request #14793 from mauriciofauth/html-closing-tags
Remove unnecessary HTML closing tags
2018-12-20 22:30:39 -02:00
William Desportes
3d28438949
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-19 11:04:28 +01:00
William Desportes
09e2585158
Fix #14791 - php warning, db_export.php#91 urldecode()
Fixes: #14791 - php warning, db_export.php#91 urldecode() expects parameter 1 to be string, array given
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-19 10:56:47 +01:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Maurício Meneghini Fauth
c1cdaac2f4 Retrieve parameters from $_POST in export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
2638eb9207 Refactor PhpMyAdmin\Export static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 19:28:25 -03:00
Maurício Meneghini Fauth
f45d4a566b Refactor PhpMyAdmin\Display\Export class
The static methods are replaced with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-13 23:51:16 -02:00
Michal Čihař
94bb2e31a1 Remove no longer needed page_settings.forms.php and user_preferences.forms.php
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:04:47 +02:00
Maurício Meneghini Fauth
54cfbc5eda Refactor export functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-05 12:07:49 -03:00
Maurício Meneghini Fauth
43ff4566d0 Refactor display_export to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-04 10:15:47 -03:00
Michal Čihař
ec9fe20e48 Use Response::addHTML to render error message
This way the rendering is explicit instead of relying on hidden logic in
handling global variables.

See #13585

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-16 15:55:24 +02:00
Manish Bisht
7ba7db2806 show error message on export page when database is empty
Signed-off-by: Manish Bisht <manish.bisht490@gmail.com>
2017-08-14 06:56:32 +05:30
Maurício Meneghini Fauth
5e7f6a1bab Move config classes to PhpMyAdmin namespace
- Move ConfigFile to PhpMyAdmin namespace
- Move FormDisplay to PhpMyAdmin namespace
- Move Form to PhpMyAdmin namespace
- Move PageSettings to PhpMyAdmin namespace
- Move ServerConfigChecks to PhpMyAdmin namespace
- Move Validator to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-09 15:16:37 -03:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
119563b7ea Move classes to PhpMyAdmin namespace
- Move OpenDocument to PhpMyAdmin namespace
- Move OutputBuffering to PhpMyAdmin namespace
- Move Partition to PhpMyAdmin namespace
- Move Pdf class to PhpMyAdmin namespace
- Move RecentFavoriteTable to PhpMyAdmin namespace
- Move Response to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 23:44:10 -03:00
Maurício Meneghini Fauth
54a15dbd9c Move classes to PhpMyAdmin namespace
- Move Logging to PhpMyAdmin namespace
- Move Menu to PhpMyAdmin namespace
- Move Message to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 13:30:04 -03:00
Michal Čihař
f36f61314f Remove odd/even markup
Issue #12070

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 10:17:15 +01:00
Michal Čihař
4222000549 Merge branch 'QA_4_6' 2016-11-15 15:22:49 +01:00
Michal Čihař
46eaa53ddd Check parameter type before processing
Fixes #12443

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-11-15 15:22:32 +01:00
Madhura Jayaratne
d1ac2a64a5 Fix #12017 Cannot easily select multiple tables when exporting
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-02-23 19:58:18 +11:00
Marc Delisle
1a75c88b76 Add missing checks
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-10-18 07:30:16 -04:00
Hugues Peccatte
fa801c507f Set namespace on plugins classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 12:51:45 +02:00
Hugues Peccatte
b92491d799 Merge branch 'master' into useNamespaces_master 2015-09-12 00:53:39 +02:00
Marc Delisle
77c0d66a1b Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-11 13:37:54 -04:00
Marc Delisle
f1823798ff Remove duplication
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-11 13:15:49 -04:00
Marc Delisle
27e54fb194 Refactor to remove display_export.inc.php
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-09-11 11:44:26 -04:00
Hugues Peccatte
e6c142bc56 Add missing require.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-06 12:44:03 +02:00
Hugues Peccatte
6f84933a00 Add missing require.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-06 01:20:11 +02:00
Hugues Peccatte
e5e447e937 Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:23 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Marc Delisle
bb01f9b2b7 Refactor db_info.inc.php
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-25 11:16:59 -04:00
Hugues Peccatte
08919d9252 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-25 09:36:48 +02:00
Marc Delisle
fec98e1450 As suggested by Scrutinizer
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-07-18 14:57:44 -04:00