Commit Graph

50 Commits

Author SHA1 Message Date
William Desportes
8a0f006775
Fix php notice "Trying to access array offset on value of type bool"
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-23 12:40:11 +01:00
William Desportes
68cfb777a5
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:37:58 +01:00
William Desportes
770f30aa86
Fix display field in Designer
Introduced by: a23f2ba51a

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:29:07 +01:00
William Desportes
5a83a289d8
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 12:02:54 +01:00
William Desportes
8343320841
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 16:02:41 +02:00
William Desportes
58f56111df
Fix reloading a designer page
- Added cast to be sure pageNumber is an int -1 or postitive

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 11:40:13 +02:00
William Desportes
b8527d90dd
Fix typo introduced by 1af61f88b3
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 13:49:25 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Hugues Peccatte
de57539fb7 Build "tables list" in JS
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:01:17 +02:00
Hugues Peccatte
14ba5a1b24 Retrieve DB instead of relying on current one
When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 22:23:35 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Hugues Peccatte
69895e4bb1 Use "strpos" instead of "strstr" to improve performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:58:05 +02:00
William Desportes
40cc2dc813
Fix @var comments to match the phpdoc reference
See: http://docs.phpdoc.org/references/phpdoc/tags/var.html

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 10:54:43 +02:00
Maurício Meneghini Fauth
e49d46b277 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-28 14:51:43 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Madhura Jayaratne
d676d6941f Issue phpmyadmin-security/267 SQL injection in Designer feature
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-12-26 22:48:47 +11:00
William Desportes
18c23df20f
Issue #13032 - fix designer on QA_4_8
Used cherry-pick : Merge pull request #14376 from williamdes/issue-13032-designer

Cherry-picked-from: cb2dae58be

Issue #13032 - fix designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 20:19:02 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Gemorroj
f020ffe03a fix designer
Signed-off-by: Gemorroj <wapinet@mail.ru>
2018-07-21 15:17:37 +03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
William Desportes
27bd5902ad
Fix issue reported by scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-15 21:37:46 +02:00
William Desportes
096d170e04
Move designer config to javascript w/json
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-15 21:37:32 +02:00
Leonardo Strozzi
0d26cfb5f1 Finish db designer refactor
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-11 19:37:07 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 23:06:31 -03:00
Maurício Meneghini Fauth
66f2e4a2dc Remove $dbi global from Database classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 22:46:41 -03:00
Maurício Meneghini Fauth
764f7a7dde Enable strict mode in Database classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:18:52 -03:00
Maurício Meneghini Fauth
ca7fd2b2c7 Fix case where 'query' is always considered defined
Related to #14079

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-27 18:44:28 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
c7f3d6e4e6 Rename $GLOBALS['PMD'] to $GLOBALS['designer']
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 17:45:48 -03:00
Maurício Meneghini Fauth
ce42c68823 Fix some coding styles issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-23 12:06:54 -03:00
Maurício Meneghini Fauth
92beb1a4f4 Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 23:58:41 -03:00
Maurício Meneghini Fauth
1f98dcf1c2 Fix designer not showing table column information
Fix #13809

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-12 02:11:47 -02:00
Maurício Meneghini Fauth
b35892e6d5 Port database/designer/database_tables to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-14 15:18:35 -03:00
Maurício Meneghini Fauth
e29665b5de Port database/designer/table_list to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-14 12:33:49 -03:00
Maurício Meneghini Fauth
07f1de003d Port database/designer/side_menu to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-14 09:59:35 -03:00
Maurício Meneghini Fauth
5995c4967c Port database/designer/page_save_as to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-14 09:59:35 -03:00
Maurício Meneghini Fauth
f54cfe5d42 Port database/designer/edit_delete_pages to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-14 09:59:35 -03:00
Maurício Meneghini Fauth
0b0833fbd6 Remove Database\Designer::getHtmlForPageSelector
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-12 11:27:41 -03:00
Maurício Meneghini Fauth
565014656f Port database/designer/page_selector to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-12 11:07:16 -03:00
Maurício Meneghini Fauth
f7be7ceec1 Port database/designer/query_details to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-11 23:28:12 -03:00
Maurício Meneghini Fauth
1621e1ab8a Port database/designer/js_fields template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-07 00:04:06 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
700e081833 Refactor plugin_interface functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 17:36:39 -03:00
Maurício Meneghini Fauth
8079fd7009 Refactor db_designer functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-05 16:41:48 -03:00