Commit Graph

51 Commits

Author SHA1 Message Date
William Desportes
990323e8db
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 23:51:19 +02:00
Jack Cherng
b89c17c7d7
Fix PHP 7.4 accessing offset on null/bool
null['xxx'] or false['xxx'] emits a notice in PHP 7.4.

Problematic pages:

- phpMyAdmin/db_tracking.php?db=DB_NAME
- phpMyAdmin/server_privileges.php?adduser=1
- some other pages using POST method...

0e6e2297fc/UPGRADING (L25-L28)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-07-27 09:14:13 +08:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c9129e9bd8 Remove unnecessary string concatenation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 17:47:33 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Hugues Peccatte
68b88d0537 Remove useless variables before return
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:33:22 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
ad7f7fd801 Retrieve parameters from $_POST in tracking pages
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Leonardo Strozzi
3b8746547d Fix php code sniffer errors
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-07-08 18:31:04 -03:00
Leonardo Strozzi
bcad25a84a Refactor table_tracking main tamplates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-07-08 17:40:59 -03:00
Leonardo Strozzi
491ce9a669 Refactor db_tracking templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-25 23:42:22 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
d0c1876552 Refactor PhpMyAdmin\SqlQueryForm static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-04 17:34:16 -03:00
Maurício Meneghini Fauth
5f0a7908cb Replace static methods with instance methods
Replaces PhpMyAdmin\Tracking static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 03:35:56 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
c65e9c330e Remove @ operator from ini_set()
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
1637796ca6 Use template for getHtmlForDataStatements method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 13:34:09 -02:00
Maurício Meneghini Fauth
2f84cecdb9 Use template for getHtmlForOneStatement method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
220b94caa0 Use template for getHtmlForSelectableTables method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
5128fd4c29 Use template for getHtmlForDataDefinitionAndManipulationStatements
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
925c2e0863 Use template for getHtmlForColumns method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
d5fedaf4c7 Use template for getHtmlForIndexes method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
09f7fb12d7 Use template for getHtmlForIndex method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
117d2950d8 Remove Tracking::getHtmlForField method
Using template call istead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
4f47e9d6cf Use template for getHtmlForField method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
64e36d8746 Use template for getHtmlForActivateDeactivateTracking
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
5733c1302f Refactor Tracking::displayUntrackedTables method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
5fc6631b8f Use template for displayUntrackedTables method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-10 11:42:53 -02:00
Maurício Meneghini Fauth
261c39c815 Refactor Tracking::displayTrackedTables
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 17:35:07 -02:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
56fe75d730 Refactor sql_query_form functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-13 19:09:59 -03:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Deven Bansod
36d8d98988 Fix error introduced in f36ed72 (#13602)
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2017-08-22 15:32:52 +05:30