William Desportes
62a6591d3f
Fix some phpcs issues after latest phpcs 3.5.5 release
...
I left the false positives unfixed: https://github.com/squizlabs/PHP_CodeSniffer/issues/2937#issuecomment-615498860
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 01:01:38 +02:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 16:59:26 +01:00
William Desportes
850c125684
Fix #14732 Can't rename primary key with auto increment
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-16 23:46:35 +01:00
William Desportes
f8688c2774
Merge branch 'QA_4_9' into 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 14:47:24 +02:00
William Desportes
3b116de260
Fix tests for "NULL wrongly checked on field change"
...
Pull-request: #15445
Introduced-by: bef259c510
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 14:42:43 +02:00
Maurício Meneghini Fauth
e99f3ace5c
Move DbiDummy extension to the test directory
...
DbiDummy extension is only used for testing purposes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 18:00:36 -03:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae
Reference class names in use statements
...
Sort use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
92cc67fbf7
Replace assertContains() with assertStringContainsString()
...
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f
Add void return type declaration for tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
25e480666e
Fix doc comments alignment
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
76d8bfdafa
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
William Desportes
f0b51c144f
Remove unused code in tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00
Maurício Meneghini Fauth
d745d1ce01
Retrieve parameters from $_POST in Table class
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d4b4124a5e
Remove $GLOBALS['dbi'] from Relation class
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
William Desportes
2e6a80c47d
Fix tests for regression #14422
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-15 18:40:08 +02:00
Maurício Meneghini Fauth
2d58411bee
Some coding style fixes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
285e38e931
Fix some PSR-2 coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
baf0985e5f
Fix phpcs errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8
Enable strict mode in test files
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
de250fbae3
Fix MariaDB 10.2 current_timestamp()
...
Fixes #13968 and fixes #13999 . Closes #14177 .
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:39:53 -03:00
Maurício Meneghini Fauth
d98658187a
Replace PhpMyAdmin\Relation static calls
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Michal Čihař
4fe87fb592
Remove usage of $GLOBALS['controllink']
...
This is now stored internally inside DatabaseInterface instance.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Scrutinizer Auto-Fixer
40f56c0a95
Remove not needed use statements
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-23 18:49:37 +02:00
Maurício Meneghini Fauth
c00245fa0a
Move PMATestCase to PhpMyAdmin\Tests\PmaTestCase
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-30 16:34:53 -03:00
Maurício Meneghini Fauth
df30240015
Add namespace to test classes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-20 13:03:50 -03:00
Michal Čihař
a82f8fc768
Move databaase interface load to static method
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:56 +02:00
Maurício Meneghini Fauth
e2c83b954b
Refactor relation functions to static methods
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Michal Čihař
4a83171c30
Merge branch 'QA_4_7'
2017-08-01 09:09:19 +02:00
Michal Čihař
e85fc1cdff
Fix mocked value
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 08:50:26 +02:00
Maurício Meneghini Fauth
6c6e86927a
Move DBI classes to PhpMyAdmin namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-15 15:52:10 -03:00
Maurício Meneghini Fauth
ca910e8de8
Move classes to PhpMyAdmin namespace
...
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
13c0f7bc3c
Move classes to PhpMyAdmin namespace
...
- Move Advisor to PhpMyAdmin namespace
- Move Bookmark to PhpMyAdmin namespace
- Move Charsets to PhpMyAdmin namespace
- Move Config class to PhpMyAdmin namespace
- Move Console class to PhpMyAdmin namespace
- Move Core to PhpMyAdmin namespace
- Move DatabaseInterface to PhpMyAdmin namespace
- Move DbList to PhpMyAdmin namespace
- Move DbQbe to PhpMyAdmin namespace
- Move DbSearch to PhpMyAdmin namespace
- Move DisplayResults to PhpMyAdmin namespace
- Move Encoding to PhpMyAdmin namespace
- Move Error to PhpMyAdmin namespace
- Move ErrorHandler to PhpMyAdmin namespace
- Move File to PhpMyAdmin namespace
- Move Font to PhpMyAdmin namespace
- Move Footer to PhpMyAdmin namespace
- Move Header to PhpMyAdmin namespace
- Move Index to PhpMyAdmin namespace
- Move IndexColumn to PhpMyAdmin namespace
- Move LanguageManager to PhpMyAdmin namespace
- Move Language to PhpMyAdmin namespace
- Move Linter to PhpMyAdmin namespace
- Move ListAbstract to PhpMyAdmin namespace
- Move ListDatabase to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-28 21:17:18 -03:00
Michal Čihař
159e748a2b
Simplify getting table create options
...
- use saner method name (getCreateOptions)
- fix error case
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:56:08 +01:00
Michal Čihař
a51ac4ef8b
Simplify getting row format
...
- remove not needed word Table from method name
- fix code to handle errors
- convert existing users of getStatusInfo('ROW_FORMAT') to this method
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:56:08 +01:00
Michal Čihař
44d3cb3869
Simplify getting table collation
...
- remove not needed word Table from method name
- fix code to handle errors
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:56:08 +01:00
Michal Čihař
b2bf9fba87
Simplify getting table comment
...
- remove not needed word Show from method name
- fix code to handle errors
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:56:08 +01:00
Michal Čihař
56046cc7e2
Simplify getting storage engine
...
- remove not needed word Table from method name
- fix code to handle errors
- convert existing users of getStatusInfo('ENGINE') to this method
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:56:08 +01:00
Michal Čihař
9f2773c9c2
Simplify rereading of information
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:55:38 +01:00
Vishal Pandey
5da44ce1a6
Move the tbl_info.inc.php code to Table class
...
Fixes #12567
Signed-off-by: flash1452 <vishpandey2014@gmail.com>
2017-03-20 17:55:21 +01:00
Michal Čihař
a4a262c52a
Merge branch 'QA_4_6'
2017-01-18 09:59:55 +01:00
Michal Čihař
89357ee0f1
Share code for getting lower_case_table_names value
...
Issue #12861
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-18 09:58:29 +01:00
Michal Čihař
b56f101039
Remove is_ajax_request global
...
We already have the same information on Response object, so let's use it
from there.
Issue #11731
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 17:54:34 +01:00
Michal Čihař
dad93483c1
Merge branch 'QA_4_6'
2016-11-10 11:08:36 +01:00
Michal Čihař
c9348b682e
Merge remote-tracking branch 'origin/pull/12564' into QA_4_6
2016-11-10 10:59:33 +01:00
Michal Čihař
5dc004dfe0
Merge branch 'QA_4_6'
2016-11-09 18:15:29 +01:00
Michal Čihař
14ccebbd4b
Merge remote-tracking branch 'origin/pull/12685' into QA_4_6
2016-11-09 18:14:53 +01:00
Michal Čihař
2c90866b18
Merge branch 'QA_4_6'
2016-11-08 14:46:01 +01:00