gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,923 Commits 12 Branches 481 Tags 2.4 GiB
8eb023bcce
Commit Graph

67 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-13 21:08:00 -03:00
Maurício Meneghini Fauth
a0e4afff04
Replace $_POST with ServerRequest object in Table\OperationsController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-09 02:11:16 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
dc7090386b
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-21 16:51:47 -03:00
Maurício Meneghini Fauth
9e4f3833a5
Fix Table\OperationsController failing test 
The Partition::getPartitionNames method returns [0=>null] when no
partitions were found.

Related to 346d6c7981.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-21 16:35:36 -03:00
Maurício Meneghini Fauth
4c12e7a5f9 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-20 20:58:48 -03:00
Maurício Meneghini Fauth
346d6c7981 Fix error in table operation page when partitions are broken 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17496

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-20 20:52:55 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00
Maurício Meneghini Fauth
a8d514a350
Remove db and table globals from DbTableExists class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-28 16:43:48 -03:00
Kamil Tekiela
73b7094b2b Remove redundant isset 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
78c266d98f
Move partition classes to the Partitioning namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-21 14:01:25 -03:00
William Desportes
fcd0a2393a
Fix coding standard issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:44:05 +02:00
William Desportes
c830c1e93a
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:34:29 +02:00
William Desportes
f724f648e1
Fix #16976 - Wrong link when a table is moved from a database to another 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:13:03 +02:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 19:39:28 -03:00
William Desportes
7aabad9b7a
Move queries from Operations class to the Query\Generator class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 02:11:25 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
36d93cf2f9 Remove Common::table method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-08 13:32:25 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view 
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
e5328434bf Extract response from Operations class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-14 20:18:03 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00