Commit Graph

815 Commits

Author SHA1 Message Date
Marc Delisle
03debd0a6e Refactor: we had three similar functions, refactored into just one.
Also, these functions returned false, or a string containing the type,
but the string was only used to indirectly mean a true value; now
we explicitely return true in this case.

Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-04 08:27:50 -04:00
Chanaka Dharmarathna
4e68ada908 Remove dead codes
Signed-off-by: Chanaka Dharmarathna <pe.chanaka.ck@gmail.com>
2014-10-04 11:40:39 +05:30
Marc Delisle
c326107d13 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-29 12:40:10 -04:00
Marc Delisle
7a83b16df9 Fix test
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-27 12:47:01 -04:00
Marc Delisle
b92a156739 Fix parameter type; remove unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-26 08:13:47 -04:00
Marc Delisle
9ab4ade266 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-15 11:34:32 -04:00
Marc Delisle
7b6c4e01e3 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-12 08:28:42 -04:00
Marc Delisle
9f65021d1e Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-09 09:21:27 -04:00
Hugues Peccatte
3cd1d69f8b Improve PMA_String* unit tests.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-08 21:49:55 +02:00
Marc Delisle
ac964a1470 rfe #1544 MySQL 5.7.5 compatibility
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-08 13:20:04 -04:00
Marc Delisle
b3bcdf55ee Remove unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-07 09:40:02 -04:00
Marc Delisle
2905b29f68 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-07 09:25:14 -04:00
Marc Delisle
fde42eb2e8 No need to have a distinct file
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-06 14:11:04 -04:00
Hugues Peccatte
ff0011ac3f Merge pull request #1353 from Tithugues/securityStringSquash
Mass modifications to use PMA_String.
2014-09-06 19:15:06 +02:00
Hugues Peccatte
623715c5f9 Add PMA_String::substrCount.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 17:53:30 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Chirayu Chiripal
a4e2472108 check null checkbox for datetime with default value null
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-09-06 13:47:06 +05:30
Marc Delisle
582b02262b Remove Overhead from Server > Databases > Enable Statistics. We cannot show
correct results in the case of InnoDB tables.

Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-04 05:43:02 -04:00
Marc Delisle
3464916f30 Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-03 13:41:23 -04:00
Madhura Jayaratne
e5f1c6d8bf Simplify schema exporting
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-08-24 07:36:10 +05:30
Ashutosh Dhundhara
60610f9b83 Fix issues reported by Scrutinizer.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-17 02:20:05 +05:30
Marc Delisle
5c7c5ba533 Remove old tests
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-16 09:20:15 -04:00
Marc Delisle
b7cec730f3 Improve message and make it translatable
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-16 07:06:51 -04:00
Marc Delisle
76150d6f65 Merge pull request #1331 from smita786/gsoc_automated_normalizaion
coding style fix
2014-08-14 11:43:38 -04:00
Madhura Jayaratne
34c27d23fb Merge pull request #1330 from kb-yashodha/designer
Designer refactoring
2014-08-14 19:46:17 +05:30
Smita Kumari
5d32c610f5 coding style fix
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-08-14 19:08:04 +05:30
Marc Delisle
9f27c06291 Fix failing test
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-14 08:37:04 -04:00
Bimal Yashodha
92c2bc3e8d Merge branch 'master' into designer
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-14 07:40:09 +05:30
Bimal Yashodha
285c18acdd Use db_desginer.php as a route for all designer operation. Combine pmd_general.lib.php and designer.lib.php into db_designer.lib.php
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-14 07:22:32 +05:30
Ashutosh Dhundhara
35dab58bf5 RFE#1492: Remove the distinct query window.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-12 01:47:20 +05:30
Bimal Yashodha
40821cf71f Fix failing tests
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-10 09:14:38 +05:30
Bimal Yashodha
b2f80eb97a Merge branch 'master' into designer
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-10 08:57:43 +05:30
Hugues Peccatte
8558047094 Coding style modifications.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-08-09 23:21:13 +02:00
Hugues Peccatte
30e0dc70cc Coding style modifications.
Remove unused variables.
PHPDoc update.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-08-09 23:11:36 +02:00
Bimal Yashodha
268a1a05e4 Fix failing tests
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-08-10 01:31:05 +05:30
Chirayu Chiripal
1be86d1062 fix parameter types
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-07 19:20:02 +05:30
Smita Kumari
b47220f893 unit tests for 3NF code
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-08-07 17:02:18 +05:30
Chirayu Chiripal
11ae13f177 Improve validation on insert page
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-04 02:19:25 +05:30
Chirayu Chiripal
c4398891ee added group medium to test
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-02 22:10:24 +05:30
Marc Delisle
eebe4d2c00 Fix test parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-08-02 10:47:01 -04:00
Ashutosh Dhundhara
508f0a752b RFE#919: Multiple-column foreign key relation.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix missing master column.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix failing test.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix function doc.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-01 19:50:12 +05:30
Marc Delisle
bf13970aec Unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-26 11:32:16 -04:00
Madhura Jayaratne
a34b6fea5a Merge pull request #1283 from kb-yashodha/indexdb
IndexDB for designer - Use the designer without configuring tables
2014-07-26 10:08:32 +05:30
Chirayu Chiripal
1d65c1d2f2 improve test cases of server_privileges.lib.php
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-26 02:06:00 +05:30
Bimal Yashodha
4a0e45de5b Fix undefined index
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-07-23 16:59:30 +05:30
Marc Delisle
d0a19abf5a Merge pull request #1286 from ashutoshdhundhara/rfe_908
RFE#908: Improvements for the table editor (index creation).
2014-07-22 07:28:37 -07:00
Ashutosh Dhundhara
91e9a4d46c RFE#908: Improvements for the table editor (index creation).
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Make index columns sortable.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix failing test.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix drag icon in Firefox.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-07-22 15:29:06 +05:30
Isaac Bennetch
3a215f86c8 Merge pull request #1289 from D-storm/FR-1488
RFE-1488/781: User privilege tab not shown in all relevant cases
2014-07-21 15:26:53 -04:00
Marc Delisle
feadcdae7e Merge pull request #1294 from smita786/gsoc_central_columns_list
Improve unit tests for central columns using MOCK DBI
2014-07-21 06:26:04 -07:00
Smita Kumari
4fc196cc85 Improve unit tests for central columns using MOCK DBI
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-07-20 20:13:24 +05:30