Commit Graph

23096 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
90db3a1359
Merge pull request #18621 from kamil-tekiela/fix-doctype-on-arrays
Fix array property declarations
2023-08-15 00:53:04 -03:00
Maurício Meneghini Fauth
609c59124c
Merge pull request #18620 from kamil-tekiela/Closure-return-type
Add return type to some closures
2023-08-15 00:52:00 -03:00
Maurício Meneghini Fauth
839c078405
Merge pull request #18619 from kamil-tekiela/setCookieParams
Remove unnecessary closure
2023-08-15 00:31:28 -03:00
Maurício Meneghini Fauth
021580e518
Merge pull request #18617 from kamil-tekiela/Request-in-favourites
Use Request in FavoriteTableController
2023-08-15 00:14:09 -03:00
Maurício Meneghini Fauth
8cc6db10d7
Merge pull request #18622 from kamil-tekiela/Remove-recasts
Remove redundant casts
2023-08-15 00:03:18 -03:00
Kamil Tekiela
95a98ccd04 Constructor property promotion - risky
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 23:24:49 +01:00
Kamil Tekiela
00367fb7b3 Remove redundant casts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 22:10:35 +01:00
Kamil Tekiela
8a47f88d3b Keep this return type as int|bool
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 20:47:30 +01:00
Kamil Tekiela
104b0c4be9 Fix array property declarations
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 20:44:02 +01:00
Kamil Tekiela
f5538ca41d Specify missing param types in closure
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 20:11:10 +01:00
Kamil Tekiela
9540ce2d21 Add return type to some closures
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 20:01:46 +01:00
Kamil Tekiela
a77379c67d Remove unnecessary closure
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-14 19:47:09 +01:00
Kamil Tekiela
77218a10c5 Use Request in FavoriteTableController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-12 20:23:34 +01:00
Maurício Meneghini Fauth
93fa48e286
Refactor the ServerRequest::getRoute() method
Extracts the redirection to database and table pages to the
HomeController for an actual redirection instead of an implicit one.

Removes the Application::getRequest() method as the ServerRequest object
should be an immutable object.

Adds a Routing::$route static variable to be used at the places that the
ServerRequest object is not available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-12 01:45:12 -03:00
Maurício Meneghini Fauth
a2b8c17c30
Pass a ServerRequest object to the 2FA plugin
Removes the Application::getRequest() call for the WebAuthn plugin.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-11 11:50:17 -03:00
William Desportes
945a2c2776
Merge #18610 - Remove optional params
Remove optional params
2023-08-10 09:20:16 +02:00
Maurício Meneghini Fauth
2ba2e80d39
Refactor ErrorHandler::dispFatalError() to use a Response object
Removes the dependency on ResponseRenderer for this method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-09 16:47:56 -03:00
Maurício Meneghini Fauth
bf94058602
Add a Template property to the ResponseRenderer class
Passes the Template object to its dependencies.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-09 15:14:23 -03:00
Maurício Meneghini Fauth
5f9ba2e1d1
Extract Relation and Template dependencies from UserPreferences
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-09 15:04:34 -03:00
Maurício Meneghini Fauth
f70c730edd
Extract Template dependency from Setup\MainController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-09 13:53:13 -03:00
Kamil Tekiela
b8d5af5586 Remove optional params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-09 01:10:55 +01:00
Maurício Meneghini Fauth
54a080c15d
Create the OutputBuffering middleware
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-08 16:14:34 -03:00
Maurício Meneghini Fauth
5dc23aec19
Create the ErrorHandling middleware
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-08 16:14:34 -03:00
Maurício Meneghini Fauth
daad3ab13a
Add support for PSR-15 middleware
Creates the Http/Handler/QueueRequestHandler class to handle the
middleware queue.
Extracts the PHP extensions checking into a middleware.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-08 16:14:34 -03:00
Maurício Meneghini Fauth
1f636fedbe
Create the Http\Handler\ApplicationHandler class
Uses the Laminas\HttpHandlerRunner\RequestHandlerRunner class to handle
the server request and the response emission.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-08 16:14:33 -03:00
Maurício Meneghini Fauth
c0d04b6895
Add a Response object to ResponseRenderer class
Uses a Response object to handle the HTTP headers and HTTP status code.

This makes the AbstractNetworkTestCase obsolete and removes it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-07 22:27:48 -03:00
Kamil Tekiela
7525271b2e Remove hasCommandsOutOfSyncError method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-06 22:30:56 +01:00
Maurício Meneghini Fauth
a520e235eb
Move Core::sendHeaderLocation() to ResponseRenderer::redirect()
Removes the IIS specific logic.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 17:43:42 -03:00
Maurício Meneghini Fauth
57fd47a170
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 14:08:54 -03:00
Maurício Meneghini Fauth
f570bf64bf
Pass ServerRequest object to Indexes::doSaveData() method
This removes the need to call Application::getRequest().

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 13:17:12 -03:00
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 01:42:06 -03:00
Maurício Meneghini Fauth
4dbe1b6e4b
Merge pull request #18562 from MoonE/scale-data
Refactor / rename in Gis
2023-08-05 20:18:57 -03:00
Kamil Tekiela
2b4916351e Introduce param $oldIndexName
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-05 20:33:20 +01:00
Kamil Tekiela
22c815e647 $request->hasBodyParam('preview_sql')
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-05 20:23:54 +01:00
Kamil Tekiela
e5701885b7 Flatten if statement
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-05 20:23:54 +01:00
Maurício Meneghini Fauth
bfc3852e61
Create Http\Response::write() method to write to the body
This method helps when data is written to the body of the response and
the response object is returned immediately.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-05 10:50:53 -03:00
Maurício Meneghini Fauth
d89bb277d0
Replace some 'echo' with ResponseRenderer::addHTML() method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 22:07:25 -03:00
Maurício Meneghini Fauth
41996de092
Merge pull request #18594 from kamil-tekiela/Fix-SA-reported-issues
Fix SA reported issues
2023-08-04 20:05:20 -03:00
Maurício Meneghini Fauth
e436ad23ec
Merge pull request #18598 from kamil-tekiela/charset_connection
Remove globals charset_connection & collation_connection
2023-08-04 20:00:10 -03:00
Maurício Meneghini Fauth
f3b57f6278
Change export to server file to use redirection after save
Removes the need of calling other controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 17:52:25 -03:00
Kamil Tekiela
47959814a4 Remove globals charset_connection & collation_connection
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-04 21:32:05 +01:00
Kamil Tekiela
a8a3986a80 Provide more accurate type hints
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-03 20:41:29 +01:00
Kamil Tekiela
3421e591dd in_array should use strict mode
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-03 20:41:28 +01:00
Kamil Tekiela
8774891531 $pattern must be non-empty-string
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-03 20:41:28 +01:00
William Desportes
1259c2638b
Fix #18578 - PDF export NULL values gives a type error
Fixes: #18578

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 18:08:29 +02:00
William Desportes
eae978f3f3
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 15:01:31 +02:00
William Desportes
7c975030b9
Fix #18592 - Remove instruction to remove the pma_collation_connection cookie removed in 4.8.0
Ref: 3b6a994dcd
Fixes: #18592

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 15:00:19 +02:00
Maurício Meneghini Fauth
45b58d7eea
Refactor JavaScriptMessagesController to return a Response object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-30 17:22:18 -03:00
Kamil Tekiela
e7ea833566 Move checkServerConfiguration before ini_set
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-30 00:10:00 +01:00
Kamil Tekiela
68569a97c5 Remove func_overload check
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-30 00:09:59 +01:00