Commit Graph

29 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
aa1cb197f5 Merge branch 'QA_4_7' 2017-10-20 11:25:28 +02:00
Michal Čihař
f2dcdfff50 Do not hardcode secure flag in examples
We can not assume that setup will be https by default, so having false
as default is safer.

Fixes #13758

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 11:24:00 +02:00
Maurício Meneghini Fauth
9028055d8b Fix some coding standard errors in DocBlocks
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-04-10 18:36:02 -03:00
Michal Čihař
aebbb31aad Merge branch 'master' into master-security 2016-07-29 14:08:23 +02:00
Michal Čihař
c328697e39 Do not use mb_strlen result for string indexes
The string indexes are in bytes, while mb_strlen counts chars.

Issue #12397

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-29 13:54:04 +02:00
Michal Čihař
8095b837fa Hide session error messages to avoid FPD
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 12:38:32 +02:00
Isaac Bennetch
c4a595357f Add Secure and HttpOnly flags for session cookie setup in examples
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2016-07-10 22:35:38 -04:00
Michal Čihař
418aeea3d8 Add error handling to constructing openid message
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 14:34:50 +02:00
Michal Čihař
94cf386425 Escape error messages from OpenID
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 14:30:36 +02:00
Michal Čihař
27664605b9 Improve error handling in OpenID example
- properly check parameter types
- catch all exceptions (eg. network error)

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 14:26:59 +02:00
Michal Čihař
3771852471 Use https when linking to php.net
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:10:13 +02:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Marc Delisle
66c15daba0 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-06 08:01:07 -05:00
Marc Delisle
357b1b4757 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-04 09:05:42 -05:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Michal Čihař
064e45c878 Correct params to session_set_cookie_params
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:48:09 +02:00
Marc Delisle
8c3e33d043 Fix coding style 2013-10-19 06:01:50 -07:00
Michal Čihař
534bbc7e48 Various coding style improvements in examples 2013-05-02 10:47:41 +02:00
Michal Čihař
3e050ff9d9 Various docblocks improvements 2012-09-19 15:05:26 +02:00
Michal Čihař
5370d0d6c3 Fix spacing of @package used together with @subpackage 2012-05-02 11:29:34 +02:00
Marc Delisle
5fedf1aa3f Merge branch 'QA_3_5' 2012-04-03 12:57:31 -04:00
Marc Delisle
8c3a77f3ad Path disclosure fix 2012-04-03 12:56:58 -04:00
Jo Michael
653f086815 Replaced xml:lang attributes by lang for HTML5 2012-03-18 14:46:59 +01:00
Jo Michael
af0e6c71e7 Use HTML5 DOCTYPE along with new charset meta-tag 2012-03-16 22:54:32 +01:00
Michal Čihař
850b202e82 Move signon and openid examples to examples folder 2012-02-13 13:29:31 +01:00