Commit Graph

593 Commits

Author SHA1 Message Date
Faissal Wahabali
ad3072cd97
Merge pull request #19568 from faissaloux/fix/table-structure-columns-order
Fix columns order in Table Structure



Fixes #19558
2025-03-17 10:25:24 -03:00
Kamil Tekiela
1bae655268 Fix mysql default value insert
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-03-14 18:13:19 +00:00
Kamil Tekiela
e9ab86b73a Update MoveColumnsControllerTest.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-03-08 20:11:49 +00:00
Liviu-Mihail Concioiu
c3e4ef035e
Fix #19537 - Make sure rowCount is always int (#19538)
* Cast rowCount to int

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Refactor getRealRowCountTable

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix tests

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Update baselines

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Fixes #19537

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-02-24 10:44:30 -03:00
Maurício Meneghini Fauth
063555083e
Merge PR #19361 Column sorting does not work when names contain dots
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-02-21 20:17:14 -03:00
Maurício Meneghini Fauth
65cd15d10d
Merge pull request #19569 from kamil-tekiela/Replace-trigger_error-in-mysqli
Add an error instead of triggering warning
2025-02-19 20:28:57 -03:00
Kamil Tekiela
92052454bd Refactor TwigLintCommand::display
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-02-06 00:36:49 +00:00
Maurício Meneghini Fauth
a7af11966b
Merge pull request #19552 from kamil-tekiela/Fix-default-values
Fix default values
2025-01-30 20:30:38 -03:00
Maurício Meneghini Fauth
b0d985c349
Merge pull request #19584 from MauricioFauth/phpunit-12-deprecations
Fix PHPUnit 12 deprecations
2025-01-30 15:52:23 -03:00
Maurício Meneghini Fauth
07db8a5d53
Merge pull request #19551 from kamil-tekiela/Small-refactoring
Small refactoring
2025-01-30 15:49:44 -03:00
Maurício Meneghini Fauth
72a07c3c1f
Fix PHPUnit 12 deprecations
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-30 15:07:48 -03:00
Kamil Tekiela
73ff5a4323 Replace E_USER_ERROR with exception
Both will stop processing the current code.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 19:57:20 +00:00
Kamil Tekiela
48ca6a188e Use new mysqli instead of mysqli_init
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 18:03:14 +00:00
Kamil Tekiela
d5e9a911e8 Update getDefaultValue tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:58 +00:00
Kamil Tekiela
3c3477054a These are not nullable fields but strings
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:58 +00:00
Kamil Tekiela
8f11a85e4b Fix decorateColumnMetaDefault()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:58 +00:00
Kamil Tekiela
2484cba839 Create unquoteDefaultValue()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-29 14:46:53 +00:00
Maurício Meneghini Fauth
a2b07b92ee
Upgrade PHPUnit to version 11.5
- Upgrading amphp/amp (v3.0.2 => v3.1.0)
  - Upgrading phpmyadmin/sql-parser (dev-master ab0d173 => dev-master 00c8e55)
  - Upgrading phpstan/phpstan-phpunit (2.0.3 => 2.0.4)
  - Upgrading phpunit/php-code-coverage (10.1.16 => 11.0.8)
  - Upgrading phpunit/php-file-iterator (4.1.0 => 5.1.0)
  - Upgrading phpunit/php-invoker (4.0.0 => 5.0.1)
  - Upgrading phpunit/php-text-template (3.0.1 => 4.0.1)
  - Upgrading phpunit/php-timer (6.0.0 => 7.0.1)
  - Upgrading phpunit/phpunit (10.5.41 => 11.5.4)
  - Upgrading roave/security-advisories (dev-latest e7a38fc => dev-latest 3f5a01e)
  - Upgrading sebastian/cli-parser (2.0.1 => 3.0.2)
  - Upgrading sebastian/code-unit (2.0.0 => 3.0.2)
  - Upgrading sebastian/code-unit-reverse-lookup (3.0.0 => 4.0.1)
  - Upgrading sebastian/comparator (5.0.3 => 6.3.0)
  - Upgrading sebastian/complexity (3.2.0 => 4.0.1)
  - Upgrading sebastian/diff (5.1.1 => 6.0.2)
  - Upgrading sebastian/environment (6.1.0 => 7.2.0)
  - Upgrading sebastian/exporter (5.1.2 => 6.3.0)
  - Upgrading sebastian/global-state (6.0.2 => 7.0.2)
  - Upgrading sebastian/lines-of-code (2.0.2 => 3.0.1)
  - Upgrading sebastian/object-enumerator (5.0.0 => 6.0.1)
  - Upgrading sebastian/object-reflector (3.0.0 => 4.0.1)
  - Upgrading sebastian/recursion-context (5.0.0 => 6.0.2)
  - Upgrading sebastian/type (4.0.0 => 5.1.0)
  - Upgrading sebastian/version (4.0.1 => 5.0.2)
  - Upgrading squizlabs/php_codesniffer (3.11.2 => 3.11.3)
  - Locking staabm/side-effects-detector (1.0.5)
  - Upgrading tecnickcom/tcpdf (6.8.0 => 6.8.2)

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-28 18:43:58 -03:00
Kamil Tekiela
bc477b68ad Refactor AuthenticationConfig
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-28 21:41:29 +00:00
Maurício Meneghini Fauth
8a6f2ea4ca
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-27 17:08:29 -03:00
Maurício Meneghini Fauth
b0b72fca6e
Replace PHPUnit annotation with attribute in GitTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-27 12:30:16 -03:00
Kamil Tekiela
79fa401ade Remove null from union in connect
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:09 +00:00
Kamil Tekiela
01142a9edc Make it clear what type &$flag is
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:09 +00:00
Kamil Tekiela
e5db99a32e Refactor ENGINE_MAP
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:09 +00:00
Kamil Tekiela
60ddd910f7 Use constants instead of static props
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:08 +00:00
Kamil Tekiela
b5029a36d1 Convert IconvExtraParams to $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-25 21:10:08 +00:00
Maurício Meneghini Fauth
6b6f4237ce
Merge pull request #19535 from kamil-tekiela/getPartialText
Split up getPartialText()
2025-01-24 15:10:53 -03:00
Maurício Meneghini Fauth
a2a7c9c859
Merge pull request #19495 from kamil-tekiela/Config-refactoring
Config refactoring
2025-01-24 14:44:58 -03:00
Maurício Meneghini Fauth
ce440bfc3b
Merge pull request #19521 from kamil-tekiela/Fix-favoriteTables
Create a new controller for synchronizing favourites
2025-01-24 14:39:45 -03:00
Kamil Tekiela
3bf0ea04c4 Fix one of the issues with wrong value
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:54 +00:00
Kamil Tekiela
b462cc7090 Remove Config::get() method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:54 +00:00
Kamil Tekiela
d70ab76665 Convert Lang to use $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:53 +00:00
Kamil Tekiela
ac20c0fb1e Convert DisableShortcutKeys to $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:53 +00:00
Kamil Tekiela
0d8ed00cc2 Convert SendErrorReports to use $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:53 +00:00
Kamil Tekiela
9798216e6f Convert environment to use $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:13:52 +00:00
Kamil Tekiela
a25527ef8d Refactor loadAndCheck()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
1c5249ab59 Remove OBGzip
Functionality was removed in 54a080c15d

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
410b84ce33 Change PMA_IS_GD2 isGd2Available() method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
6f9cd76f01 Change enable_upload to isUploadEnabled()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
1af9a6ca13 Create Util::getUploadSizeInBytes()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
2fd793f53a Create UserAgentParser class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:24 +00:00
Kamil Tekiela
f45080b091 Change PMA_IS_WINDOWS to isWindows() method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
5ae628088e Convert PmaAbsoluteUri to $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
017cdd92cd Untangle $isHttps
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
ca4490323d Convert OBGzip to $config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
e045e7f910 Improve type hints
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
b008be5570 Add one more condition to configPaths
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
1aa8f7b182 Remove unhelpful testCheckPermissions
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
afb806b181 Untangle $source
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
Kamil Tekiela
9a6fef7e65 Remove $this->sourceMtime = 0;
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00