Commit Graph

799 Commits

Author SHA1 Message Date
William Desportes
9178602e6c
Fix #14614 - "# 2014 - Commands out of sync; you can't run this command now" returned when stored procedure does not return any result set
Fixes: #14614
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-29 23:08:23 +02:00
William Desportes
ca3f027f7e
Fix #13178 - Issues with uppercase table and database names
Fixes: #13178
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 21:32:31 +02:00
William Desportes
5a08e12bb6
Fix #15205 - Useless backquotes, sql preview, delete index
Fixes: #15205
Pull-request: #15207
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 20:10:51 +02:00
Saurabh Srivastava
e03a7ed02f Fix not working for primary key
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-28 17:51:05 +05:30
William Desportes
60564b5d92
Fix #14800 #14833 - Sort by Time and show full query on Processlist
Fixes: #14800
Fixes: #14833
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 00:26:29 +02:00
William Desportes
91c758aae4
Fix #15229 - Notice - Undefined index: strPrivDescDelete versioning rowsTbl
Fixes: #15229
Adds support for delete versioning rows privilege
See: https://mariadb.com/kb/en/library/grant/#table-privileges
The privilege is named 'Delete versioning rows' in SHOW GRANTS and 'Delete_history_priv' in mysql.user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 18:42:02 +02:00
William Desportes
5566aa6976
Fix #15228 - Notice - Undefined index: foreign_keys_data
Fixes: #15228
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-26 23:45:20 +02:00
Jan Demter
3882454ed9 fix typo in language name
Signed-off-by: Jan Demter <jan@demter.de>
2019-04-17 19:33:17 -03:00
Saurabh Srivastava
5d6f761e08 Fix - #15205 - Useless backquotes, sql preview, delete index
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-16 13:58:41 +05:30
William Desportes
9c6e2b812d
Fix #15119 - Uninterpreted HTML on Settings->Export page
Fixes: #15119
Pull-request: #15132
Closes: #15134
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-05 10:06:34 +02:00
William Desportes
2e0821ea5c
Fix import XML data with leading zeros
Pull-request: #14944
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-04 21:46:17 +02:00
William Desportes
f911595f02
Fixed php notice undefined index pma on ImportXml
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-04 21:40:21 +02:00
William Desportes
1024e420e1
Fixed php warning count(): Parameter ... on export table to XML
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-04 21:40:21 +02:00
William Desportes
ab748e2fac
Fix some potential php notices after merge of #15040
[ci skip]
See: 3d3d1a2b08
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 23:27:15 +02:00
William Desportes
babce812fe
Fix #14673 - innodb & MySQL 8: DYNAMIC & COMPRESSED ROW_FORMAT missing
Fixes: #14673
Pull-request: #14979
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 22:21:40 +02:00
Nugroho Latifolia
ad6fe25878
Fix #14673 - innodb & MySQL 8: DYNAMIC & COMPRESSED ROW_FORMAT missing
Fixes: #14673

Newer MySQL/MariaDB always return empty a.k.a '' on $innodb_file_format otherwise
        old versions of MySQL/MariaDB must be returning something or not empty.
        This patch is to support newer MySQL/MariaDB while also for backward compatibilities.

Signed-off-by: Nugroho Latifolia <nugroho.latifolia@gmail.com>
2019-04-01 22:17:07 +02:00
William Desportes
3d3d1a2b08
Fix #15010 - Sql preview empty modal on tbl_relation
Fixes: #15010
Pull-request: #15040
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 21:24:42 +02:00
William Desportes
a80785198d
Fix #15141 - php notice Undefined index: designer_settings
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:12:24 +02:00
Saurabh Srivastava
d792bc68a2 Fix #15119 - Uninterpreted HTML on Settings->Export page
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-03-30 18:58:39 +05:30
William Desportes
987e286c23
Fix multi server setup send error report
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 11:09:20 +01:00
William Desportes
dd17ae11d1
Fix #15110 - TypeError e.preventDefaulut is not a function
Fixes: #15110
Introduced by 487e1a8fa1

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-27 08:30:35 +01:00
apoorv
bca847f227 Fix #15010 - Sql preview show empty modal
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
2019-03-26 23:48:58 +01:00
William Desportes
c1c22ff32f
Fix style issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 22:48:08 +01:00
Saurabh Srivastava
47fe92099b Fix #14853 - Insert page should not allow entering things into virtual columns
Fixes: #14853
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-03-26 20:55:09 +01:00
William Desportes
ec2e28fa04
Fix #15077, #15100 - Incorrect page numbers
Fixes: #15077
Fixes: #15100
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 19:37:47 +01:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 22:31:29 +01:00
Anton Mokrousov
e41af9d6df Fixed issue #15077
Signed-off-by: Anton Mokrousov <settingx@mail.ru>
2019-03-24 21:36:25 +07:00
William Desportes
2da5d8f390
Fix #14931 - count(): Parameter must be an array or an object that implements Countable, ./libraries/classes/Sql.php#1623
Fixes: #14931
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-23 08:53:12 +01:00
Maurício Meneghini Fauth
33f510bfb4 Fix bug when creating or editing views
Fixes #14916

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-20 19:14:02 -03:00
Isaac Bennetch
5445d51a64 Improve grammar for a message from the validator.
Thanks mostly to Si Jie sijie123@gmail.com for raising pull request

This modifies the po files as well to prevent the string from being
marked as fuzzy.

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-03-20 11:20:08 -04:00
William Desportes
3e41eca650
Fix #14811 - SHOW FULL TABLES FROM when a table is locked
Fixes: #14811
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-19 22:34:22 +01:00
Maurício Meneghini Fauth
75eb905727 Fix wrong property name on TableStructureController
Introduced by 963ace6ada

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 14:31:10 -03:00
Mohammad Reza Mansouri
23753e071e Fix missed padding on query results (#14730)
Solves missed paddings on query results.

Fixes #14053 

Signed-off-by: Mohammad Reza Mansouri <beekalam@gmail.com>
2019-03-16 15:07:36 +01:00
William Desportes
3a716c528e
Fix #14311 - Undefined index in setup script
Fixes: #14311
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-13 19:31:38 +01:00
William Desportes
638700692b
Fix #14734 - Invalid default value for bit field
Fixes: #14734
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-06 23:56:26 +01:00
Michael Tsang
b36ae1bc1d fix Bookmark::get() id matching SQL
fix a mistake in SQL which causes default bookmark not working

Signed-off-by: Michael Tsang <miklcct@gmail.com>
2019-03-06 19:38:31 -03:00
Hritik Wadhwa
937a120c1d Fix #14948 - Change password is not showing password Strength difference
Cherry-picked-from: 78eed87315
Fixed: #14948
Signed-off-by: Hritik Wadhwa <akkywadhwa@gmail.com>
2019-03-06 16:19:10 +01:00
Dhyey Thakore
7d66500669 Fix #14607 - Count rows only if needed (#14821)
Signed-off-by: Dhyey Thakore <dhyey35@gmail.com>
(cherry picked from commit feca784567)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 16:13:38 -03:00
William Desportes
ccbc25dca9
Fix: #14870 - Now Zip files display correct date and time
Fixes #14870

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 20:16:51 +01:00
William Desportes
60f3f97ede
Fix: #13975 - Missing query time in German (fix decimal number format )
Fixes: #13975
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 11:31:11 +01:00
William Desportes
e339fe3ec7 Fix: #14922 - Json encode error
Fixes: #14922
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-01 23:59:43 +01:00
William Desportes
6054f9eb4d
Fix: #14896 - Expanded DB, refresh, plus/minus icon
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-01 23:51:48 +01:00
Kartik Kathuria
f26ff98c92 Replaced with Appropriate Comment
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-03-01 15:07:28 +05:30
Kartik Kathuria
b1f4a5ecb9 FixError#14870 Now Zip files display correct date and time
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-02-18 23:02:52 +05:30
Vincent Milum Jr
31b40f71bb Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 (#14536)
Fixes #14514
Fixes #14515
Possible fix for #14516

 #14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

 #14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

 #14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit 3f6e360a4e)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-15 17:27:55 -02:00
Joan Vega
1ea4548cd0 fix detectType: now considers cells with values like 0000123 (leading zeros) as varchar types
Signed-off-by: Joan Vega <joan@inte.es>
2019-02-08 21:45:13 +01:00
Michal Čihař
ba502e381a Add definition for Norwegian Nynorsk
Signed-off-by: Michal Čihař <michal@cihar.com>
2019-02-05 16:48:49 +01:00
Si Jie
03f5a889d6 ExportJson: add checks to prevent crash when encode returns boolean instead of string
Signed-off-by: Si Jie <sijie123@gmail.com>
2019-02-05 12:10:22 +07:00
Maurício Meneghini Fauth
858357ea3b
Merge pull request #14825 from williamdes/issue-14478-export-stream
Fix #14478 - phpMyAdmin no longer streams the export data
2019-01-28 13:46:40 -03:00
Isaac Bennetch
6d5af1b97d Prepare for 4.8.6-dev
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-01-25 22:43:24 -05:00