Commit Graph

4193 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
29c7705e80
Merge pull request #18197 from kamil-tekiela/Fix-warning-on-non-existent-table
Fix warning on non-existent table
2023-03-08 10:10:28 -03:00
Maurício Meneghini Fauth
12b924d4e3
Fix wrong time zone when handling Git information
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-04 11:55:29 -03:00
Kamil Tekiela
80d7f0dfa3 Fix warning on non-existent table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-02 16:23:07 +00:00
William Desportes
f3aa3639b3
Remove chdir from GitTest after fixing #18112
Ref: d9a6f82bc1

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-26 23:57:54 +01:00
William Desportes
d9a6f82bc1
Fix #18112 - open base dir warning on git version class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-26 23:31:28 +01:00
Kamil Tekiela
aa63c6821a Fix bug related to tables with numerical names
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-22 13:18:06 +00:00
William Desportes
496bd0f3d0
Remove non used code of explain button (Generator::generateRowQueryOutput)
Since: f1581cfe9b

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-22 12:51:26 +01:00
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-22 12:47:59 +01:00
William Desportes
7d4eafd188
Fix #16851 - Default column order doesn't have have any effect ($cfg['Order']) since phpMyAdmin 4.2.0
Introduced by a05ab9640b

See: a05ab9640b (diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dL2022-L2040)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:52:38 +01:00
William Desportes
f3bd71d937
Fix a coding-standard issue
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:52:37 +01:00
William Desportes
4ce69f3a3d
Nicely exit in case of an early PHP type crash
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:51:21 +01:00
Maurício Meneghini Fauth
6eb4b4d5ad
Merge pull request #18120 from kamil-tekiela/bug-with-numerical-table-names-during-rename
Fix bug with numerical tables during renaming DB
2023-02-20 13:43:51 -03:00
Kamil Tekiela
fa339143ea
Fix renaming db with a view (#18106)
* Fix renaming DB with a view

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add test for the bug

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-20 13:36:46 -03:00
Kamil Tekiela
69f7a915eb Replace getTablesFull with getTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-18 14:33:41 +00:00
Liviu-Mihail Concioiu
a6e0957d94 Update links
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-02-17 18:42:01 +01:00
Maurício Meneghini Fauth
b4f15ab6a0
Fix missing default_action parameter when copying rows
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17923

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-15 16:37:05 -03:00
Maurício Meneghini Fauth
ae560e0ffb
Prepare for version 5.2.2-dev
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-08 11:28:34 -03:00
William Desportes
9d92dafdcb
Merge #17923 - Fix #17766 - Allow to open in a new tab copy and edit row actions
Pull-request: #17923
Fixes: #17766

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-08 13:13:39 +01:00
William Desportes
2443570ce6
Merge #17851 - Fix #17028, #17683 - Re build query count management
Pull-request: #17851
Fixes: #17028
Fixes: #17683

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-08 13:12:00 +01:00
Isaac Bennetch
372185c302 Prepare for version 5.2.1
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2023-02-07 16:20:27 -05:00
Liviu-Mihail Concioiu
f45cd23222 Remove double quotes
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-01-31 22:57:56 +01:00
William Desportes
6d482de7b8
Add back UUID and UUID_SHORT to functions on MySQL and all MariaDB versions
Ref: https://github.com/phpmyadmin/phpmyadmin/pull/17767

It was a mistake to remove the UUID functions, they are not the UUID type

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-20 20:18:55 +04:00
William Desportes
305fe52d9e
Fix #18019 - Error: "Call to a member function fetchAssoc() on bool" with SQL mode ONLY_FULL_GROUP_BY
Fixes: #18019

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-20 19:36:52 +04:00
William Desportes
89adbcfe9b
Fix PSR-7 implementation for GET and test implementation for POST
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-20 13:17:12 +04:00
Daniel Kesselberg
79eacd6040
fix: remove analyze explain button
The service mariadb.org/explain_analyzer is unavailable.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-01-17 17:14:38 +04:00
Maurício Meneghini Fauth
f143d2a709
Add support for Web Authentication API
Adds a two factor authentication plugin that supports FIDO2/WebAuthn
security keys.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-16 18:20:05 -03:00
Liviu-Mihail Concioiu
38deec06cd Fix uuid column move
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-01-07 18:05:14 +01:00
Maurício Meneghini Fauth
dfd5f13078
Fix some errors detected by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-05 16:27:20 -03:00
William Desportes
9eec5d8be8
Add a reservation of 1 second to allow interrupt shutdown code to render
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-01 09:54:52 +04:00
William Desportes
19c4657f39
#17999 - Remove modals from the login page
It shows weird buttons

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-30 15:52:16 +04:00
Maurício Meneghini Fauth
f6a03d405d
Improve type inference of TwoFactor::$config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-28 15:50:43 -03:00
Maurício Meneghini Fauth
4e49c7760a
Add support for more PSR-7 packages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-19 01:40:05 -03:00
Maurício Meneghini Fauth
63102c1253
Add unit test for Plugins\TwoFactor\Key::getRegistrations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-15 22:54:33 -03:00
Kamil Tekiela
3ff0dd38d4
Remove invalid usages of htmlspecialchars()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
(cherry picked from commit 59ba203280)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-15 14:00:41 -03:00
William Desportes
9c4a90137d
Fix #16988 - export as CSV/JSON/SQL/... no database selected
Fixes: #16988

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-13 23:27:07 +01:00
William Desportes
d258e4ed14
Fix mistake in pull-request #15121 to fix #15064 - do not display the SQL, execute it !
Ref: #15121

all other plugins execute it

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-13 22:32:19 +01:00
William Desportes
12fe46b2df
Fix a typo in export files
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-13 22:31:18 +01:00
Maximilian Krög
a90cff2f7f
Fix centering of gis plot
When the ratio in one or both dimensions is zero (all points at the same
width or height) place it in the center.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2022-12-10 22:26:42 +01:00
Maximilian Krög
ed9c607f01
Fix centering of gis data in plot
The image was not centered because the border (either x or y) was
not included in the calculation

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2022-12-10 21:18:40 +01:00
William Desportes
ddd512cd8b
Fix #15887 - Drop table errors ignored
Fixes: #15887

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-26 00:22:54 +01:00
Scott Mcgowan
6fc1401ee2
Fix column names option for CSV Export
Previously work was done to enable column names in CSV exports by
default. This change actually ended up overwriting the column name value
so that column names were included in all exports regardless of whether
or not the property was disabled. This commit changes the default for
column names to enabled as the original change intended, and removes
the property overwrite.

Signed-off-by: Scott McGowan mcgowanscott16@gmail.com
2022-11-25 21:15:49 +01:00
William Desportes
b9c593c67d
Fix #17766 - Allow to open in a new tab copy and edit row actions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-25 19:55:53 +01:00
Maurício Meneghini Fauth
ba81cdabce
Catch exceptions/errors in the config file
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17911

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 15:57:03 -03:00
William Desportes
883226c1f7
Ref #17478 - Fix mistake in PHP operators
Ref: 630f9bf00e
Thank you @MoonE !

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-21 16:37:44 +01:00
William Desportes
630f9bf00e
Ref #17478 - Fix PHP Undefined array key "auth_type" when server does not start at 0
```
Internal error in ./libraries/classes/Controllers/HomeController.php#235
 ErrorException: Undefined array key "auth_type"
```

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 23:02:50 +01:00
William Desportes
182cb205a7
Fix coding standard mistakes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 21:55:52 +01:00
William Desportes
e28bc2d8f6
Fix #17446 - Missing option for STORED virtual column and lower the check to MySQL>=5.7.6. Nothing is supported on 5.7.5.
Fixes: #17446

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:08:35 +01:00
William Desportes
45853b69b7
Fix #17902 - truncate "title" attribute of foreign keys
BrowseForeigners::getDescriptionAndTitle() uses the same method

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 14:18:53 +01:00
iifawzi
5207fcdb68 phpcbf fixing trailing whitespaces
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 17:07:46 +02:00
iifawzi
b7bf83c24c Default to "Full texts" when running ANALYZE
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 17:00:10 +02:00