gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,137 Commits 12 Branches 481 Tags 2.4 GiB
9188cf251b
Commit Graph

1085 Commits

Author SHA1 Message Date
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314 
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:47:59 +01:00
Kamil Tekiela
69f7a915eb Replace getTablesFull with getTables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-18 14:33:41 +00:00
William Desportes
9d92dafdcb
Merge #17923 - Fix #17766 - Allow to open in a new tab copy and edit row actions 
Pull-request: #17923
Fixes: #17766

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:13:39 +01:00
William Desportes
305fe52d9e
Fix #18019 - Error: "Call to a member function fetchAssoc() on bool" with SQL mode ONLY_FULL_GROUP_BY 
Fixes: #18019

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-20 19:36:52 +04:00
Maurício Meneghini Fauth
f143d2a709
Add support for Web Authentication API 
Adds a two factor authentication plugin that supports FIDO2/WebAuthn
security keys.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-16 18:20:05 -03:00
Liviu-Mihail Concioiu
38deec06cd Fix uuid column move 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-01-07 18:05:14 +01:00
Maurício Meneghini Fauth
dfd5f13078
Fix some errors detected by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-05 16:27:20 -03:00
William Desportes
9eec5d8be8
Add a reservation of 1 second to allow interrupt shutdown code to render 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-01 09:54:52 +04:00
William Desportes
9c4a90137d
Fix #16988 - export as CSV/JSON/SQL/... no database selected 
Fixes: #16988

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-12-13 23:27:07 +01:00
William Desportes
ddd512cd8b
Fix #15887 - Drop table errors ignored 
Fixes: #15887

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-26 00:22:54 +01:00
William Desportes
b9c593c67d
Fix #17766 - Allow to open in a new tab copy and edit row actions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 19:55:53 +01:00
William Desportes
883226c1f7
Ref #17478 - Fix mistake in PHP operators 
Ref: 630f9bf00e
Thank you @MoonE !

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-21 16:37:44 +01:00
William Desportes
630f9bf00e
Ref #17478 - Fix PHP Undefined array key "auth_type" when server does not start at 0 
```
Internal error in ./libraries/classes/Controllers/HomeController.php#235
 ErrorException: Undefined array key "auth_type"
```

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 23:02:50 +01:00
Kamil Tekiela
b4e22b83d7
Fix import/export escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-03 21:16:42 +01:00
Liviu-Mihail Concioiu
858c4bff7b Correct text 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-10-22 02:29:38 +02:00
William Desportes
df4e8d2221
Fix broken createProfilingChart on monitor analyse query 
JQPlotChartFactory was undefined

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-19 17:41:29 +02:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:41:31 -03:00
Maurício Meneghini Fauth
72a6045f06 Fix some errors reported by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-11 18:19:07 -03:00
Maurício Meneghini Fauth
5d9142674d
Allow longer cookie encryption keys to be used 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:34:18 -03:00
Maurício Meneghini Fauth
0ed04a6c00
Remove trigger_error calls from HomeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit c5611531c0)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:33:38 -03:00
William Desportes
6230c197dd
Fix PHP warning on GIS visualization when there is only one GIS column 
```
Warning in ./libraries/classes/Controllers/Table/GisVisualizationController.php#174
 Undefined array key "labelColumn"

Backtrace

Routing.php#191: PhpMyAdmin\Controllers\Table\GisVisualizationController->__invoke(
,
array,
)
./../../../../index.php#43: PhpMyAdmin\Routing::callControllerForRoute(
,
string '/table/gis-visualization',
,
,
)
```
Structure:
- A table with only one GIS column

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-09-10 14:05:34 +02:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found 
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-19 15:28:43 -03:00
William Desportes
6a69face6c
Fix PHP 8.2: ${var} deprecated string interpolation syntax 
Ref: https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated

Left over to patch:
- libraries/classes/Git.php#L397
- libraries/classes/Database/Qbe.php#L878
- libraries/classes/Database/Qbe.php#L879

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-07-13 11:14:20 +02:00
Maurício Meneghini Fauth
bf2add8312
Fix preview SQL modal not working inside Index modal 
- Fixes #17606

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-15 20:09:13 -03:00
Maurício Meneghini Fauth
bf084233ea
Add ChangeLog entry for #17586 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-11 14:04:58 -03:00
Maurício Meneghini Fauth
bc61c2f8c3
Merge pull request #17587 from liviuconcioiu/statistics 
Fix #17586 Statistics not showing for empty databases

Fixes #17586
 2022-06-11 11:35:19 -03:00
Maurício Meneghini Fauth
fd5300e9e0
Merge pull request #17583 from kamil-tekiela/password_hash_5_2 
5.2 backport of #17582

Fixes #17121
Closes #17120
 2022-06-11 10:53:46 -03:00
Maurício Meneghini Fauth
fcea0f39e8
Merge pull request #17517 from aidvu/patch-2 
Revert to old behavior for `ShowServerInfo`
 2022-06-06 16:30:36 -03:00
Liviu-Mihail Concioiu
479f8472b3 Fix statistics 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-06-06 21:12:47 +02:00
Kamil Tekiela
6d0a30a391 Fix errors in InsertEdit 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-06-04 19:06:16 +01:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
9e4f3833a5
Fix Table\OperationsController failing test 
The Partition::getPartitionNames method returns [0=>null] when no
partitions were found.

Related to 346d6c7981.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-21 16:35:36 -03:00
Maurício Meneghini Fauth
346d6c7981 Fix error in table operation page when partitions are broken 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17496

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-20 20:52:55 -03:00
Andrija Vučinić
c6bb867787 Revert to old behavior for ShowServerInfo 
Seems we changed the flag behavior here: cd1b8a9b77 (diff-bb8d8aecc2e174245e8b95be9344176aba8971d024f3b2c2311b8e58ddd59b31L149)

I'm not sure whether that was intentional, but it causes the `Database server` panel to always show compared to pre 5.2.0.

Truth be told, it doesn't make sense to have that flag and then the additional checks in the block when we know it's `true`, so I updated the code to take care of that.

Signed-off-by: Andrija Vučinić <andrija.vucinic@gmail.com>
 2022-05-11 22:57:55 +02:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency 
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
04f3f5a4b6
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-26 21:03:20 -03:00
Maurício Meneghini Fauth
5d80594341 Remove jQuery SVG JS dependency 
Removed by https://github.com/phpmyadmin/phpmyadmin/pull/17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-24 20:39:12 -03:00
Maurício Meneghini Fauth
b17700dd09 Remove PMA_IS_WINDOWS constant 
Gets the value from the Config class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-24 20:37:55 -03:00
Maurício Meneghini Fauth
e4f0a0d1e6
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-21 15:54:13 -03:00
Maurício Meneghini Fauth
3c3a423727
Fix translation string in Database\DesignerController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-21 15:38:28 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
69a8c97e67
Merge pull request #17406 from mauriciofauth/add-index-bug 
Fix create index form accepting too many columns
 2022-02-21 11:42:04 -03:00
Maurício Meneghini Fauth
366c586330
Add better error handling when IndexedDB is not working 
- Fixes #16853

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 19:20:34 -03:00
Maurício Meneghini Fauth
1cac3baeab
Fix create index form accepting too many columns 
- Fixes #16769

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 13:11:30 -03:00
Isaac Bennetch
985912f58f Fix merge conflicts from security branch 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages 
Note: 'action_done' was not used since
c962ee4287.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 15:05:43 -03:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Maurício Meneghini Fauth
290f026a02
Merge pull request #17272 from kamil-tekiela/queryAsControlUser 
Query as control user
 2022-01-06 21:32:46 -03:00