gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
118,671 Commits 12 Branches 481 Tags 2.4 GiB
91bf091350
Commit Graph

84 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 02:12:36 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:45:50 +02:00
William Desportes
bb0bc3bb93
Merge #16131 - Unit test suite improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 23:32:11 +02:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-21 15:29:36 -03:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig(); 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 13:19:23 +02:00
William Desportes
5195520883
Coding standard fixes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:18:05 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:15:06 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action 
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 11:21:42 -03:00
William Desportes
947f9ad04f
Remove some unused code detected by codacy 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:57:22 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
afd69b1ab3 Extract HTML from Index::generateIndexChoiceSelector 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-28 19:16:05 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller 
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 15:02:28 -03:00
Maurício Meneghini Fauth
e36f5a1938 Refactor Table\SearchController 
Moves the table select entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-28 22:18:29 -03:00
Maurício Meneghini Fauth
98424ec065 Extract class from Table\SearchController 
Extracts the buildSqlQuery method from
Controllers\Table\SearchController class to the new Table\Search class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-27 22:01:28 -03:00
Maurício Meneghini Fauth
ee8951ea74 Create Table\FindReplaceController controller 
Moves the table find-replace entry point logic to the
FindReplaceController, removes the entry point file and extracts the
find-replace logic from the Table\SearchController class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-27 17:54:19 -03:00
Maurício Meneghini Fauth
ab9d94b2b3 Refactor Table\IndexesController controller 
Moves the indexes entry point logic to the controller and removes the
entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-26 12:28:30 -03:00
Maurício Meneghini Fauth
af1c859a03 Refactor Table\RelationController controller 
Moves the table relation entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-25 01:28:38 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534) 
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
 2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
600079f0f0 Create Table\PrivilegesController 
Extract Server\Privileges::getHtmlForSpecificTablePrivileges to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-29 16:32:07 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
7ef47312db Remove remaining calls to old DI container 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 15:02:08 -03:00
Maurício Meneghini Fauth
5c519cc819 Remove old DI container in Table\StructureControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 14:51:54 -03:00
Maurício Meneghini Fauth
54667a0085 Remove old DI container in Table\RelationControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 14:43:06 -03:00
Maurício Meneghini Fauth
d984b07ba6 Remove old DI container in Table\SearchControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-15 23:00:56 -03:00
Maurício Meneghini Fauth
9aa85d058b Remove old DI container in Table\IndexesControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-15 22:27:25 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271) 
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-06-01 15:13:41 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-19 01:54:44 +02:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree 
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-24 02:25:48 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString() 
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00