Commit Graph

4136 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
06909939b0
Merge pull request #17444 from kamil-tekiela/Refactor-importSQL
Refactor import sql
2022-04-10 11:44:35 -03:00
Maurício Meneghini Fauth
88ae2a2044
Merge pull request #17380 from kamil-tekiela/Microoptimizations-for-exportSQL
Refactor ExportSql::exportData()
2022-04-10 11:33:21 -03:00
Maurício Meneghini Fauth
0843ba0cce Extract the HTML from the ResponseRenderer::getDisplay method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-09 19:27:52 -03:00
Maurício Meneghini Fauth
2c5143feda Remove ResponseRenderer::getFooter method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-09 12:32:14 -03:00
Maurício Meneghini Fauth
ce14c14544
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-05 20:26:56 -03:00
Maurício Meneghini Fauth
cd1bef6c70
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-05 19:50:06 -03:00
Rodrigo Pokemaobr
9e63cc27e0 Fixing geometry bug when clicking in edit or copy in browse link
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-04-05 14:24:27 -03:00
Maurício Meneghini Fauth
6c8d9b0a58
Inline the console/toolbar template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-04 23:33:46 -03:00
Maurício Meneghini Fauth
f47db6b1a0
Refactor PhpMyAdmin\Core::isAllowedDomain method
Simplifies the requirements and add more unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-04 23:32:06 -03:00
Maurício Meneghini Fauth
f39e657cd9 Refactor ThemeSetController class
- Introduces ServerRequest class
- Moves UserPreferences class to constructor
- Adds unit tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-01 01:13:39 -03:00
Maurício Meneghini Fauth
acba6ed40f
Move VersionInformation to constructor in VersionCheckController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-31 17:58:37 -03:00
Rodrigo Pokemaobr
65ca2ee340 Changing value of to avoid js error on debugJson
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-03-31 15:20:20 -03:00
Maurício Meneghini Fauth
05bd23addf
Fix issue in VersionInformation class reported by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-31 13:32:24 -03:00
Maurício Meneghini Fauth
c5611531c0 Remove trigger_error calls from HomeController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-30 22:13:54 -03:00
Kamil Tekiela
51f26fa5b0 Fix bug #17445
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-26 13:00:51 +00:00
Maurício Meneghini Fauth
cf7fa38feb
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-26 01:39:57 -03:00
Maurício Meneghini Fauth
924edd57fa
Add unit test for PhpMyAdmin\Core::downloadHeader
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-25 19:35:15 -03:00
Maurício Meneghini Fauth
771d49bece
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-24 20:42:17 -03:00
Maurício Meneghini Fauth
16aa04fc4e
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-24 20:40:40 -03:00
Maurício Meneghini Fauth
642762c9b8
Extract console.js objects into console module
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-23 20:20:44 -03:00
Maurício Meneghini Fauth
3befb5f8d0
Remove debugSQLInfo JS global variable
Replaces it with a ConsoleDebug property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-22 15:24:13 -03:00
Maurício Meneghini Fauth
62683a0115 Add method to AbstractController to send error messages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-20 16:39:33 -03:00
Liviu-Mihail Concioiu
b9edade853 Remove Italian and Romanian languages
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2022-03-20 19:54:14 +01:00
Maurício Meneghini Fauth
0d4d2a4935
Add exceptions for invalid identifier names
- Adds the PhpMyAdmin\Dbal\InvalidIdentifierName exception
- Adds the PhpMyAdmin\Dbal\InvalidDatabaseName exception
- Adds the PhpMyAdmin\Dbal\InvalidTableName exception

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-19 17:35:35 -03:00
Maurício Meneghini Fauth
619d4acb4a
Refactor DropColumnConfirmationController class
- Removes global variables
- Redesigns the HTML to use Bootstrap styles
- Add more tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-18 15:36:07 -03:00
Kamil Tekiela
8e367a2c9c Update phpstan-baseline.neon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:46:27 +00:00
Kamil Tekiela
9469fd9eeb Remove redundant if statement with elseif
The string even when trimmed will never be empty. Checking for "0" string makes no sense in my opinion and null is an impossible value (despite PHPStan not recognizing it).

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:46:27 +00:00
Kamil Tekiela
d043ceedc6 Refactor $sql_data
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:46:27 +00:00
Kamil Tekiela
ff4614d581 Use null-coalesce
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:45:31 +00:00
Kamil Tekiela
c2edf8534c Change empty for stricter comparison
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:45:31 +00:00
Kamil Tekiela
ade85420a8 Inline runQueryPost()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

import
2022-03-17 20:45:31 +00:00
Kamil Tekiela
ad0acda8b2 Remove parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
009a92c545 Set parameter type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
69b5e5e159 Fix phpdoc types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
a09fa965a4 Refactor the for loop
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
0def6a56fc Remove boolean use of strcmp()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
b3759ba7e4 Remove count()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
06e4c77f64 Remove redundant cast
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Kamil Tekiela
5c8a4e90a0 Remove pass-by-ref
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:23:25 +00:00
Maurício Meneghini Fauth
39fac83fb2
Merge pull request #17439 from Jir4/fix-tabindex
Enable tabindex recompute on preview button while insert new rows
2022-03-16 13:34:11 -03:00
Maurício Meneghini Fauth
217c6357e8
Fix FavoriteTableController error when missing db param
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 17:18:55 -03:00
Maurício Meneghini Fauth
9faaad41ac
Fix export not working
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 17:12:37 -03:00
Maurício Meneghini Fauth
8c6d3d8b3a
Remove the 400 http status code from AbstractController::checkParameters
Related to #17429

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 16:52:18 -03:00
Kamil Tekiela
4dabcf00ed remove redundant isset
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-15 17:06:47 +00:00
Kamil Tekiela
9b8a8cc54e Remove unused global
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-15 16:58:20 +00:00
Kamil Tekiela
bf8d6a10ca Remove unused parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-15 16:57:51 +00:00
Kamil Tekiela
39e64092b7 Replace isset with null-coalesce everywhere for consistency
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-15 16:57:51 +00:00
Kamil Tekiela
d93a816691 Microoptimizations of exportData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-15 16:57:48 +00:00
Kamil Tekiela
116708ffd4 Microoptimize escapeString
Technically, it's less opcode :)

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-15 16:39:29 +00:00
Maurício Meneghini Fauth
5a75ebc7c7
Refactor Privileges::getRequireClause method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-14 15:15:21 -03:00