Maurício Meneghini Fauth
06909939b0
Merge pull request #17444 from kamil-tekiela/Refactor-importSQL
...
Refactor import sql
2022-04-10 11:44:35 -03:00
Maurício Meneghini Fauth
2c5143feda
Remove ResponseRenderer::getFooter method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-09 12:32:14 -03:00
Maurício Meneghini Fauth
f39e657cd9
Refactor ThemeSetController class
...
- Introduces ServerRequest class
- Moves UserPreferences class to constructor
- Adds unit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-01 01:13:39 -03:00
Maurício Meneghini Fauth
acba6ed40f
Move VersionInformation to constructor in VersionCheckController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-31 17:58:37 -03:00
Maurício Meneghini Fauth
c5611531c0
Remove trigger_error calls from HomeController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-30 22:13:54 -03:00
Maurício Meneghini Fauth
62683a0115
Add method to AbstractController to send error messages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-20 16:39:33 -03:00
Maurício Meneghini Fauth
0d4d2a4935
Add exceptions for invalid identifier names
...
- Adds the PhpMyAdmin\Dbal\InvalidIdentifierName exception
- Adds the PhpMyAdmin\Dbal\InvalidDatabaseName exception
- Adds the PhpMyAdmin\Dbal\InvalidTableName exception
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-19 17:35:35 -03:00
Maurício Meneghini Fauth
619d4acb4a
Refactor DropColumnConfirmationController class
...
- Removes global variables
- Redesigns the HTML to use Bootstrap styles
- Add more tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-18 15:36:07 -03:00
Kamil Tekiela
d043ceedc6
Refactor $sql_data
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-03-17 20:46:27 +00:00
Maurício Meneghini Fauth
217c6357e8
Fix FavoriteTableController error when missing db param
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 17:18:55 -03:00
Maurício Meneghini Fauth
9faaad41ac
Fix export not working
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 17:12:37 -03:00
Maurício Meneghini Fauth
8c6d3d8b3a
Remove the 400 http status code from AbstractController::checkParameters
...
Related to #17429
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-15 16:52:18 -03:00
Maurício Meneghini Fauth
bc4397f28a
Refactor Transformation\WrapperController
...
Removes superglobals.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 20:32:19 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
...
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
e16682d57a
Remove IS_TRANSFORMATION_WRAPPER constant
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-09 21:59:06 -03:00
Maurício Meneghini Fauth
754e15ebab
Extract method to set globals in ExportController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 19:18:50 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 22:59:33 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
10d31380ef
Merge pull request #17376 from kamil-tekiela/getDbInfo-mangles-tables-with-numerical-names
...
getDbInfo mangles table with numerical names
2022-03-04 12:16:52 -03:00
Maurício Meneghini Fauth
9b5b210fc4
Remove action global var from ColumnsDefinition class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-03 17:41:52 -03:00
Maurício Meneghini Fauth
a1a778d475
Fix some issues reported by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-03 12:36:34 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
40135c26cc
Add basic test for Table\DeleteRowsController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-25 16:44:49 -03:00
Maurício Meneghini Fauth
60f75803e8
Add basic test for Table\DropColumnController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 22:29:22 -03:00
Maurício Meneghini Fauth
81cfa99df4
Move Advisor class to PhpMyAdmin\Advisory namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 13:16:19 -03:00
Maurício Meneghini Fauth
687a83923a
Add basic test for Table\GetFieldController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 12:54:43 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
69a8c97e67
Merge pull request #17406 from mauriciofauth/add-index-bug
...
Fix create index form accepting too many columns
2022-02-21 11:42:04 -03:00
Maurício Meneghini Fauth
366c586330
Add better error handling when IndexedDB is not working
...
- Fixes #16853
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-20 19:20:34 -03:00
Maurício Meneghini Fauth
1cac3baeab
Fix create index form accepting too many columns
...
- Fixes #16769
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-20 13:11:30 -03:00
Maurício Meneghini Fauth
a8ca6894a7
Create the validator-messages.js file
...
- Extracts the validator messages from the javascript/variables template
into a new file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-15 15:13:59 -03:00
Maurício Meneghini Fauth
e514bda5b1
Create datetimepicker.js file
...
Extracts the datepicker and timepicker translations logic from
the javascript/variables template into the new datetimepicker.js file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-15 14:04:46 -03:00
Maurício Meneghini Fauth
c482cd47ef
Remove gridEditingConfig JS global
...
- Uses data attribute instead.
- Uses Bootstrap's tooltip instead of the jQuery plugin.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-14 23:19:29 -03:00
Maurício Meneghini Fauth
a0337bf220
Refactor JavaScriptMessagesController controller
...
- Removes the dependency of the cfg and theme PHP globals.
- Handles the errors when encoding the messages to JSON.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-14 18:09:57 -03:00
Kamil Tekiela
50303cd77e
Fix numerical keys
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-02-12 20:11:04 +00:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers
...
Replaces them with their respective globals.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-02 14:48:43 -03:00
Shucon Tech
c3889257cf
Replace Change Password dialog to modal ( #17116 )
...
* Replace Change Password dialog to modal
Signed-off-by: Saksham Gupta <shucontech@gmail.com>
* Bootstrap modal class
Signed-off-by: Saksham Gupta <shucontech@gmail.com>
* Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-30 18:10:20 -03:00
Shucon Tech
745c39bf9c
Replace function Confirm dialog with modal ( #17115 )
...
* Replace function Confirm dialog with modal
Signed-off-by: Saksham Gupta <shucontech@gmail.com>
* Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 21:54:14 -03:00
Maurício Meneghini Fauth
87f8ece01d
Deprecate the db and table properties from controllers
...
The database and table parameters should be got from the server request
or from the respective globals.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 20:51:03 -03:00
Maurício Meneghini Fauth
8529de4d88
Merge pull request #17303 from kamil-tekiela/Remove-globals
...
Remove globals
2022-01-28 16:47:16 -03:00
Maurício Meneghini Fauth
a8d514a350
Remove db and table globals from DbTableExists class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-28 16:43:48 -03:00
Kamil Tekiela
47e81a5161
Remove $route global
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-27 11:47:40 +00:00
Isaac Bennetch
985912f58f
Fix merge conflicts from security branch
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages
...
Note: 'action_done' was not used since
c962ee4287 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 15:05:43 -03:00
Kamil Tekiela
86031d2bf6
Deimplement fetchAssoc() helper
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 22:44:53 +00:00
Maurício Meneghini Fauth
290f026a02
Merge pull request #17272 from kamil-tekiela/queryAsControlUser
...
Query as control user
2022-01-06 21:32:46 -03:00