Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
8f992a4fbf
Fix some errors found by PHPStan and Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-15 18:49:37 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
5faf95016f
Use DatabaseName VO for db names in Table\Partition
...
- Adds DatabaseName support for DatabaseInterface::selectDb method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-21 21:30:37 -03:00
William Desportes
db01d6a9da
Remove some else conditions by using early exits or moving code
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 01:18:39 +02:00
William Desportes
a4bcd1cfc4
Move DBI getForeignKeyConstrains method to controller
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 00:19:02 +02:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 19:01:26 +02:00
William Desportes
e70c7c40ea
Improve debug SQL format
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-24 16:16:29 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-16 12:11:51 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
1ac9a165e0
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-25 18:44:47 +01:00
William Desportes
3e8b51214f
Fix a non working query that prevented events to show up right after adding them
...
Ref: 535c1a4cb5
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-25 18:31:49 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
William Desportes
8917e77bba
Fix #16595 - escape mysql wildcards on structure edit fields
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:30:56 +01:00
Prashant Tholia
ebff28171c
Fix #16463 - 'REFERENCES' privilege checkbox's title
...
Set different title messages depending on database and database version for 'REFERENCES' field in user 'Edit Preferences' form.
Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Prashant Tholia <prashant.tholia@gmail.com>
2021-01-22 00:05:43 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base
...
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
e4e274976e
Extract cache methods from Util to SessionCache class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 22:45:56 -03:00
Maurício Meneghini Fauth
4873c32273
Remove DatabaseInterface::isUserType method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
a83ec78ebf
Make DatabaseInterface::isUserType method private
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
a53189def0
Fixes #16278 - Remove underscore prefix from property names of DBI class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:23:20 +02:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
dfa5f92c31
Add return type declaration to fetch row methods
...
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
Maurício Meneghini Fauth
4cb24fe46e
Fix return types of fetchArray and fetchRow methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 13:10:26 -03:00
Maurício Meneghini Fauth
3a6cd6be21
Fix return type declaration of fetchAssoc method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 12:52:31 -03:00
William Desportes
b0021bf84d
Fixes : #16149 - Remove underscore prefix from all method names
...
Ref: #16159
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:21:24 +02:00
William Desportes
f433d5e7bc
Remove a typehint and document the edge case for _fetchValue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 22:50:51 +02:00
William Desportes
802797c176
Move getConnectionParams to Config class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 16:01:38 +02:00
William Desportes
36fa925914
Extract SQL query from DatabaseInterface::getColumnsFull
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 15:08:36 +02:00
William Desportes
73fb678d08
Extract SQL query from DatabaseInterface::getDatabasesFull
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 15:01:58 +02:00
William Desportes
ffcabac791
Simplify DatabaseInterface _fetchValue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:54:33 +02:00
William Desportes
8e164bda85
Move _dbgQuery to Query\Utilities as debugLogQueryIntoSession
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:47:39 +02:00
William Desportes
eecab19b3e
Move versionToInt to Query\Utilities
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:18:03 +02:00
William Desportes
54e27c6a3d
Simplify DatabaseInterface fetchValue logic
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:17:01 +02:00
William Desportes
aadb6abfeb
Move usortComparisonCallback to Query\Utilities and remove 2 globals
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 10:34:02 +02:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 02:16:02 +02:00
William Desportes
585304b685
Move formatError into Query\Utilities
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:44:02 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
...
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
William Desportes
312bf572f2
Move some compatibility handling into Query\Compatibility
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:26:07 +02:00
Maurício Meneghini Fauth
e2eac49ad2
Use closures to call private methods as callback
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff
Remove useless elseif with if
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
2d02a15de3
Add static to closures that don't use $this
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00