Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
10b3ead050
Remove invalid covers annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-05 16:29:31 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
William Desportes
d221eed5d9
Fix failing tests, seed: 1624814216
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 22:45:41 +02:00
William Desportes
6996e8dd28
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 19:01:02 +02:00
William Desportes
d26739ec64
Ref #16982 - Add a test for removeRelation drop FK
...
And fix PHP 7.1 function syntax call
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 17:25:28 +02:00
William Desportes
962d33a4aa
Ref #16982 - Add tests for removeRelation
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 16:42:34 +02:00
Maurício Meneghini Fauth
1ed9ab5dda
Fix failing unit test
...
Random Seeds: 1623610942, 1623612011, 1623680984
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-14 12:41:49 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
e376c4189b
Remove the .pma-fieldset from some pages
...
Replaces with Bootstrap's cards
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 18:18:23 -03:00
Maurício Meneghini Fauth
b9464bdd1b
Extract the HTML from the Triggers::getEditorForm method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 15:44:21 -03:00
Maurício Meneghini Fauth
a7d6df17d6
Remove warnings from PHPUnit
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-09 13:28:47 -03:00
Brittany Barnes
dc1be997c9
Converted getExecuteform to utilize twig template ( #16712 )
...
Signed-off-by: Britt Barnes <britbarnes92@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-19 15:23:27 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
...
Uses the PhpMyAdmin\Version::VERSION constant instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
65ca0c1b2c
Extract HTML from Database\Routines::getEditorForm method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-08 17:49:22 -03:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ea163ffcae
Move CentralColumns to the Database namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 10:14:22 -03:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
2358b9c4f9
Fix missing property type hints
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
William Desportes
0340f66740
Fix some tests having wrong typehints
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 23:55:49 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce
Add return type declaration to test methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31
Add return type declaration to fetch row methods
...
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
William Desportes
a13e5d1c16
Fix tests documentation after removing _ from private methods
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:01:57 +02:00
charliewindred
7d792e88f6
Removed underscores from unit test methods
...
Removed underscore prefixes from unit test method calls.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 23:52:32 +02:00
charliewindred
ca3c5e17b0
Remove underscore prefix from method names
...
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
45898139c7
Type fixes for EventsTest
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 01:36:56 +02:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
7b6cf8a1b9
Fix bad mocking cleanup of Response::_instance
...
Seed: 1590097033
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:40:59 +02:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
5c270d863d
Move callProtectedFunction to abstract class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 21:58:41 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
f89f4c9f2c
Fix failing tests after tear down cleans everything
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
a7490fcb6c
Make AbstractTestCase manage GLOBALS cleanup and config loading
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
Some minor improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
Force sql-parser to reload the new language
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
...
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest
Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
f2d349df40
Split part of the logic of getQueryFromRequest into processParamsAndBuild
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 14:06:36 +02:00