Commit Graph

52 Commits

Author SHA1 Message Date
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Hugues Peccatte
fd7f02f929 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 14:33:41 +01:00
Dhananjay Nakrani
83d63d23ea Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
627873f146 Enable 'Send error reports automatically next time' option in php error reporting form.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
b621ab9277 Merge paths for 'php'& 'js' error reporting.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
b2e3164441 Make return values of PMA_getReportData() consistent.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
bc76f04ce7 Remove trailing whitespaces.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e37616adba Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
0b9439a246 Make automatic php error report submission ('sendErrorReport'='always') aysnchronous. Stop infinite auto error reporting loop.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
9a1fb901d0 Remove included 'common_error_reporting.php' script and its inclusion from all the scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
86b3f352a9 Stop false alarms (displaying prompts-reporting form and reporting for 'false' (user warnings) errors).
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
e9d5523795 Include error reporting script at the end of all the 'relevant' scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
d4bddddd93 Improve Error Message.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
e74cd6ec1d Report errors based on user preference. All the cases taken care of.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Michal ฤŒihaล™
1fb2276e2b Fix if formatting
Signed-off-by: Michal ฤŒihaล™ <michal@cihar.com>
2014-05-28 10:43:33 +02:00
Michal ฤŒihaล™
d3fcfec4bb Consistent message strings and types for error submission
We can share more strings on the failed error reporting and also the
messages should have same type regardless it was manual or automatic
submission.

Signed-off-by: Michal ฤŒihaล™ <michal@cihar.com>
2014-05-28 09:26:35 +02:00
Michal ฤŒihaล™
3f21b2816f Get rid of overridable return type
Separate function for collecting the data from pretty printing it.

Signed-off-by: Michal ฤŒihaล™ <michal@cihar.com>
2014-05-06 13:26:41 +02:00
Madhura Jayaratne
3c9f6a6890 Space around . operator - mroe instances
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 18:56:30 +05:30
Michal ฤŒihaล™
b027060c87 Another not checked variable before use (bug #4114) 2013-11-25 09:25:16 +01:00
Michal ฤŒihaล™
aefabf5335 Check whether variable is set 2013-11-18 15:01:53 +01:00
Michal ฤŒihaล™
15eaddb6af Coding style 2013-11-18 11:49:43 +01:00
Mohamed Ashraf
38fea8e663 Fixed linting error 2013-11-17 23:17:18 +01:00
Mohamed Ashraf
f82e321b75 Message shows failure of error report submission 2013-11-17 20:29:14 +01:00
Marc Delisle
677e4496b7 Bug #4114 No params checking in error_report.php 2013-11-17 08:56:55 -05:00
Madhura Jayaratne
b92fabb0d5 Fix coding style 2013-10-22 07:25:45 +05:30
Marc Delisle
5d92e16834 Merge pull request #730 from m0hamed/error_report_fix
Fixed bug where send error report not being called
2013-10-16 08:17:07 -07:00
Mohamed Ashraf
70d73fed94 Fixed bug where send error report not being called 2013-10-11 11:30:34 +02:00
Michal ฤŒihaล™
3f3dfb1ecc Allow error reporting without precalculated line counts
As these can now be done on the fly
2013-10-03 14:48:23 +02:00
Dieter Adriaenssens
5028d8e716 improve message 2013-10-01 21:11:02 +02:00
Dieter Adriaenssens
34a75e0b11 fix typo 2013-09-30 17:37:57 +02:00
Mohamed Ashraf
39cddaf596 Fixed type 2013-09-21 00:43:42 +02:00
Mohamed Ashraf
c5d2d51007 Error reporting now fails gracefully on dev builds 2013-09-21 00:42:00 +02:00
Mohamed Ashraf
43c8e8c448 Refactored error report functions to a library and added doc blocks 2013-09-01 00:59:26 +02:00
Mohamed Ashraf
3edba72c1f Fixed inconsistencies with error reporting server in report schema 2013-08-18 19:40:55 +02:00
Mohamed Ashraf
dc63ed89c4 Added url sanitization to remove useless params and get script name for error grouping 2013-08-03 00:45:33 +02:00
Mohamed Ashraf
9d38212c06 Changed submission url to new controller 2013-08-03 00:44:47 +02:00
Mohamed Ashraf
005c8953a3 Removed some useless comments in error_report.php 2013-07-29 17:51:45 +02:00
Mohamed Ashraf
0e3b830e3e Changed using to ['cfg'] in error_report.php 2013-07-29 17:07:38 +02:00
Mohamed Ashraf
f8fe8e5aa3 Stacktrace now translated if line counts exist 2013-07-29 16:55:27 +02:00
Mohamed Ashraf
841c7c8f21 Changed submission url and report key names 2013-07-27 12:41:38 +02:00
Mohamed Ashraf
2c0c621203 Added user operating system and server software 2013-07-03 20:56:04 +02:00
Mohamed Ashraf
4e8ea5876d Fixed sending of report to server. Data sent successfully 2013-07-03 18:00:12 +02:00
Mohamed Ashraf
fe37de2640 Removed 'VersionCheck' profix from proxy variables 2013-06-29 14:49:02 +02:00
Mohamed Ashraf
396184c85a Fixes width issues in firefox 2013-06-29 14:29:40 +02:00
Mohamed Ashraf
96f038f285 fixed scenario where error reports may not be sent correctly to error report server 2013-06-29 13:36:36 +02:00
Mohamed Ashraf
e3205f1316 Fixed conditions due to PHP gotchas 2013-06-27 18:52:43 +02:00
Mohamed Ashraf
abcfe1a11e Data is sent using POST and in json format 2013-06-25 22:21:27 +02:00
Mohamed Ashraf
9bc3fd5387 Now data submision uses proxy settings and file get contents 2013-06-25 21:43:33 +02:00
Mohamed Ashraf
0fb14931cd Corrected comments by Rouslan
* Added doc blocks to functions
* Removed syntax error
* Changed string in error report form
* resized error report notification to full screen size
2013-06-25 07:45:45 +02:00
Mohamed Ashraf
3541a6d2b5 error reporting now respects settings 2013-06-24 15:38:13 +02:00