Commit Graph

528 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1e542cd621
Replace vendor_config.php constants with an array
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 16:48:56 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
dc37d436cc
Extract common.inc.php logic to Common::run method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:48:11 -03:00
Maurício Meneghini Fauth
17f4e09a6b
Extract some common checks from common.inc.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:27:14 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
76aabc9826
Remove PMA_MINIMUM_COMMON constant
Replaces it with the `$isMinimumCommon` global variable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-02 01:29:07 -03:00
Maurício Meneghini Fauth
a7be49f06f Remove TESTSUITE constant from js/messages.php
Related to https://github.com/phpmyadmin/phpmyadmin/issues/15247

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-06 16:56:19 -03:00
Maurício Meneghini Fauth
a2cc9eb668 Create JavaScriptMessagesController class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-06 13:51:23 -03:00
Maurício Meneghini Fauth
f8fb01714e Use json_encode in js/messages.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-04 21:02:53 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
Manthan Surkar
10116e9824
Informing the user about the HEX conversion scheme of Integers
Signed-off-by: Manthan Surkar <manthan.surkar@gmail.com>
2020-05-14 13:52:23 +02:00
Maurício Meneghini Fauth
e656f341ef Redesign the server status advisor page
Uses an accordion instead of a table to show the issues.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 02:56:16 -03:00
Maurício Meneghini Fauth
1a3416da8d Add support for Bootstrap modals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-12 20:33:48 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
William Desportes
88e8d57c81
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-16 21:43:20 +01:00
Yash Bothra
1470761a8f
Fix #15720 - added markUnsaved function
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-01-16 21:31:43 +01:00
Maurício Meneghini Fauth
b9639c7160 Use only one array assignment in js/messages.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-31 13:24:24 -03:00
Maurício Meneghini Fauth
f126e14599 Extract js variables from js/messages.php
Moves JavaScript variables to templates/javascript/variables.twig.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-18 16:48:41 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
718ceadeb6
Merge branch 'QA_5_0-security' into master-security
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-22 01:23:51 +01:00
William Desportes
28bdc02c3c
Merge branch 'QA_4_9-security' into QA_5_0-security
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-22 01:19:16 +01:00
William Desportes
2adf0ba1ac
Remove some hacks and strange things from designer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 13:00:32 +01:00
Maurício Meneghini Fauth
e8c5ba4f80 Convert Messages to Bootstrap Alerts
Replaces Messages custom styles with a Bootstrap Alerts theme

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 15:28:47 -03:00
William Desportes
f52f3afff3
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 15:48:34 +01:00
William Desportes
c16891cb40
Merge branch 'QA_4_9' into QA_5_0 2019-11-09 15:41:21 +01:00
William Desportes
4ae14a3da9
Improve l10n context for translators and fix a typo
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 15:35:59 +01:00
Maurício Meneghini Fauth
0ce7e21ed8
Merge pull request #14925 from saurass/issue-14909
Issue #14909 - Define the 1st day of week of the calendar in config.php
2019-11-07 17:44:25 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
803d07d868
Merge branch 'QA_5_0' into 'master'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 14:19:56 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
5940d11e72
Merge #15448 - Fix many bugs when adding new tables to designer
Fixes: #15446
Pull-request: #15448
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-22 14:05:32 +02:00
Hugues Peccatte
58e3b71ae2 Update js/messages.php
add context for translators

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-22 10:07:15 +02:00
Hugues Peccatte
b37b479da0 Display an error when trying to import in designer a table that's already imported
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 23:05:15 +02:00
Hugues Peccatte
de57539fb7 Build "tables list" in JS
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:01:17 +02:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-18 14:33:43 -03:00
saurass
1572caa595
Fix #14909 - Config option for 1st day of the week for datepicker in server settings -> config -> time form
Fixes: #14909

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-07-04 11:41:15 +02:00
Maurício Meneghini Fauth
efe77cdf06 Rename js/tbl_*.js to js/table/*.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 04:09:05 -03:00
Maurício Meneghini Fauth
05ce6ffed4 Rename js/server_*.js to js/server/*.js
Rename js/server_status_*.js to js/server/status/*.js

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 03:56:22 -03:00
Maurício Meneghini Fauth
c8e98dea2f Rename js/db_*.js to js/database/*.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 03:37:42 -03:00
Maurício Meneghini Fauth
c4e4d30300 Fix undefined variables in some JavaScript files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-05 22:53:29 -03:00
Maurício Meneghini Fauth
cfe8af2b6e Rename mysql_doc_* variables to camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 00:53:00 -03:00
Maurício Meneghini Fauth
ea2d5a0d87 Rename PMA_messages JS global variable to Messages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-20 23:58:23 -03:00
William Desportes
f3c94b7c92
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-16 21:21:17 +01:00
William Desportes
0223c0607e
Fix #14826 - PMA_messages is not defined
This issue occurs when the session folder does not have access permissions and a file calls it as a script (see: index.php). This creates a javascript issue because PMA_messages are not defined.

Fixes: #14826

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-16 17:50:33 +01:00
Maurício Meneghini Fauth
87bf7c397f Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-27 13:59:44 -03:00