gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,453 Commits 12 Branches 481 Tags 2.4 GiB
9dfedff70b
Commit Graph

78 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
7955f7d96d
Replace pow function with the ** operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 19:12:11 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-13 15:29:11 -03:00
William Desportes
cbe4eae632
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 18:46:28 +02:00
William Desportes
90066200ed
Fix #17004 - Fix Advisor for MariaDB >= 10.5 because of removed "innodb_log_files_in_group" variable 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 18:41:53 +02:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
235a79483d
Fix Advisor formatting incorrect for long_query_time notice 
Fixes #16622

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-02-08 14:31:17 -03:00
Maurício Meneghini Fauth
0f463b71f9
Fix link HTML messed up in Advisor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-02-07 13:32:45 -03:00
Maurício Meneghini Fauth
eb3b81982d Remove final modifier from Advisor class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-04 14:36:07 -03:00
Maurício Meneghini Fauth
7cee8e44f9 Refactor the Advisor class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-31 15:39:26 -03:00
Maurício Meneghini Fauth
45e1128122 Move gettext calls to advisory rules files 
Removes the need of the AdvisoryRulesCommand.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-31 15:37:46 -03:00
Maurício Meneghini Fauth
51ae4fad22 Remove advisory rules file parser 
Uses a PHP array instead of parsing a TXT file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-31 15:37:46 -03:00
Maurício Meneghini Fauth
ccbcc08c25 Fix some PHPStan errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-23 20:36:44 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e2eac49ad2 Use closures to call private methods as callback 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
William Desportes
795d708c65
Use a plausible phpdoc typehint 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:19:14 +02:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
4153d85ea2
Add some properties typehints on Advisor class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-02 01:29:42 +02:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-29 01:08:40 +02:00
Maurício Meneghini Fauth
a63dbfb051 Move SysInfo classes to the Server\SysInfo namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-16 17:22:44 -03:00
William Desportes
dce1104b88
Fix use false instead of null for preg_split 
Ref: 01cd7dc33b

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:42:24 +01:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
f76499af7f Use Throwable instead of Exception 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 01:16:40 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
William Desportes
51f292beab
Improve some params and return types marked as mixed 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-29 14:33:49 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
24e9fb5d29 Use static invocation when needed 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-01 22:50:42 +01:00
Maurício Meneghini Fauth
cf031eacff Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-11 12:55:05 -03:00
Maurício Meneghini Fauth
cc50cf178e Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-11 12:51:03 -03:00
Maurício Meneghini Fauth
cf4d6de840 Fix advisor2po script 
Related to 88821f8248

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-11 12:34:34 -03:00
William Desportes
d33122867f
Merge branch 'QA_5_0' into master 2019-09-22 20:14:45 +02:00
William Desportes
bbf94a7f40
Merge branch 'QA_4_9' into QA_5_0 
Pull-request: #15457
Closes: #15457
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-09-22 20:13:09 +02:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Hugues Peccatte
efbec55643 Fix tests regarding Advisor class changes 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-30 21:17:33 +02:00
Hugues Peccatte
99b2dfade4 Split advisory rules files in many to manage variables removed in some versions 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-30 21:13:36 +02:00
Hugues Peccatte
ab8ffbc8db Fix #14245 Advisor fails on MySQL ≥8.0.3 as many MySQL variables were removed 
As many MySQL variables were removed, we need to disable the rules using these variables.
For this, a variable identifying MySQL had been created and is used with the MySQL version to check if the rule should be checked or not.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-30 21:07:10 +02:00