Erol Guven
b20111d63b
Allow removing DEFINER clause from exported SQL
...
Signed-off-by: Erol Guven <erol.guven@appian.com>
2022-03-10 13:32:04 +00:00
Jonah Tan
0ea87bc42c
Replace html in export description with bb code
...
Signed-off-by: Jonah Tan <47470981+jonahtanjz@users.noreply.github.com>
2022-02-08 00:32:43 +08:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-11 14:31:56 -03:00
Kamil Tekiela
d44578ee04
Refactor flattenArray into getFlatArray in ConfigFile
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-07 19:38:37 +00:00
Kamil Tekiela
5eb3404170
Cache translations for names, comments and descriptions
...
This should improve performance of their lookups. It's unlikely that
translations will change during the course of the request.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-07 19:38:37 +00:00
Kamil Tekiela
488e7cb5bf
Use array_keys whenever only keys are needed in foreach
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-29 20:37:39 +00:00
Maurício Meneghini Fauth
857a9d3337
Remove unnecessary @var annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-18 12:15:30 -03:00
Maurício Meneghini Fauth
3922cb7928
Merge branch 'QA_5_1'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-27 15:04:40 -03:00
Hidayatullah
064f1eb64b
Fix bbcode not rendered for error messages on setup
...
Fixes #17090
Closes #17138
Signed-off-by: Hidayatullah <ayat.kyo@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-27 14:39:27 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
229d8dfb5e
Extract Console, Debug and SqlQueryBox classes from Settings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-19 13:17:32 -03:00
Maurício Meneghini Fauth
73034e43e1
Extract setter methods from Config\Settings classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-18 12:44:48 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
b2aab39003
Extract methods for setting properties
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-24 19:09:34 -03:00
Maurício Meneghini Fauth
5837b691d2
Extract methods for setting properties
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-23 18:03:57 -03:00
Maurício Meneghini Fauth
04d3c83559
Fix some errors found by PHPStan/Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-05 16:09:08 -03:00
Maurício Meneghini Fauth
229767bc30
Add more tests for Config\Settings classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-02 19:29:45 -03:00
Maurício Meneghini Fauth
fa92760002
Add tests for Config\Settings\Export class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-31 15:59:24 -03:00
Maurício Meneghini Fauth
437bd7c974
Create Settings value object for $cfg global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-31 15:59:24 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
cab899d7b5
Fix some errors found by Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-21 15:58:11 -03:00
Maurício Meneghini Fauth
6989d615a5
Fix some errors found by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-09 13:07:40 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-11 01:20:20 +02:00
William Desportes
d005ea8041
Remove some else conditions by using early exits or moving code
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 01:30:25 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23
Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
...
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
90778eecf7
Upgrade phpmyadmin/coding-standard to 3.0.0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-19 02:20:46 -03:00
William Desportes
856145297f
Merge branch 'origin/QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 17:46:06 +02:00
William Desportes
b2bec746eb
Fix #16798 - ServerConfigChecks: Link 'trusted proxies list' not terminated properly (translation)
...
Fixes : #16798
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-13 17:32:06 +02:00
William Desportes
b5cde44e17
Document special schema links array format
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-12 21:48:26 +02:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
17dfe02004
Merge branch 'QA_5_1'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-11 23:00:27 -03:00
Maurício Meneghini Fauth
eb2d865740
Set MySQLi error reporting mode
...
Explicitly sets the MySQLi error reporting mode to the current default
to avoid possibly future changes.
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/16589
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-11 09:53:27 -03:00
William Desportes
2bc0b80cb9
Fix a phpdoc block and a coding standard issue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:23:46 +01:00
William Desportes
b9d5fc72d2
Merge branch 'QA_5_1'
...
The fix for #11505 is excluded
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-28 16:14:00 +01:00
William Desportes
dc14f7685b
Merge #16581 - Fix PHP Uncaught TypeError: htmlspecialchars()
...
Pull-request: #16581
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-28 15:57:58 +01:00
Tarjei Huse
21d7cc5575
Fix "PHP message: PHP Fatal error: Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, bool given in /usr/share/phpmyadmin/libraries/classes/Config/FormDisplayTemplate.php:306
...
"PHP message: PHP Fatal error: Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, bool given in /usr/share/phpmyadmin/libraries/classes/Config/FormDisplayTemplate.php:306"
Signed-off-by: Tarjei Huse <tarjei.huse@gmail.com>
2021-01-28 15:52:12 +01:00
William Desportes
98fb87a09a
Split Descriptions into 3 functions
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-28 15:37:30 +01:00
Maurício Meneghini Fauth
53f5247811
Merge FormDisplay::getDisplay templates
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-05 19:25:21 -03:00
Maurício Meneghini Fauth
1911ac6289
Remove Config\FormDisplay dep from Setup\HomeController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 22:38:27 -03:00
Maurício Meneghini Fauth
d8c1d6e7a1
Extract HTML from FormDisplayTemplate::displayInput
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 18:25:14 -03:00
Maurício Meneghini Fauth
65dd7e8278
Wrap settings tabs with Bootstrap's cards
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-02 18:51:11 -03:00
Maurício Meneghini Fauth
c9ab66170a
Replace Settings page tabs with Bootstrap's tabs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-30 23:20:40 -03:00