gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,453 Commits 12 Branches 481 Tags 2.4 GiB
9dfedff70b
Commit Graph

1051 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency 
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
04f3f5a4b6
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-26 21:03:20 -03:00
Maurício Meneghini Fauth
5d80594341 Remove jQuery SVG JS dependency 
Removed by https://github.com/phpmyadmin/phpmyadmin/pull/17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-24 20:39:12 -03:00
Maurício Meneghini Fauth
b17700dd09 Remove PMA_IS_WINDOWS constant 
Gets the value from the Config class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-24 20:37:55 -03:00
Maurício Meneghini Fauth
e4f0a0d1e6
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-21 15:54:13 -03:00
Maurício Meneghini Fauth
3c3a423727
Fix translation string in Database\DesignerController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-21 15:38:28 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
69a8c97e67
Merge pull request #17406 from mauriciofauth/add-index-bug 
Fix create index form accepting too many columns
 2022-02-21 11:42:04 -03:00
Maurício Meneghini Fauth
366c586330
Add better error handling when IndexedDB is not working 
- Fixes #16853

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 19:20:34 -03:00
Maurício Meneghini Fauth
1cac3baeab
Fix create index form accepting too many columns 
- Fixes #16769

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-20 13:11:30 -03:00
Isaac Bennetch
985912f58f Fix merge conflicts from security branch 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages 
Note: 'action_done' was not used since
c962ee4287.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 15:05:43 -03:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Maurício Meneghini Fauth
290f026a02
Merge pull request #17272 from kamil-tekiela/queryAsControlUser 
Query as control user
 2022-01-06 21:32:46 -03:00
Kamil Tekiela
73b7094b2b Remove redundant isset 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
9afa59487e Collapse if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
202b17c34c Replace if with coalesce 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 18:37:15 -03:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
2d56a8baac
Move Import and ImportStatus ctrls to Controllers\Import ns 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 10:27:28 -03:00
Maurício Meneghini Fauth
2edf663611
Remove the Bookmark::getParams method 
Uses BookmarkFeature class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 09:31:53 -03:00
Maurício Meneghini Fauth
0cf1843e3e
Fix /check-relations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:26:04 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
ca91eaeb38
Accept mixed for DatabaseName and TableName constructors 
This avoids redundant type assertions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-23 16:25:05 -03:00
Maurício Meneghini Fauth
4e0141e19f
Merge pull request #17253 from kamil-tekiela/fetchValue 
Remove $row_number from DatabaseInterface::fetchValue
 2021-12-23 11:40:25 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Kamil Tekiela
70c86f5e21 Remove $row_number from DatabaseInterface::fetchValue 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-21 21:09:38 +00:00
Maurício Meneghini Fauth
92418f2226
Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:39:29 -03:00
Maurício Meneghini Fauth
2a4b170a34
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:13:09 -03:00
Maurício Meneghini Fauth
fa5c684f27
Replace the master/slave terminology 
Replaces master with primary and slave with replica.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-18 14:26:56 -03:00
Maurício Meneghini Fauth
cb3f7fbb16
Move Server\UserGroups to ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Kamil Tekiela
83d950ed40 Bug fix: Fix triple HTML encoding 
Some values were encoded into HTML entities thrice. This commit removes
unnecessary HTML escaping.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-14 12:21:36 +00:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
e68c26672c
Merge pull request #17235 from kamil-tekiela/Fix-var-annotation-for-Charset-and-Collation 
Fix var annotation for Charset and Collation
 2021-12-10 10:11:16 -03:00
Maurício Meneghini Fauth
cd6d6b30ac
Merge pull request #17233 from kamil-tekiela/CreateAddField 
Refactor CreateAddField
 2021-12-09 22:17:49 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-09 22:25:58 +00:00
Maurício Meneghini Fauth
9e2bb1e996
Replace Assert exceptions with a more specific one 
Catches only \Webmozart\Assert\InvalidArgumentException instead of all
\InvalidArgumentException.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-09 14:50:25 -03:00
Kamil Tekiela
ca089b43ab Redesign CreateAddField::tryColumnCreationQuery() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 18:27:26 +00:00
Kamil Tekiela
ce527035c2 PHPStan checkAlwaysTrueCheckTypeFunctionCall fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 15:26:52 +00:00
Maurício Meneghini Fauth
7266c6235d
Merge pull request #17223 from kamil-tekiela/static-analysis-fixes 
Make $subPart non-nullable and remove redundant ?? when it's not null
 2021-12-08 11:01:20 -03:00
Maurício Meneghini Fauth
2299a62e49
Extract HTML from Relation::getRelationsParamDiagnostic 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-05 16:44:29 -03:00
Kamil Tekiela
253b08330d Make $subPart non-nullable and remove redundant ?? when it's not null 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 19:36:06 +00:00
Kamil Tekiela
a42803297c
Psalm fixes 3 (#17221) 
* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Small bug fixes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* non-falsy-string is always true

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* currentSearch property is nullable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $columnIndex

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use parameters instead of globals in sendEditor()

The two globals in this method are read-only. There is an unused
parameter in the signature. Let's add one more and use them instead of globals.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unusued parameter $crlf

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 12:40:19 -03:00