Maurício Meneghini Fauth
1b055dba90
Fix TypeError in the Tracker::handleQuery method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-11 14:50:22 -03:00
Kamil Tekiela
86031d2bf6
Deimplement fetchAssoc() helper
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 22:44:53 +00:00
Kamil Tekiela
f5bb90ebb9
Move queryAsControlUser - Dbal refactoring pt.3
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:31:27 +00:00
Kamil Tekiela
47a039d70c
Implement ResultInterface & MysqliResult
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
994cf8fa39
Remove Tracker::getTrackingTable method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Kamil Tekiela
70c86f5e21
Remove $row_number from DatabaseInterface::fetchValue
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-21 21:09:38 +00:00
Maurício Meneghini Fauth
2a4b170a34
Merge branch 'QA_5_1'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-21 13:13:09 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
William Desportes
13d3e93f84
#16005 - performance improvement on the Import page
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-12-12 20:56:10 +01:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-11 08:10:40 -03:00
Kamil Tekiela
be87571da6
PHPStan checkAlwaysTrueStrictComparison fixes
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-08 15:26:52 +00:00
Kamil Tekiela
58d9bb4a32
Refactor DatabaseInterface::getColumns()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-25 10:28:39 +00:00
Maurício Meneghini Fauth
090d2eece7
Fix some issues found by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-16 15:11:57 -03:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
...
Replaces the $cfgRelation array with the RelationParameters value
object.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
William Desportes
36e24d174d
Make Tracking::enabled not use statics as it does mess up with tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-24 02:01:03 +02:00
Maurício Meneghini Fauth
1129b68d29
Refactor PhpMyAdmin\Plugins::getPlugin method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-25 17:40:20 -03:00
William Desportes
a6d39d39be
Improve non standard doc blocks
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-15 21:39:28 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
48b382cb97
Merge branch 'origin/QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 12:21:24 +02:00
William Desportes
a6f7b4ee1c
Add more type safe guards for #16837
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 22:58:09 +02:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
Maurício Meneghini Fauth
3a161651ea
Rename variables to use camel case format
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-07 14:58:49 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
48a6b710b4
Improve Tracker::getVersion failure case
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 19:11:20 +01:00
William Desportes
c76c6aecee
Do not output tracking query failure
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 18:37:20 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base
...
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
97f53937ee
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 15:39:38 -03:00
Saksham Gupta
b45de41b4b
Fixes Tracking bugs ( #16389 )
...
* Fixes Tracking bugs
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2020-10-13 15:31:22 -03:00
Maurício Meneghini Fauth
ac9bccf67d
Replace $GLOBALS['dbi'] with global $dbi
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
charliewindred
ca3c5e17b0
Remove underscore prefix from method names
...
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
0cbba2aef2
Add some properties typehints
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:41:59 +02:00
William Desportes
517222ff59
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
Sean Mollet
81d1330ae5
Fix crash when tablename or dbname is not set
...
Drop statements don't give proper tablenames, resulting in a crash. Obviously, that issue needs fixed as well, but handling it cleanly seems preferable.
Signed-off-by: Sean Mollet <sean@malmoset.com>
2020-02-12 22:44:37 +01:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37
Remove use statements within the same namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00