Commit Graph

83 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages
Note: 'action_done' was not used since
c962ee4287.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 15:05:43 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
17f4e09a6b
Extract some common checks from common.inc.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:27:14 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
282fbe76c5
Fix case where $_SERVER['REQUEST_METHOD'] is undefined
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/16991

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-05 17:23:32 -03:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
585fdaea5a Fix PHP doc spacing and order
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 18:07:37 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
Maurício Meneghini Fauth
e222cb8beb Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 13:02:14 -03:00
Maurício Meneghini Fauth
08696bc55e Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 12:51:04 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
94a18417ee Declare $cfg global variable explicitly
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 13:03:23 -03:00
Maurício Meneghini Fauth
d2d65d5a7b Create controllers for setup pages
- Create PhpMyAdmin\Controllers\Setup\HomeController
- Create PhpMyAdmin\Controllers\Setup\ConfigController
- Create PhpMyAdmin\Controllers\Setup\FormController
- Create PhpMyAdmin\Controllers\Setup\ServersController
- Remove setup/frames directory

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-06 17:04:58 -03:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Michal Čihař
dc420e2872 Merge branch 'QA_4_7' 2017-07-10 15:00:36 +02:00
Michal Čihař
bd2a0ec307 Wrap file_exists calls with @
It can produce warnings in case open_basedir is enabled.

Fixes #13467

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-10 14:59:43 +02:00
Maurício Meneghini Fauth
13c0f7bc3c Move classes to PhpMyAdmin namespace
- Move Advisor to PhpMyAdmin namespace
- Move Bookmark to PhpMyAdmin namespace
- Move Charsets to PhpMyAdmin namespace
- Move Config class to PhpMyAdmin namespace
- Move Console class to PhpMyAdmin namespace
- Move Core to PhpMyAdmin namespace
- Move DatabaseInterface to PhpMyAdmin namespace
- Move DbList to PhpMyAdmin namespace
- Move DbQbe to PhpMyAdmin namespace
- Move DbSearch to PhpMyAdmin namespace
- Move DisplayResults to PhpMyAdmin namespace
- Move Encoding to PhpMyAdmin namespace
- Move Error to PhpMyAdmin namespace
- Move ErrorHandler to PhpMyAdmin namespace
- Move File to PhpMyAdmin namespace
- Move Font to PhpMyAdmin namespace
- Move Footer to PhpMyAdmin namespace
- Move Header to PhpMyAdmin namespace
- Move Index to PhpMyAdmin namespace
- Move IndexColumn to PhpMyAdmin namespace
- Move LanguageManager to PhpMyAdmin namespace
- Move Language to PhpMyAdmin namespace
- Move Linter to PhpMyAdmin namespace
- Move ListAbstract to PhpMyAdmin namespace
- Move ListDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-28 21:17:18 -03:00
Maurício Meneghini Fauth
61b7d5dfd8 Move js/jquery to js/vendor/jquery
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-14 01:57:25 -03:00
Maurício Meneghini Fauth
e330402b5b Refactor the core functions into static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-03 00:52:22 -03:00
Michal Čihař
73ab7f380b Allow to run setup on the demo server
Fixes #13083

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-30 13:47:45 +02:00
Michal Čihař
1dd22f4dea Merge branch 'QA_4_6-security' into master-security 2017-01-07 11:02:01 +01:00
Michal Čihař
a0a0a04404 Update jQuery UI to 1.12.1
Issue #12447

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 14:14:36 +01:00
Michal Čihař
f792f294f2 Disable setup if configuration already exists
The setup allows to figure out quite a lot about system and network, so
it's safer to block access to it once phpMyAdmin has been configured.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 11:36:32 +01:00
Michal Čihař
257e65ba9f Use https for outbound links where applicable
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:19:13 +02:00
Michal Čihař
ed96969ff9 Merge branch 'QA_4_5' 2016-01-28 09:23:27 +01:00
Madhura Jayaratne
5aee503564 Fix path disclosure, items 1.4.x, 1.5 and 1.6
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-01-19 10:22:30 +11:00
Michal Čihař
c6939e9e50 Update jQuery UI to 1.11.4
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-08 13:06:11 +01:00
Michal Čihař
5f3875f0c1 Upgrade jQuery to 2.1.4
Issue #11833

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-08 12:33:22 +01:00
Marc Delisle
a723e049eb In /setup, PMA_messages is not defined
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-05-24 08:39:05 -04:00
Madhura Jayaratne
d6afe6ccf6 bug #4899 [security] CSRF vulnerability in setup
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-13 11:28:19 -04:00
Madhura Jayaratne
982a5bce73 Update jquery-ui to version 1.11.2
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-05 13:12:54 +05:30
Madhura Jayaratne
80f4bb9782 Update jquery to version 1.11.1
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-12-05 08:09:02 +05:30
Michal Čihař
2456af7a01 Remove no longer used JSON plugin for jQuery
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-19 12:33:46 +01:00
Marc Delisle
c6e692c1dd Fix coding style 2013-09-22 07:36:38 -04:00
Michal Čihař
09917e0dec Include minified versions JS in git of jQuery and jQuery-UI 2013-06-24 15:03:41 +02:00
Rouslan Placella
9b0dbbddea Upgraded jquery json plugin to v2.4 2012-12-20 18:42:51 +00:00
Rouslan Placella
501e3a9f2c Upgraded jquery and jquery-ui 2012-12-19 14:50:36 +00:00
Rouslan Placella
d9a6e77864 Fixed bug #3583240 - /setup: AJAX is not defined 2012-11-04 13:07:07 +00:00
Rouslan Placella
07c7b29f48 Fixes for disabling the response 2012-06-11 14:06:03 +01:00
Rouslan Placella
a054562100 PMA_Footer and PMA_Header no longer need to be singletons 2012-06-11 14:06:03 +01:00