Commit Graph

137 Commits

Author SHA1 Message Date
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
bf49480160
Populate relation Session with RelationParameters class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:15 -03:00
Maurício Meneghini Fauth
aaee7961c1
Remove Template dependency from Relation class
Related to 2299a62e49.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
e936cad542
Add basic test for Table\OperationsController class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-01 11:47:19 -03:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
00cb1b3668
Extract IndexesController::doSaveData method
Creates the Table\Indexes class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 14:38:44 -03:00
Maurício Meneghini Fauth
fb257e5922
Extract actions from Table\StructureController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09 13:48:07 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
William Desportes
2c28a715b4
Add methods to DbiDummy and AbstractTestCase to control changing databases
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-24 02:01:00 +02:00
William Desportes
8f77a9f29d
Ref #15247 - Remove defined('TESTSUITE') from ReplaceController and remove an exit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:14 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
William Desportes
3112321d26
Remove static from SearchControllerTest::testGetDataRowAction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-16 02:03:28 +02:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
b4f3a2c8aa
Fix some failing PHPUnit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-02 14:53:17 -03:00
Maurício Meneghini Fauth
5b2957bdc1
Add a redirection after dropping a column
Instead of loading the page in the same action, redirect to the table
structure page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-07 11:24:12 -03:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
William Desportes
7bd3ec6b35
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 21:25:54 +01:00
William Desportes
69e7436aef
Edit the test for #16708 to cover more code and have better assertions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 21:19:09 +01:00
William Desportes
13fdc3e099
Add tests for #16708
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 19:30:14 +01:00
William Desportes
f1ad006701
Fix a failing test when using phpunit filter
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-06 19:12:43 +01:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:25:34 +01:00
William Desportes
3dad3b5e5d
Merge #15912 - Fix #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL
Issue: #14953
Pull-request: #15912
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-13 23:47:33 +01:00
William Desportes
50e900a1bf
Remove all @test annotations
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-08 23:01:26 +01:00
William Desportes
ea10267882
Fix tests after feature
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-05 15:50:43 +01:00
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 12:53:03 -03:00
William Desportes
777dcb2e60
Fix coding standard issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 18:13:35 +02:00
William Desportes
01d8979136
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 18:00:06 +02:00
William Desportes
34a8dfb6b1
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 17:56:52 +02:00
William Desportes
b5654b02df
Fix failing tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 17:36:59 +02:00
Maurício Meneghini Fauth
405b6277e7 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-10 14:16:25 -03:00
Petr Duda
1086b2a6ee Fix #12961 Indexes shown at both tbl_structure and tbl_relation
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-09-13 19:31:59 +02:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00