gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
90,029 Commits 12 Branches 481 Tags 2.4 GiB
9f8615dfb4
Commit Graph

189 Commits

Author SHA1 Message Date
Jeff Chan
896fe8169a Fix PMA_arrayWalkRecursive to ensure single pass thru keys 
Fix a bug with PMA_arrayWalkRecursive that causes it to apply a function
to its keys/values more than once. A previously incorrect test is fixed
as well.

The bug happens because when keys are modified, PHP's foreach loops
through the new keys again. This does not usually happen unless the
iterating array is passed through by reference (or has refcount=1).
See: http://stackoverflow.com/a/14854568/791890

Please see #936 for full explanation.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
 2014-02-17 03:09:34 +00:00
Madhura Jayaratne
61338c4859 Remove trailing whitespaces 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2014-02-08 12:38:37 +05:30
Marc Delisle
0034680de8 Fix coding style 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2014-02-07 12:45:24 -05:00
Dhananjay
0a18d86059 Fix for bug#4237. 
Signed-off-by: Dhananjay <dhananjaynakrani@gmail.com>
 2014-02-07 11:56:46 +05:30
Marc Delisle
dd7ddbfd78 Merge branch 'QA_4_1' 2013-12-31 09:03:24 -05:00
Jørgen Thomsen
ccd65816b8 bug #3840 (additional fix) When exporting to gzip format, the data is compresses 2 times 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2013-12-31 09:02:16 -05:00
Hugues Peccatte
008b1fa8d3 Rewrite to decrease number of nested levels. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2013-12-07 22:16:16 +01:00
Hugues Peccatte
2274453717 Minor PHPDoc modifications. 2013-12-07 19:00:53 +01:00
Marc Delisle
1a0eff3a9c Fix typos 2013-11-12 07:16:20 -05:00
Hugues Peccatte
464ec23ad8 Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
Madhura Jayaratne
184316d891 Coding style fixes 2013-11-03 19:00:41 +05:30
Piotr Przybylski
a67e41a646 Refactored ConfigFile class so that it is no longer a singleton 
Fixes bug #4123 Double config including
 2013-11-03 12:54:20 +01:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
ccc186e876 Load gettext without setup for errors 
This pulls in definition of other functions than __ so that any messages
would work.
 2013-08-06 15:07:35 +02:00
Michal Čihař
9310e76a0e Fix indentation 2013-07-30 13:23:51 +02:00
Marc Delisle
957a204c5a Fix typos 2013-07-23 07:12:44 -04:00
Michal Čihař
5e6d3eaa53 Whitespace cleanup 2013-06-11 08:59:58 +02:00
Madhura Jayaratne
3dd99512f0 These constants are better as a part of DatabaseInterface class 2013-05-26 21:15:24 +05:30
Madhura Jayaratne
650a8cdda3 Convert database interface to a class 2013-05-24 17:30:59 +05:30
Kasun Chathuranga
556bcb9f9d PMA_DBI_num_rows --> PMA_DBI_numRows 2013-05-04 08:39:43 +05:30
Kasun Chathuranga
1c884f0cca PMA_DBI_free_result --> PMA_DBI_freeResult 2013-05-04 08:33:49 +05:30
Kasun Chathuranga
d933575811 PMA_DBI_try_query --> PMA_DBI_tryQuery 2013-04-30 23:05:18 +05:30
Dieter Adriaenssens
afcf4ec7e0 add comment why variables are still needed 2013-01-27 16:55:05 +01:00
Dieter Adriaenssens
0a3953d26b Revert "remove unused variables" 
This reverts commit cb9e34d42a.

-> $error_header, $lang and $dir are used in the included file
libraries/error.inc.php
 2013-01-27 16:52:22 +01:00
Dieter Adriaenssens
cb9e34d42a remove unused variables 2013-01-24 17:31:07 +01:00
Dieter Adriaenssens
f07573e28a improve coding style 2013-01-15 19:54:37 +01:00
Marc Delisle
0fb7b5907d Fix merge conflicts 2013-01-15 12:50:14 -05:00
Marc Delisle
373a7a025e bug #3599362 [core] Double-escaped error message 2013-01-15 12:42:04 -05:00
Rouslan Placella
714c3be0c2 PMA_Messages can be added directly to the response 2012-11-26 23:13:08 +00:00
Michal Čihař
7ba44d3530 Define fake __ function in case of gettext is not loaded for fatal error 2012-11-01 09:11:14 +01:00
Rouslan Placella
acdd33c2ab Respond with a properly encoded JSON message on fatal error 2012-10-30 20:07:01 +00:00
Chanaka Indrajith
6971295e96 Renamed PMA_CommonFunctions::getInstance()-> with PMA_Util:: 2012-09-16 14:41:47 +05:30
Michal Čihař
f57b66b57d Do not use gettext for list of PHP manual translations 2012-09-06 11:47:45 +02:00
Michal Čihař
1146ee9e77 Do not use gettext for list of PHP manual translations 2012-09-06 11:43:55 +02:00
Michal Čihař
90b628a809 Various coding style improvements 2012-09-05 15:48:33 +02:00
Chanaka Indrajith
a76cd76ced PMA_mimeDefaultFunction() function moved back to PMA_DisplayResults class 2012-06-30 22:24:56 +05:30
Chanaka Indrajith
39d37fafcc Resolved conflicts 2012-06-27 21:53:59 +05:30
Michal Čihař
6a4ac7ef32 Do not emit headers when running testsuite 2012-06-25 12:17:33 +02:00
Chanaka Indrajith
766466135e Implement class behavior of common.lib.php file 2012-06-22 23:38:33 +05:30
Chanaka Indrajith
8dfb964cdf Introduce PMA_CommonFunctions class 2012-06-17 08:34:28 +05:30
Rouslan Placella
1f7daca600 Dropped PMA_includeJS() in favor of the PMA_Scripts class 2012-06-11 14:06:04 +01:00
Rouslan Placella
d9bedbd75e Finished integrating the PMA_Footer class 2012-06-11 14:06:03 +01:00
Rouslan Placella
a054562100 PMA_Footer and PMA_Header no longer need to be singletons 2012-06-11 14:06:03 +01:00
Rouslan Placella
372335a8ca Removed some references to the non-existent header.inc.php file 2012-06-11 14:06:02 +01:00
Rouslan Placella
4a740376c8 Dropped header.inc.php in favor of the PMA_Header class 2012-06-11 14:06:02 +01:00
Madhura Jayaratne
e1a4f227fd Fix function name: PMA_get_real_size -> PMA_getRealSize 2012-06-01 21:58:59 +05:30
Madhura Jayaratne
3849390b8b Fix function name: PMA_array_merge_recursive -> PMA_arrayMergeRecursive 2012-06-01 21:57:07 +05:30
Madhura Jayaratne
d51ed9835c Fix function name: PMA_no_cache_header -> PMA_noCacheHeader 2012-06-01 21:54:24 +05:30
Madhura Jayaratne
10510e16b4 Fix function name: PMA_download_header -> PMA_downloadHeader 2012-06-01 21:52:30 +05:30
Madhura Jayaratne
381ae7b85a Fix function name: PMA_array_read -> PMA_arrayRead 2012-06-01 21:46:31 +05:30