Commit Graph

250 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
86798ec45e
Refactor PhpMyAdmin\Plugins::getChoice method
Extracts the getDefault method from the getChoice method and adds a
getName method to the Plugin interface.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-27 13:38:01 -03:00
Maurício Meneghini Fauth
84d175b282
Extract HTML from Plugins::getChoice method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 15:29:43 -03:00
Maurício Meneghini Fauth
7a4536d4d6
Remove PhpMyAdmin\Twig\PluginsExtension class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 11:00:21 -03:00
William Desportes
9373c8ec70
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 14:51:35 +02:00
William Desportes
d281dcc0bd
Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-22 12:59:54 +02:00
William Desportes
587536b766
Remove non used variables
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 02:13:27 +02:00
Josep Sanz
de1c381f23
Add suport to the Mroonga engine: with this patch you can see the size
of the Mroonga's tables

Apply an optimization suggested

In reality, I have applied 2 optimizations, the first consists in filter by the object type as @williamdes suggested to me and the second is because we don't need to store all data of each mroonga object, we only need the name of the object that is used to compare with the tables names, thanks @williamdes by the optimization idea

Signed-off-by: Josep Sanz <josep.sanz@saltos.org>
2021-07-11 21:22:06 +02:00
Maurício Meneghini Fauth
e8c28d1883
Remove some globals from Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1129b68d29
Refactor PhpMyAdmin\Plugins::getPlugin method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-25 17:40:20 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
674bf8f97c
Remove db, table and dbi globals from Tracking class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-26 16:40:05 -03:00
Maurício Meneghini Fauth
011915fe7b
Add the redirect method to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-07 12:23:26 -03:00
William Desportes
e1bf2b1ef9
Fix possible PHP errors on MultiTableQueryController
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 00:41:08 +02:00
William Desportes
a4bcd1cfc4
Move DBI getForeignKeyConstrains method to controller
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 00:19:02 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
b4effdd7f9
Rename Database\StructureController vars to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 13:34:05 -03:00
William Desportes
38422023c5
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-27 01:55:59 +01:00
William Desportes
702a9a444d
Fix "Undefined index: target_db" reported on the error reporting server
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-27 01:10:46 +01:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-24 19:39:28 -03:00
William Desportes
4bb090b4a7
Remove the md5.js library
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-24 13:13:35 +01:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 01:13:58 +01:00
Saksham Gupta
04d72a8291 Fix #16703 No SQL option on Export of rows from a table
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add null fallback

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Update yarn.lock
2021-03-22 22:34:06 +05:30
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
Maurício Meneghini Fauth
c0e85ed76c
Add flash message support for db structure controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-20 18:56:35 -03:00
Maurício Meneghini Fauth
15d6b45a15
Remove jQuery Fullscreen plugin dependency
Uses the Fullscreen API instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-11 14:10:55 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
0c4595bc04
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 16:35:57 +01:00
William Desportes
0a1dd4cf00
Fix a coding standard mistake
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 13:24:47 +01:00
William Desportes
4fb7646aad
Fix #16657 - load database/qbe.js at all times
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 03:22:32 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
c2bec44e23
Fix an error found by PHPStan
Cherry-pick: 89b09159d0

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-13 23:06:14 +01:00
Maurício Meneghini Fauth
a1d1ab85cb
Split rte.js into routines.js, triggers.js and events.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-11 17:02:50 -03:00
Maurício Meneghini Fauth
89dba07132
Remove rte.js dependency from navigation.js
Only loads the rte.js file for the RTE pages.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-10 12:43:12 -03:00
Maurício Meneghini Fauth
89b09159d0
Fix an error found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-06 16:59:04 -03:00
Paul Gomez
23e23e3b3b
Added "Build Query" button to Visual Query Builder #16485
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
2020-12-31 23:22:50 +01:00
Maurício Meneghini Fauth
3c6955fed5
Move tables export to Database\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-06 14:08:36 -03:00
William Desportes
ed0c44a621
Update files to follow new coding standard rules
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-16 19:36:52 +01:00
Maurício Meneghini Fauth
0a4b10ba5e
Remove toggle button generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-14 13:17:03 -03:00
Maurício Meneghini Fauth
c11e8d5f64 Remove Common::database method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:56:58 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
3c49539a98 Extract db collation handler from Common class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
36d93cf2f9 Remove Common::table method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00