gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
122,413 Commits 12 Branches 481 Tags 2.4 GiB
a2ed4dfe68
Commit Graph

43 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
5b2957bdc1
Add a redirection after dropping a column 
Instead of loading the page in the same action, redirect to the table
structure page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 11:24:12 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit 
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:25:34 +01:00
William Desportes
50e900a1bf
Remove all @test annotations 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-08 23:01:26 +01:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
Petr Duda
1086b2a6ee Fix #12961 Indexes shown at both tbl_structure and tbl_relation 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-09-13 19:31:59 +02:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes 
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
 2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 18:30:57 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true} 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 02:12:36 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:45:50 +02:00
William Desportes
bb0bc3bb93
Merge #16131 - Unit test suite improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 23:32:11 +02:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-21 15:29:36 -03:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action 
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 11:21:42 -03:00
William Desportes
947f9ad04f
Remove some unused code detected by codacy 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:57:22 +02:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller 
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 15:02:28 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534) 
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
 2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
5c519cc819 Remove old DI container in Table\StructureControllerTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 14:51:54 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271) 
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-06-01 15:13:41 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-19 01:54:44 +02:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
b97460a320 Rename TableStructureController to StructureController 
Renames PhpMyAdmin\Controllers\Table\TableStructureController to
PhpMyAdmin\Controllers\Table\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-14 16:30:49 -02:00