Commit Graph

782 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
282fbe76c5
Fix case where $_SERVER['REQUEST_METHOD'] is undefined
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/16991

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-05 17:23:32 -03:00
William Desportes
535b374163
Fix "Undefined index: clause_is_unique" on replace value in cell
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 18:27:38 +02:00
William Desportes
590a450a47
Fix possible "Undefined index: output_format" on export
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 12:15:02 +02:00
William Desportes
1bd76fc474
Ref #16977 - Fix selected value for enum get values route
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-23 13:31:21 +02:00
William Desportes
897f07d50d
Implement error management for #16977
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-23 13:18:40 +02:00
William Desportes
f09ead5e07
Fix code using relative path
if (chdir('/tmp') === false) {
    die('Could not change dir');
}

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-15 22:24:30 +02:00
William Desportes
a2a8c1bc6c
Add l10n notes for new message and context for messages added for #14130
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-29 15:56:44 +02:00
William Desportes
ce7929fcb9
Update comments and fix a typo
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-29 15:55:48 +02:00
Maurício Meneghini Fauth
7959ea51aa
Merge pull request #16893 from shucon/fix_16888
Fix #16888 - JS error on renaming tables in saved Designer page
2021-05-28 18:43:07 -03:00
Maurício Meneghini Fauth
0d51bfc8e3
Merge pull request #16899 from quinnzipse/QA_5_1
Fix #14130 - Created new messages for U2F errors
2021-05-28 14:14:32 -03:00
Quinn Zipse
6d39aa0fee
Created new error codes
Signed-off-by: Quinn Zipse <qzipse@outlook.com>
2021-05-12 15:30:22 -05:00
William Desportes
ef758ae43d
Merge #16855 - Replace secure.php.net with www.php.net and remove Polish and Persian
Pull-request: #16855

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-10 23:30:25 +02:00
Saksham Gupta
8dc94c405b Fix #16888 : JS error on renaming tables in saved Designer page
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Quality fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-05-09 22:45:14 +05:30
William Desportes
2ccf568132
Fix #16871 - normalization step 2 errors
Fixes: #16870

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 23:36:05 +02:00
William Desportes
7631561b16
Fix #16871 - normalization errors
Fixes: #16870

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 22:50:47 +02:00
William Desportes
34f8295b94
Fix #16854 - Undefined index: SERVER_SOFTWARE
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-27 23:57:30 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
William Desportes
45aeee579a
Fix #14773 - export raw query is not working
Ref: #15064 (issue to track the export raw query feature)
Yes, this issue was closed with #15064 but I will close it anyway because it made sense as the feature was broken once more
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-23 17:46:26 +02:00
liviuconcioiu
6dc79009f7
Fix #16810 - SQL query shown twice
Fix SQL query shown twice on PRIMARY, UNIQUE, INDEX, SPATIAL, FULLTEXT, add to central columns, remove from central columns

Signed-off-by: Liviu Concioiu <liviu.concioiu@gmail.com>
2021-04-23 03:05:46 +02:00
William Desportes
f741d7b6c1
Merge #16809 - Fix #16404 - Password generation fix after new user creation failure
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:11:55 +02:00
William Desportes
ec4df90ab6
Merge #16811 - Fix #16810 - Fix SQL query shown twice on drop
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 19:19:30 +02:00
William Desportes
deac7cffde
Fix not working export to PNG, SVG, PDF on GIS visialization
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-17 00:28:38 +02:00
Saksham Gupta
9a9b7ad335 Fix #16404 Password generation fix after new user creation failure
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Check error on SQL query

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Lint fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comments

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-15 20:34:35 +05:30
William Desportes
b78f8a094c
Fix #16790 - Undefined index field_name
Unable to reproduce, adding a safety will make the code run properly.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-12 22:31:37 +02:00
Saksham Gupta
db5fc3fd7f Fix #16810 Fix SQL query shown twice on drop
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-04-12 23:20:48 +05:30
William Desportes
700108ba90
Add missing stickfill script on zoom search
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-01 18:31:53 +02:00
William Desportes
a3e725a347
Fix reported PHP notices on export save preview
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-31 00:57:00 +02:00
William Desportes
aa0c22959d
Fix PHP warnings on the server status data not set
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-31 00:44:34 +02:00
William Desportes
702a9a444d
Fix "Undefined index: target_db" reported on the error reporting server
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-27 01:10:46 +01:00
Saksham Gupta
04d72a8291 Fix #16703 No SQL option on Export of rows from a table
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add null fallback

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Update yarn.lock
2021-03-22 22:34:06 +05:30
William Desportes
25d8f98ec5
Fixed an undefined index notice on export
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-20 18:45:41 +01:00
Markus Staab
11943fd0d2
translation: mention the correct mysql setting in 'Opened_tables' explanaition 2021-02-27 07:47:06 +01:00
William Desportes
6be33c4eb6
Ref #16666 - Ref #16424 - Adjust the index like the zoom controller
Even if this is not needed, better that it is the same in the 2 controllers

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-19 00:42:01 +01:00
William Desportes
4df8cd0b3c
Merge #16666 - Fix #16424 - Numerical search in table and zoom
Pull-request: #16666
Fixes: #16424

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-19 00:27:50 +01:00
Saksham Gupta
4da866ed94 Fix #16424 - Numerical search in table and zoom
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fixes #16667

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment and change variable name

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-02-19 00:33:10 +05:30
William Desportes
0a1dd4cf00
Fix a coding standard mistake
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 13:24:47 +01:00
William Desportes
4fb7646aad
Fix #16657 - load database/qbe.js at all times
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 03:22:32 +01:00
William Desportes
4d4acee8a0
Fix missing message on upload message request after failure creates a warning
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-12 00:12:02 +01:00
William Desportes
9f5e09d0c2
Fix go back URL after import not using the right separator
And update a regex to validate URLs

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-12 00:12:02 +01:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:25:34 +01:00
William Desportes
ed36df4116
Fix "Uncaught TypeError: Argument 1 passed to PhpMyAdmin\Core::downloadHeader()"
Fatal error: Uncaught TypeError: Argument 1 passed to PhpMyAdmin\Core::downloadHeader() must be of the type string, null given,
called in libraries/classes/Controllers/TransformationWrapperController.php on line 171 and defined in 
libraries/classes/Core.php:617 Stack trace: #0 
libraries/classes/Controllers/TransformationWrapperController.php(171): PhpMyAdmin\Core::downloadHeader(NULL, 'application/oct...') #1 
libraries/classes/Routing.php(92): PhpMyAdmin\Controllers\TransformationWrapperController->index(Array) #2 
index.php(18): PhpMyAdmin\Routing::callControllerForRoute('/transformation...', Object(FastRoute\Dispatcher\GroupCountBased), Object(Symfony\Component\DependencyInjection\ContainerBuilder)) #3 {main} thrown in 
libraries/classes/Core.php on line 617

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-23 00:03:55 +01:00
Florian Schirmer
fec6d65d96
Fix BLOB JPG preview thumbnail
Signed-off-by: Florian Schirmer <jolt@tuxbox.org>
2021-01-22 23:43:50 +01:00
Maurício Meneghini Fauth
c2bec44e23
Fix an error found by PHPStan
Cherry-pick: 89b09159d0

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-13 23:06:14 +01:00
Paul Gomez
23e23e3b3b
Added "Build Query" button to Visual Query Builder #16485
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
2020-12-31 23:22:50 +01:00
William Desportes
b826234ebb
Fix #16526 - Fatal error: Uncaught TypeError: preg_replace(): Argument #3 ($subject)
Fatal error: Uncaught TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, null given in libraries/classes/Controllers/Setup/HomeController.php:30 

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-11 21:05:06 +01:00
Maurício Meneghini Fauth
dbaa031971
Remove jquery.sortableTable.js from js/vendor dir
It is not a vendor file, but a internal file.
Added by commit 1c6a388ca0.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-08 21:37:11 -03:00
William Desportes
35cdaf4356
Fix #16512 - Add some code securities when the themes folder does not exist
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 15:02:06 +01:00
William Desportes
2141d81e7e
Fix #16520 - $cfg['ShowDatabasesNavigationAsTree'] = false; on select not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 14:35:05 +01:00
Maurício Meneghini Fauth
3c6955fed5
Move tables export to Database\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-06 14:08:36 -03:00
Maurício Meneghini Fauth
acd214c9b7
Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:58:18 -03:00