Commit Graph

372 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
94483dd4b9 Extract the HTML from Table\TrackingController::index
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-14 17:13:34 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
e6ec9df84e Remove DBI dep from Controllers/AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
405b6277e7 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-10 14:16:25 -03:00
Isaac Bennetch
93c93bc9ee Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-10-09 22:14:49 -04:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
aecdfc80cb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-04 00:29:04 +02:00
Petr Duda
661af18061 Fix #16377 Uncaught ReferenceError: Stickyfill is not defined
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-10-01 21:39:49 +02:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
ea163ffcae Move CentralColumns to the Database namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 10:14:22 -03:00
Petr Duda
1086b2a6ee Fix #12961 Indexes shown at both tbl_structure and tbl_relation
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-09-13 19:31:59 +02:00
Maurício Meneghini Fauth
5aa2856f7f Remove Util::buildActionTitles and the titles global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 22:50:08 -03:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 13:32:25 -03:00
Maurício Meneghini Fauth
37289a57b2 Remove url_query and url_params from Table/StructureController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-07 14:24:41 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
bade581161 Check if multi table maintenance is disabled
Checks if $cfg['DisableMultiTableMaintenance'] is true.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 16:07:35 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
3b02872cd3 Create the Table\Maintenance class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 00:35:13 -03:00
Maurício Meneghini Fauth
46f28b42c9 Extract the Table\MaintenanceController class
Extracts the table maintenance action methods from
the Database\StructureController class to the
new Table\MaintenanceController class and adjust templates
and routes names.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-27 23:33:43 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-27 14:22:22 -03:00
Maurício Meneghini Fauth
55c5c80d37 Rename Display\ImportAjax class
Renames to Import\Ajax.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 12:07:54 -03:00
Maurício Meneghini Fauth
fa67657b1a Remove Display\Import class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 00:21:26 -03:00
Maurício Meneghini Fauth
28436399dd Extract exit from Display\Import class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 02:28:02 -03:00
Maurício Meneghini Fauth
65b79af29e Refactor Plugins::getPlugins method
Replaces parameters with explicit methods.
 - Plugins::getExport
 - Plugins::getImport
 - Plugins::getSchema

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 01:40:27 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc Extract HTML from server, db and table export controllers
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
e26bde7e96 Fix coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-24 20:33:47 -03:00
William Desportes
47c70dacc7
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-23 19:57:46 +02:00
William Desportes
fe9e7ba89d
Fix #16255 - Tinyint(1) shown as INT in search page
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-23 19:53:52 +02:00
Maurício Meneghini Fauth
7b958b874f Create ExportTemplateController class
Extracts export templates handling from Display\Export class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 16:27:37 -03:00
Maurício Meneghini Fauth
e5328434bf Extract response from Operations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-14 20:18:03 -03:00
Maurício Meneghini Fauth
858e8dc666 Extract template render from ColumnsDefinition::displayForm
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 17:21:36 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee Remove Config\PageSettings::showGroup method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
918b1f38c6 Change return type of Sql::executeQueryAndSendQueryResponse
Remove Response::addHTML call.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a3147c26e1 Extract exit; from Core::previewSQL method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-09 16:20:41 -03:00
William Desportes
06ffb871b4
Merge branch 'QA_5_0' and sync Search controllers
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-07 15:00:47 +02:00
Ankush Patil
69d49789ce
Fixes #16248: identifying searchType in validation function
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
2020-07-07 13:57:23 +02:00
Maurício Meneghini Fauth
d09ab9bc9d Check where clause signature in TableSearchController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-03 17:45:58 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
William Desportes
e89b02c08d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-24 09:07:17 +02:00
William Desportes
40d01944a3
Fix #16088 - Do not add axis switch on MariaDB
Ref: 969f43c82b

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-22 21:56:56 +02:00
Maurício Meneghini Fauth
41d401b95e Extract save action from table structure index method
Closes #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 19:57:28 -03:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 18:20:48 -03:00