Commit Graph

21880 Commits

Author SHA1 Message Date
Liviu-Mihail Concioiu
82396c4f76 Fix wrong encoding of db group names
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-07-01 08:08:44 +02:00
Maurício Meneghini Fauth
5f7499abb0
Fix profiling chart not loading when profiling is activated
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-17 15:26:19 -03:00
Maurício Meneghini Fauth
7b88ab16af
Fix a case where a fatal error message was not displayed
A fatal error message was not displayed when the ResponseRenderer object
already had some HTML, because the output buffer is only displayed when
there is no HTML.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-03 17:01:51 -03:00
Maurício Meneghini Fauth
64eceff4f9
Fix state times not getting summed in the profiling table
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-02 16:31:10 -03:00
Maurício Meneghini Fauth
578dbb301c
Fix SQL statement not being displayed correctly on RTL languages
Fixes #18471

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 12:48:34 -03:00
Maurício Meneghini Fauth
3f587ccce4
Improve unit test for ResponseRenderer::setAjax()
Also tests the setAjax() method of Header, Footer and Console classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 00:26:48 -03:00
Maurício Meneghini Fauth
50bca5c1cb
Fix duplicate query params in the SQL message card
Adds tests for the Html\Generator::getMessage() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-17 16:06:36 -03:00
Maurício Meneghini Fauth
5ed8e65b90
Fix list of users of an user group not showing up
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-08 16:56:47 -03:00
Maurício Meneghini Fauth
6875680de9
Fix double encoding on User Groups pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-07 17:52:26 -03:00
Liviu-Mihail Concioiu
175d01f0e0 Add CVE link to allowed domains
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-05-06 01:07:04 +02:00
Liviu-Mihail Concioiu
4951bc7fea Update CVE link with the new one
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-05-06 01:06:11 +02:00
Liviu-Mihail Concioiu
e4615acccf Revert "Add CVE MITRE link to allowed domains"
This reverts commit 8c068dda1d.
2023-05-06 01:04:17 +02:00
Liviu-Mihail Concioiu
8c068dda1d Add CVE MITRE link to allowed domains
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-05-05 22:50:41 +02:00
William Desportes
4a5180c901
Merge #18252 - Fix #17654 - Unprivileged user cannot change password on MySQL >= 5.7.37
Pull-request: #18252
Fixes: #17654

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-04 18:47:24 +02:00
William Desportes
99881debb5
Fix lint route not working correctly
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-22 14:52:35 +02:00
William Desportes
a88c9a3dc0
Fix functions/routines modal contents truncated
Related to 5a2baf607f
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-22 14:52:14 +02:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
8c7c87f524
Merge pull request #18308 from win20/navigation-panel-settings-icon-issues
Fix issues with settings icon in nav panel
2023-04-12 16:17:48 -03:00
MoonE
0ff3f10134
Fix editing GEOMETRYCOLLECTION EMPTY (#18189)
* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-08 15:12:40 -03:00
Maurício Meneghini Fauth
d0997e0377
Merge pull request #18188 from MoonE/qa-fix-gis-insert-form
Fix inserting gis-data via insert/edit form
2023-04-08 15:09:44 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-08 13:42:44 +02:00
Kamil Tekiela
e7717ed186 Fix bug preventing disabling tracking feature
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-03 12:22:31 +01:00
Win Barua
a067418124 Fix issues with settings icon in nav panel
- settings icon still shows in 2FA in all themes.
- bootstrap theme still shows settings icon on all settings tabs.

Signed-off-by: Win Barua <win.barua2@gmail.com>
2023-04-01 14:47:50 +01:00
Maurício Meneghini Fauth
ee9c9a0300
Merge pull request #18297 from kamil-tekiela/measure-time-only-for-user-queries
Measure time only for user queries
2023-03-30 10:23:36 -03:00
Maximilian Krög
c5343eeed9 Fix gis extent calculation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-29 21:14:40 -03:00
Kamil Tekiela
ef0ea05a8f Measure time only for user queries
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-30 00:41:38 +01:00
Maurício Meneghini Fauth
d25780fe20
Merge pull request #18255 from kamil-tekiela/Fix-ENGINE-escaping
Fix ENGINE escaping
2023-03-29 17:04:17 -03:00
Maurício Meneghini Fauth
46df80f58f
Merge pull request #18281 from kamil-tekiela/getTrackingIcon
Optimize getTrackingIcon
2023-03-29 14:14:39 -03:00
Maurício Meneghini Fauth
0301e48a27
Add ChangeLog entry for #17702
- Closes #17702

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-24 16:35:15 -03:00
Nicolas Hervouet
e4d9a1a66a
Fix for handle large number of tables in a single database (more than 10k)
getTablesFull was taking too much time, because MySQL do not have a real table where it stores all tables information.
So when it runs a query like select * from information_schema.TABLES ORDER BY Name limit 250 offset 0, MySQL has to read information about all tables to build his in memory table, then sort it by name, and then return 250 first tables.
But reading information about one table takes time, and that's why the query is very slow when you have a lot of tables.
Note that the problem is the same with 'SHOW TABLE STATUS'.

So, in order to speed up this query, we have to limit it to a small list of tables, as it, MySQL has to read table information only for few tables.
Note that SHOW TABLES is not that long, even with a large amount of tables.

The idea here is to use the result of SHOW TABLES query, to apply paging on this table list, and then to run the query on information_schema.TABLES only on tables we want.

Signed-off-by: Nicolas Hervouet <github@pico12.fr>
2023-03-24 11:55:30 -03:00
Kamil Tekiela
b5ae50454d Optimize getTrackingIcon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-22 13:07:22 +00:00
Kamil Tekiela
8550db2d11 Don't parse SQL if no tracking is in progress
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-20 16:24:35 +00:00
Kamil Tekiela
e9b9c120af Fix getTablesFull() and related tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-15 19:59:35 +00:00
Kamil Tekiela
3db245f462 Optimize export of many tables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-15 19:59:35 +00:00
Kamil Tekiela
d7f599df00 Accept table with name 0 in getTablesFull
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-14 22:11:05 +00:00
Kamil Tekiela
282dc9a27e Fix a bug with numerical table name
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-14 21:35:10 +00:00
Kamil Tekiela
e0e3748723 Fix ENGINE escaping
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-13 11:58:15 +00:00
William Desportes
af4852b228
Fix #17654 - Unprivileged user cannot change password on MySQL >= 5.7.37
Fixes: #17654

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-03-12 02:53:02 +01:00
William Desportes
ae355d99b1
Merge #18177 - Fix "IS NULL" is shown for non-nullable columns on search page
Pull-request: #18177

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-03-10 15:58:02 +01:00
Yuval Haor Noga
b305ec30fa
Ref #16451 - Increase max password length from 1000 to 2000
Signed-off-by: Yuval Haor Noga <yuvalhnoga@gmail.com>
2023-03-10 15:45:30 +01:00
Maurício Meneghini Fauth
29c7705e80
Merge pull request #18197 from kamil-tekiela/Fix-warning-on-non-existent-table
Fix warning on non-existent table
2023-03-08 10:10:28 -03:00
Maurício Meneghini Fauth
12b924d4e3
Fix wrong time zone when handling Git information
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-04 11:55:29 -03:00
Kamil Tekiela
80d7f0dfa3 Fix warning on non-existent table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-02 16:23:07 +00:00
Maximilian Krög
89bcefeadb
Fix inserting gis-data via insert/edit form
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-01 22:40:09 +01:00
Kamil Tekiela
7b20f58a0c Bug: IS NULL is shown for non-nullable columns
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-27 23:17:53 +00:00
William Desportes
f3aa3639b3
Remove chdir from GitTest after fixing #18112
Ref: d9a6f82bc1

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-26 23:57:54 +01:00
William Desportes
d9a6f82bc1
Fix #18112 - open base dir warning on git version class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-26 23:31:28 +01:00
Kamil Tekiela
aa63c6821a Fix bug related to tables with numerical names
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-22 13:18:06 +00:00
William Desportes
496bd0f3d0
Remove non used code of explain button (Generator::generateRowQueryOutput)
Since: f1581cfe9b

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-22 12:51:26 +01:00
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-22 12:47:59 +01:00