Commit Graph

5729 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5f7499abb0
Fix profiling chart not loading when profiling is activated
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-17 15:26:19 -03:00
Maurício Meneghini Fauth
7b88ab16af
Fix a case where a fatal error message was not displayed
A fatal error message was not displayed when the ResponseRenderer object
already had some HTML, because the output buffer is only displayed when
there is no HTML.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-03 17:01:51 -03:00
Maurício Meneghini Fauth
64eceff4f9
Fix state times not getting summed in the profiling table
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-02 16:31:10 -03:00
Maurício Meneghini Fauth
578dbb301c
Fix SQL statement not being displayed correctly on RTL languages
Fixes #18471

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 12:48:34 -03:00
Maurício Meneghini Fauth
3f587ccce4
Improve unit test for ResponseRenderer::setAjax()
Also tests the setAjax() method of Header, Footer and Console classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 00:26:48 -03:00
Maurício Meneghini Fauth
b9084615f6
Fix execute routine page not working when not in a modal
Fixes #18441

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-30 15:00:22 -03:00
Maurício Meneghini Fauth
746a34c009
Fix the actions not being hidden in the Triggers, Routines, Events pages
Fixes #17392

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-29 16:46:42 -03:00
William Desportes
4504fe0866
Fix a testing warning
1) Warning
Test method "testOrSkip" in test class "PhpMyAdmin\Tests\Http\Factory\ServerRequestFactoryTest" is not public.

phpvfscomposer:///vendor/phpunit/phpunit/phpunit:60
vendor/bin/phpunit:118

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 12:11:58 +02:00
Maurício Meneghini Fauth
50bca5c1cb
Fix duplicate query params in the SQL message card
Adds tests for the Html\Generator::getMessage() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-17 16:06:36 -03:00
Maurício Meneghini Fauth
5ed8e65b90
Fix list of users of an user group not showing up
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-08 16:56:47 -03:00
Maurício Meneghini Fauth
6875680de9
Fix double encoding on User Groups pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-07 17:52:26 -03:00
Maurício Meneghini Fauth
5a2baf607f
Fix ExportSqlTest failing test
Related to https://github.com/phpmyadmin/sql-parser/pull/438

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-19 18:32:51 -03:00
Maurício Meneghini Fauth
3e7cf7cfab
Fix failing RelationTest test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 16:35:28 -03:00
Maurício Meneghini Fauth
d464a8d081
Fix GisDataEditorControllerTest namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-11 23:03:24 -03:00
MoonE
0ff3f10134
Fix editing GEOMETRYCOLLECTION EMPTY (#18189)
* Test editing empty geometry collection

- 'GEOMETRYCOLLECTION()'
- 'GEOMETRYCOLLECTION EMPTY'

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Fix editing GEOMETRYCOLLECTION EMPTY

Instead of searching for first parenthesis look for word end.
Parsing was and is somewhat unsafe, though it works with the data
received from ST_AsText.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

---------

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-08 15:12:40 -03:00
Maurício Meneghini Fauth
d0997e0377
Merge pull request #18188 from MoonE/qa-fix-gis-insert-form
Fix inserting gis-data via insert/edit form
2023-04-08 15:09:44 -03:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-08 13:42:44 +02:00
William Desportes
068fc4df74
Fix failing testGetLatestVersion in random order
I could not reproduce it, but cleared the cache just in case

Random-order-seed: 1680865303

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-07 13:07:19 +02:00
William Desportes
b3138ff282
Fix tests for relation
Ref: e0dc515638

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-07 13:02:04 +02:00
William Desportes
e0dc515638
Add tests for #18266 - unable to disable a feature
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-05 19:19:03 +02:00
Maximilian Krög
c5343eeed9 Fix gis extent calculation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-29 21:14:40 -03:00
Maurício Meneghini Fauth
d25780fe20
Merge pull request #18255 from kamil-tekiela/Fix-ENGINE-escaping
Fix ENGINE escaping
2023-03-29 17:04:17 -03:00
Maurício Meneghini Fauth
cf764231b5
Fix incomplete test
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 12:37:32 -03:00
Kamil Tekiela
e9b9c120af Fix getTablesFull() and related tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-15 19:59:35 +00:00
Kamil Tekiela
e0e3748723 Fix ENGINE escaping
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-13 11:58:15 +00:00
Yuval Haor Noga
b305ec30fa
Ref #16451 - Increase max password length from 1000 to 2000
Signed-off-by: Yuval Haor Noga <yuvalhnoga@gmail.com>
2023-03-10 15:45:30 +01:00
Maurício Meneghini Fauth
12b924d4e3
Fix wrong time zone when handling Git information
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-04 11:55:29 -03:00
Maximilian Krög
89bcefeadb
Fix inserting gis-data via insert/edit form
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-01 22:40:09 +01:00
William Desportes
f3aa3639b3
Remove chdir from GitTest after fixing #18112
Ref: d9a6f82bc1

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-26 23:57:54 +01:00
William Desportes
9743c82ba3
Write tests for #16851
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:52:40 +01:00
Kamil Tekiela
fa339143ea
Fix renaming db with a view (#18106)
* Fix renaming DB with a view

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add test for the bug

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-20 13:36:46 -03:00
Maurício Meneghini Fauth
5548c9de49
Fix issue reported by PHPStan in ConfigTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 12:05:18 -03:00
Maurício Meneghini Fauth
820e14e55c
Merge pull request #18111 from liviuconcioiu/linnks
Update links
2023-02-19 22:05:21 -03:00
William Desportes
de35195d3c
Improve testGetTempDir and testGetUploadTempDir tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-19 13:30:22 +01:00
Liviu-Mihail Concioiu
a6e0957d94 Update links
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-02-17 18:42:01 +01:00
Maurício Meneghini Fauth
10b4fb35d9
Fix coding standard issue
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-08 13:12:29 -03:00
William Desportes
9d92dafdcb
Merge #17923 - Fix #17766 - Allow to open in a new tab copy and edit row actions
Pull-request: #17923
Fixes: #17766

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-08 13:13:39 +01:00
William Desportes
2443570ce6
Merge #17851 - Fix #17028, #17683 - Re build query count management
Pull-request: #17851
Fixes: #17028
Fixes: #17683

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-08 13:12:00 +01:00
William Desportes
84aee1b13b
Add TEST_PATH for out of source tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-08 13:09:00 +01:00
Maurício Meneghini Fauth
b5a0c10687
Fix coding standard issue
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-01 21:28:02 -03:00
William Desportes
97edddf1ce
Add TEST_PATH for out of source tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-31 23:48:31 +01:00
William Desportes
e11c385d35
Add TEST_PATH for out of source tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-31 23:48:29 +01:00
Maurício Meneghini Fauth
1a81122650
Fix Psalm error related to TEST_PATH constant
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-28 14:37:51 -03:00
William Desportes
7ec4ea0e66
Add TEST_PATH for out of source tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-28 09:18:56 +01:00
William Desportes
826ca21e78
Add a group for tests that require ext-xdebug and do not run well on Debian
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-28 09:11:01 +01:00
Maurício Meneghini Fauth
5f54c3ec81
Fix failing Selenium tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-24 18:01:00 -03:00
Maurício Meneghini Fauth
b4b4c14fed
Fix failing Selenium tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-24 17:38:21 -03:00
Maurício Meneghini Fauth
5a267d0a81
Fix broken button that adds routine params
- Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17833

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-24 14:28:08 -03:00
William Desportes
725e067f6d
Fix tests after full group by changes
Ref: 305fe52d9e

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-22 01:22:50 +04:00
William Desportes
b0b3fcf83d
Fix broken tests after UUID changes
Ref: 6d482de7b8

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-22 01:19:34 +04:00