Commit Graph

563 Commits

Author SHA1 Message Date
William Desportes
aa95fff919
Fix #15776 - privileges page return http 500
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-12 22:18:44 +01:00
William Desportes
5a83a289d8
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 12:02:54 +01:00
Hugues Peccatte
df847d7121 Remove useless 'use'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-15 21:40:21 +02:00
Hugues Peccatte
a395bd2823 Remove as much as possible the old DI system
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-15 21:39:21 +02:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
05ce6ffed4 Rename js/server_*.js to js/server/*.js
Rename js/server_status_*.js to js/server/status/*.js

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 03:56:22 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Maurício Meneghini Fauth
3a7a0c6e58 Remove $url_query global from PHPStan ignored list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 22:18:58 -03:00
Maurício Meneghini Fauth
e2f66cf9e4 Remove $text_dir global from PHPStan ignored errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 16:04:16 -03:00
Maurício Meneghini Fauth
f19ab9a0b0 Remove $pmaThemeImage global from ignored errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 15:37:19 -03:00
Maurício Meneghini Fauth
45546661aa Remove $db from ignore errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 14:54:21 -03:00
William Desportes
e453ad1320
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:15:57 +02:00
William Desportes
91c758aae4
Fix #15229 - Notice - Undefined index: strPrivDescDelete versioning rowsTbl
Fixes: #15229
Adds support for delete versioning rows privilege
See: https://mariadb.com/kb/en/library/grant/#table-privileges
The privilege is named 'Delete versioning rows' in SHOW GRANTS and 'Delete_history_priv' in mysql.user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 18:42:02 +02:00
Maurício Meneghini Fauth
17195fbe72 Get $dbi from DIC instead of global in entry points
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-18 01:09:38 -03:00
Maurício Meneghini Fauth
4001839460 Upgrade PHPStan to v0.11.4
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-18 20:29:02 -03:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-22 18:18:21 -02:00
Maurício Meneghini Fauth
a1d3d334b4
Merge pull request #14855 from Tithugues/feature/reduce-nested-ifs
Reduce nested ifs
2019-01-16 02:16:38 -03:00
Hugues Peccatte
a8d801f176 Use real function names, not their aliases
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:37:52 +01:00
Hugues Peccatte
f1e140be05 Reduce nested ifs
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:06:04 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Madhura Jayaratne
35d87e6072 Retrieve parameters from $_POST in user/Privileges pages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
aeba92f982 Refactor Server/Privileges
Use dependency injection

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-16 17:00:10 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Marc Delisle
97dd156575
Improve message
Signed-off-by: Marc Delisle <marc@infomarc.info>
2018-06-29 09:55:13 -04:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
cece77d831 Refactor Server/Privileges
Replaces Template::get() with $this->template->render()

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-05 02:26:08 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
b6767f4bf8 Replace static methods with instance methods
Replaces PhpMyAdmin\Server\Privileges static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 03:09:45 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Maurício Meneghini Fauth
79f6f88bff Use template for server sub page header
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:28:00 +02:00
Maurício Meneghini Fauth
15d8ee270f Refactor relation_cleanup functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 18:14:37 -03:00
Maurício Meneghini Fauth
a2b08bae7b Refactor check_user_privileges to static methods
Refactor check_user_privileges.lib.php functions to static methods and move logic to check_user_privileges.inc.php.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-11 22:09:05 -03:00
Maurício Meneghini Fauth
f7051b2e5c Refactor server_common functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-08 00:28:06 -03:00
Maurício Meneghini Fauth
8c41df5103 Refactor server_users functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 23:45:39 -03:00
Maurício Meneghini Fauth
2217b4c960 Refactor change password function to static method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-06 21:42:18 -03:00
Madhura Jayaratne
23024a6bfb issue #13614 Fix link name and url
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2017-08-29 22:33:36 +10:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Maurício Meneghini Fauth
b803dc42dd Move server privileges to static methods
Move libraries/server_privileges.lib.php to libraries/classes/Server/Privileges.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-04 19:29:22 -03:00
Michal Čihař
41b045f130 Show warning in case user can only display privileges
Fixes #13442

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-18 14:55:24 +02:00
Michal Čihař
54466d68c6 Use Message to avoid need to specify namespace
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-18 14:55:24 +02:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00