Commit Graph

51 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
13874a6937 Fix uncaught TypeError
strlen() expects parameter 1 to be string

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-11 18:08:40 -03:00
William Desportes
bdd60af282
Fix #14457 - mb_stubstr null
Closes: #14457
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-07-07 00:58:11 +02:00
Maurício Meneghini Fauth
cf8e559987 Fix error when writing the selected rows to a file
Fix #14434

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-05 21:43:21 -03:00
William Desportes
b3379d7700
Fix - #14382 "Visualize GIS data" icon missing
Closes: #14382
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-29 00:17:15 +02:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
William Desportes
a9dce0b40e
Fixes #14370
Fixes error when mysqli::fetch_array returns NULL for 'SELECT * FROM mytable WHERE 0;'

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-10 22:23:58 +02:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 23:06:31 -03:00
Maurício Meneghini Fauth
21f75cf555 Fix TypeError on Display/Results
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-17 22:23:30 -03:00
Maurício Meneghini Fauth
267aadd4c3 Enable strict mode in Display classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 01:09:16 -03:00
Lakshay arora
9231620c2d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-05-12 03:44:58 -03:00
Madhura Jayaratne
d564bf275f Merge branch 'QA_4_8' 2018-05-08 07:11:44 +10:00
Madhura Jayaratne
e6cc4fbbbc Fix #14264 Linking for 'Distinct values' broken
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-05-08 07:10:06 +10:00
Piyush Vijay
4304a66995 Duplicate hidden token input field issue solved (#14211)
* Duplicate hidden token input fields: #14209 issue fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* duplicate hidden input for token removed from error reporting form.
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-05-03 21:47:05 -03:00
Maurício Meneghini Fauth
42d4f32d50 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-29 15:02:32 -03:00
Madhura Jayaratne
5872167dc2 Fix #14227 Relational linking broken
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-04-30 00:36:03 +10:00
Maurício Meneghini Fauth
c73e72e7ca Refactor PhpMyAdmin\Transformations static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-01 01:34:17 -03:00
Maurício Meneghini Fauth
2638eb9207 Refactor PhpMyAdmin\Export static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 19:28:25 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-27 17:39:16 -03:00
Maurício Meneghini Fauth
f45d4a566b Refactor PhpMyAdmin\Display\Export class
The static methods are replaced with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-13 23:51:16 -02:00
Michal Čihař
64476aada9 Merge branch 'QA_4_7' 2017-12-15 13:46:34 +01:00
Michal Čihař
a450d01546 Remove not needed variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 12:28:50 +01:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
f50cac4d86 Use template for _buildEmptyDisplay method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-19 00:36:22 -02:00
Maurício Meneghini Fauth
bdb35e5769 Use template for _buildNullDisplay method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-19 00:28:44 -02:00
Maurício Meneghini Fauth
70e9ec0fcd Use template for _buildValueDisplay
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 23:40:56 -02:00
Maurício Meneghini Fauth
9d79d04af7 Use template for _getCommentForRow
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 23:15:02 -02:00
Maurício Meneghini Fauth
fdf7cd75db Use template for _getFormForMultiRowOperations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 21:29:02 -02:00
Maurício Meneghini Fauth
f513738e7a Use template for _getOptionsBlock
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
dfa796be07 Use template for _getTableNavigationButton
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
1852c2c4da Use template for _getAdditionalFieldsForTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
dba5237520 Use template for _getShowAllCheckboxForTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-18 20:27:02 -02:00
Michal Čihař
f29640c5d8 Remove $strip_img parameter from Util::linkOrButton
It did not behave as documented for ages, it only influenced
whether additional text was added to the link.

Callers should use parameters to Util::getIcon to achieve this
(if it is actually needed somewhere)

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:41:27 +01:00
Michal Čihař
ad72aaecc2 Avoid passing default params to Util::linkOrButton
Do not pass optional parameters with default values.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:41:27 +01:00
Michal Čihař
50c65bc3fb Remove no longer needed $new_form from Util::linkOrButton
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:33:53 +01:00
Michal Čihař
99e47a90d9 Always define correct connection type
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
6a645a3e89 Revert "Fix alignment of action and fixed tests #12167"
This reverts commit 9b56acacab.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-03 14:02:49 +02:00
Michal Čihař
319e259b10 Revert "ChangeLog entry for #12167 and #13702"
This reverts commit 4f7c08e8ec.
2017-10-03 14:00:46 +02:00
Maurício Meneghini Fauth
f8bd078088 Fix code standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-30 18:19:09 -03:00
Maurício Meneghini Fauth
4f7c08e8ec ChangeLog entry for #12167 and #13702
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-29 22:06:04 -03:00
Maurício Meneghini Fauth
1c111bf772 Merge pull request #13702 from ankitjain28may/ankitjain28may
Fix alignment of action #12167 

Fix #12167
2017-09-29 21:38:45 -03:00
ankitjain28may
9b56acacab Fix alignment of action and fixed tests #12167
Signed-off-by: Ankit Jain <ankitjain28may77@gmail.com>
2017-09-26 01:37:02 +05:30
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
4336557e03 Rename special_schema_links.lib.php
Rename libraries/special_schema_links.lib.php to libraries/special_schema_links.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-14 12:05:17 -03:00
Maurício Meneghini Fauth
512d81cb29 Refactor display_create_table to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 09:37:02 -03:00