Commit Graph

587 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
a2ef27823e
Merge pull request #17688 from kamil-tekiela/Fix-table-creation
Fix table creation

Fixes #17544
2022-08-18 22:54:53 -03:00
Kamil Tekiela
d14e334176 Update psalm-baseline.xml
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-17 21:20:50 +01:00
Kamil Tekiela
2e126d7f65 Fix table creation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-17 20:31:51 +01:00
Kamil Tekiela
0944221868 Extract moveBackToCallingScript
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-17 19:21:33 +01:00
Kamil Tekiela
6d91494935 Extract doTransformations
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-17 19:21:33 +01:00
Kamil Tekiela
1e70bba883 Fix bug not allowing insertion of set values
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-08 14:33:50 +01:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
b0c4426a43
Add basic tests for Controllers\Table\Partition classes
Adds better message for invalid partition name.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-27 15:29:02 -03:00
Maurício Meneghini Fauth
38564b5477
Check if db and table are strings in RecentFavoriteController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-22 17:16:09 -03:00
Maurício Meneghini Fauth
cba9b38a28
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:51:12 -03:00
Ankush Patil
987cb5043d
fixed find replace regex issue if no matching result set found
When find and replace searching used with regex, at the time of replace
empty CASE END condition was causing issue.

Fixes #17388
Closes #17641

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-19 15:28:43 -03:00
Maurício Meneghini Fauth
59b8f31a83
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-16 02:05:39 -03:00
William Desportes
6a69face6c
Fix PHP 8.2: ${var} deprecated string interpolation syntax
Ref: https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated

Left over to patch:
- libraries/classes/Git.php#L397
- libraries/classes/Database/Qbe.php#L878
- libraries/classes/Database/Qbe.php#L879

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-07-13 11:14:20 +02:00
Maurício Meneghini Fauth
f5d738db59
Move input.sqlbutton event listener to sql.js file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-19 16:48:10 -03:00
Maurício Meneghini Fauth
7a6bd9eb57
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-15 21:14:18 -03:00
Maurício Meneghini Fauth
bf2add8312
Fix preview SQL modal not working inside Index modal
- Fixes #17606

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-15 20:09:13 -03:00
Maurício Meneghini Fauth
e683f3aaa4
Merge pull request #17582 from kamil-tekiela/password_hash
Fix errors in InsertEdit

Fixes #17121
Closes #17120
2022-06-11 10:54:49 -03:00
Maurício Meneghini Fauth
3ac11ffa75
Introduce the ServerRequest object to ChangeController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-08 19:12:19 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-06 23:36:57 -03:00
Kamil Tekiela
6d0a30a391 Fix errors in InsertEdit
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-06-04 19:06:16 +01:00
Kamil Tekiela
ec888c47cd Tiny refactoring
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-06-03 20:15:58 +01:00
Kamil Tekiela
03e1859f8b Remove unnecessary globals
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-06-03 20:15:58 +01:00
Kamil Tekiela
b82027ef6d Redesign function fields in insert
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-06-03 20:15:58 +01:00
Rodrigo Pokemaobr
556804c4e2 Removing get tables from twig template and removing relationextension from twig template
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-31 16:22:46 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-27 16:25:39 -03:00
Maurício Meneghini Fauth
6201c7f2ba
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-27 13:27:59 -03:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-24 21:35:30 -03:00
Rodrigo Pokemaobr
547f89996f Removing Foreign Data from Twig
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 16:17:04 -03:00
Rodrigo Pokemaobr
d5585c3104 Removing search columns in foreigners from twig
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 15:34:55 -03:00
Rodrigo Pokemaobr
228fde03ee Removing get display field function on twig template
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 14:38:49 -03:00
Maurício Meneghini Fauth
dc7090386b
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-21 16:51:47 -03:00
Maurício Meneghini Fauth
9e4f3833a5
Fix Table\OperationsController failing test
The Partition::getPartitionNames method returns [0=>null] when no
partitions were found.

Related to 346d6c7981.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-21 16:35:36 -03:00
Maurício Meneghini Fauth
4c12e7a5f9 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 20:58:48 -03:00
Maurício Meneghini Fauth
346d6c7981 Fix error in table operation page when partitions are broken
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17496

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 20:52:55 -03:00
Maurício Meneghini Fauth
9931600c4d Fix coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-18 22:57:44 -03:00
Rodrigo Pokemaobr
272725f86e Adjusting the lint in files
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 18:02:26 -03:00
Rodrigo Pokemaobr
5ce4fe0b49 Removing foreign dropdown from twig functions
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 16:35:35 -03:00
Maurício Meneghini Fauth
9550066810
Introduce the ServerRequest object to AddFieldController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-04 15:55:22 -03:00
Maurício Meneghini Fauth
6dc859cbc2
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-28 15:56:18 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
b008cca95d
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-26 21:20:06 -03:00
Maurício Meneghini Fauth
04f3f5a4b6
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-26 21:03:20 -03:00
Maurício Meneghini Fauth
5d80594341 Remove jQuery SVG JS dependency
Removed by https://github.com/phpmyadmin/phpmyadmin/pull/17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-24 20:39:12 -03:00
Maurício Meneghini Fauth
62683a0115 Add method to AbstractController to send error messages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-20 16:39:33 -03:00
Maurício Meneghini Fauth
0d4d2a4935
Add exceptions for invalid identifier names
- Adds the PhpMyAdmin\Dbal\InvalidIdentifierName exception
- Adds the PhpMyAdmin\Dbal\InvalidDatabaseName exception
- Adds the PhpMyAdmin\Dbal\InvalidTableName exception

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-19 17:35:35 -03:00
Maurício Meneghini Fauth
619d4acb4a
Refactor DropColumnConfirmationController class
- Removes global variables
- Redesigns the HTML to use Bootstrap styles
- Add more tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-18 15:36:07 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
ec4baa6583
Remove calls of Util::getValueByKey where path doesn't have a dot
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-08 14:30:19 -03:00
Maurício Meneghini Fauth
f940693c75
Move Util::checkParameters method to the AbstractController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 22:59:33 -03:00