gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

4898 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
afcb4e406d
Add Config\Settings\SqlQueryBox::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:22:56 -03:00
Maurício Meneghini Fauth
51a20c09fc
Add Config\Settings\Server::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:16:26 -03:00
Maurício Meneghini Fauth
7fde991c6a
Add Config\Settings\Schema::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 15:01:53 -03:00
Maurício Meneghini Fauth
2ef2e44201
Add Config\Settings\Import::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 14:54:28 -03:00
Maurício Meneghini Fauth
395e46d637
Add Config\Settings\Export::asArray() method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 14:45:38 -03:00
Maurício Meneghini Fauth
50f9a90275
Add Config\Settings\Debug::asArray() method 
Refactor the test to test each property individually.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-01 14:28:01 -03:00
Maurício Meneghini Fauth
7f5a1b799f
Add Config\Settings\Console::asArray() method 
Refactor the test to test each property individually.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-28 17:52:40 -03:00
Maurício Meneghini Fauth
25cce47ae2
Merge config.default.php with Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-28 12:19:02 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
342ab3f67a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 14:36:32 -03:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
William Desportes
f3aa3639b3
Remove chdir from GitTest after fixing #18112 
Ref: d9a6f82bc1

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-26 23:57:54 +01:00
William Desportes
d9a6f82bc1
Fix #18112 - open base dir warning on git version class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-26 23:31:28 +01:00
Maurício Meneghini Fauth
0abbc52c22
Merge pull request #18150 from MoonE/gis-editor-globals 
Remove global usage in GisDataEditorController
 2023-02-26 16:34:36 -03:00
Maurício Meneghini Fauth
a54651b25c
Fix deprecation for Command classes 
Uses the AsCommand attribute instead of $defaultName.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-26 11:39:25 -03:00
Maximilian Krög
4f76f8eb32
Only create one GisVisualization object 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-25 04:40:36 +01:00
Maximilian Krög
3417030100
Remove globals usage in GisDataEditorController 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-25 04:40:35 +01:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
2137664f82
Merge pull request #18116 from kamil-tekiela/Remove-strlen 
Remove strlen when used in a condition
 2023-02-24 20:20:12 -03:00
Kamil Tekiela
e8c5eef6f8
Remove annoying empty statements (#18114) 
* Remove annoying empty statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make $extra strict and stop passing false to it

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make $page strict and stop passing null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 20:11:37 -03:00
Kamil Tekiela
dcc912fdef Remove strlen when used in a condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 22:58:47 +00:00
Maurício Meneghini Fauth
a7dd3bd380
Merge pull request #18118 from MoonE/gis-generate-params 
Proper method inheritance for gis generateParams
 2023-02-24 19:35:09 -03:00
Kamil Tekiela
5d1768195d
Refactor SubPartition and Partition (#18142) 
* Set native types

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 19:14:00 -03:00
Kamil Tekiela
deb7d4852e $value can be also a string 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 20:56:33 +00:00
Maurício Meneghini Fauth
38f6b238db
Move public files to the public directory 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 15:36:31 -03:00
Maximilian Krög
818c2d99d6
Reduce code duplication in gis generateParams 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-23 20:01:12 +01:00
Maximilian Krög
fdf8f21386
No implicit array creattion in gis generateParams 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-23 20:01:12 +01:00
Maximilian Krög
dabfdab390
Proper method inheritance for gis generateParams 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-23 20:01:07 +01:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Kamil Tekiela
aa63c6821a Fix bug related to tables with numerical names 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-22 13:18:06 +00:00
William Desportes
496bd0f3d0
Remove non used code of explain button (Generator::generateRowQueryOutput) 
Since: f1581cfe9b

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:51:26 +01:00
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314 
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:47:59 +01:00
Maurício Meneghini Fauth
cfa6e976e7
Merge pull request #18115 from MoonE/gis-label-trim 
Trim label before passing it on to GIS classes
 2023-02-21 22:45:53 -03:00
Kamil Tekiela
c348457cd6 Set property type in ExportPluginProperties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:55:14 +00:00
Kamil Tekiela
926d51b7b2 Set native types in PluginPropertyItem 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:55:14 +00:00
Kamil Tekiela
17e89ad0dc Set types in OptionsPropertySubgroup 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:55:14 +00:00
Kamil Tekiela
e545af4bee Use SplObjectStorage instead of an array 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:55:09 +00:00
Kamil Tekiela
a67dd95705 Set return types in OptionsPropertyOneItem 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:59 +00:00
Kamil Tekiela
b224b7f0e0 Set native types in OptionsPropertyItem 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:59 +00:00
Kamil Tekiela
235b4701bc Set native types in PropertyItem 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:59 +00:00
Kamil Tekiela
771402e99e Make $doc strictly typed 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:59 +00:00
Kamil Tekiela
e27394f9b6 Set $len to default 0 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:59 +00:00
Kamil Tekiela
04b6967174 Set $size to default 0 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:59 +00:00
Kamil Tekiela
b48c445120 Deimplement incompatible method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 23:50:58 +00:00
Maurício Meneghini Fauth
db267cfb27
Merge pull request #18137 from kamil-tekiela/quoteString-control-user 
Add Connection::TYPE_CONTROL to quoteString
 2023-02-21 20:38:33 -03:00
Kamil Tekiela
912f179432 Add Connection::TYPE_CONTROL to quoteString 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-21 22:36:01 +00:00
Maurício Meneghini Fauth
d5b068b8e3
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 19:32:32 -03:00
Maurício Meneghini Fauth
07af9572ea
Use constructor prop promotion for RelationParameters class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 18:51:25 -03:00
Maurício Meneghini Fauth
1ffd881fb4
Refactor ConfigStorage\RelationCleanup::user() 
- Replaces escapeString() with quoteString()

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 18:22:39 -03:00