gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

335 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
40d2a1c605
Merge pull request #16338 from mauriciofauth/replication 
Refactor the ReplicationInfo class
 2020-09-12 09:07:33 -03:00
Maurício Meneghini Fauth
cd862d4f00 Remove replication_info global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 09:04:44 -03:00
Maurício Meneghini Fauth
34dd2a61f8 Remove strPrivDesc* global variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
952e2f9ee8 Remove replication_types PHP global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-08 15:54:02 -03:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-08 13:32:25 -03:00
William Desportes
4d7c00a4ce
Merge branch 'QA_5_0' 
Closes: #16335
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-09-07 12:25:09 +02:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
55c5c80d37 Rename Display\ImportAjax class 
Renames to Import\Ajax.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-20 12:07:54 -03:00
Maurício Meneghini Fauth
fa67657b1a Remove Display\Import class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-20 00:21:26 -03:00
Maurício Meneghini Fauth
28436399dd Extract exit from Display\Import class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-19 02:28:02 -03:00
Maurício Meneghini Fauth
65b79af29e Refactor Plugins::getPlugins method 
Replaces parameters with explicit methods.
 - Plugins::getExport
 - Plugins::getImport
 - Plugins::getSchema

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-19 01:40:27 -03:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class 
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc Extract HTML from server, db and table export controllers 
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
ae975e594e Remove Privileges::getHtmlForUserGroupDialog method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee Remove Config\PageSettings::showGroup method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
b30f06455c Remove the blacklist/whitelist terminology 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-15 17:51:24 -03:00
William Desportes
14211e6118
Fix twig imports using old PSR-1 style 
Ref: 273b666a71
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-14 22:55:55 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities 
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:42:53 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-24 15:25:56 +02:00
William Desportes
a72203c514
Remove some unused code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 23:51:43 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
7db0debd05
Fix some failing tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-02 01:51:51 +02:00
William Desportes
0cbba2aef2
Add some properties typehints 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-02 01:41:59 +02:00
Maurício Meneghini Fauth
ae0d7127e0 Extract the drop_db action from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-20 20:00:52 -03:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-16 20:15:42 -03:00
William Desportes
a612229b99
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-14 23:42:06 +02:00
long76
bde460019c
fix #16078 - get unix timestamp for monitor 
Signed-off-by: Gleb Borkov <long76.git@mail.ru>
 2020-04-14 21:40:29 +02:00
Maurício Meneghini Fauth
e656f341ef Redesign the server status advisor page 
Uses an accordion instead of a table to show the issues.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-13 02:56:16 -03:00
Maurício Meneghini Fauth
52603d18f9 Use early exit for Server\DatabasesController::destroy 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-07 15:34:42 -03:00
Maurício Meneghini Fauth
10357465de Fix PHPUnit tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-06 22:06:08 -03:00
Yash Bothra
bac6f6bb0c
Fix #15447 - disable checkbox of pmadb 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
 2020-03-06 23:29:26 +01:00
Maurício Meneghini Fauth
a63dbfb051 Move SysInfo classes to the Server\SysInfo namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-16 17:22:44 -03:00
Maurício Meneghini Fauth
a95d9c3e65 Extract the HTML from the subnav of Users page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-16 16:05:51 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-14 18:54:02 -03:00
Maurício Meneghini Fauth
a1bcb9f0f3 Refactor server pages common code 
Extracts server_common.inc.php code to the Common::server() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file 
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
48a7ce660a Create Server\ExportController controller 
Extracts the server export entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-03 16:20:30 -03:00
Maurício Meneghini Fauth
4457a60e5e Create Server\ImportController class 
Moves the server import entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-29 20:34:24 -03:00
Maurício Meneghini Fauth
073418a7ec Create Server\PrivilegesController controller 
Moves the server privileges entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-22 12:20:04 -03:00
Maurício Meneghini Fauth
b1328c7ad6 Create Server\UserGroupsController controller 
Moves the user groups entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-22 11:54:34 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534) 
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
 2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
5b1256b737 Remove server common from MonitorController constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 17:45:42 -03:00
Maurício Meneghini Fauth
ae05259f9c Move server replication entry point to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 15:49:22 -03:00
Maurício Meneghini Fauth
bad2b8eca9 Move server variables entry point to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 15:21:59 -03:00
Maurício Meneghini Fauth
a42b6a1588 Move server status variables to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 14:31:44 -03:00
Maurício Meneghini Fauth
3804d4e8cc Move server status queries entry point to routes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 14:13:55 -03:00
Maurício Meneghini Fauth
11ace284fa Move srv status processes entry point to routes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 14:01:20 -03:00
Maurício Meneghini Fauth
4a793282a0 Move server status monitor entry point to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-26 18:08:57 -03:00
Maurício Meneghini Fauth
110e00776e Move server status advisor to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-26 15:55:52 -03:00
Maurício Meneghini Fauth
ed6d079f25 Move server status entry point logic to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
065f3f560c Move server sql entry point to the routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-26 14:30:00 -03:00
Maurício Meneghini Fauth
9372bae319 Move server collation entry point to routes.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-26 12:15:29 -03:00
Maurício Meneghini Fauth
3814d88e2c Refactor server binlog entry point 
Moves entry point logic to the routes file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-21 11:05:12 -03:00
Maurício Meneghini Fauth
0c99e03a1e Refactor the server databases entry point 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dc7372fb99 Fix URL query issues with Util::getScriptNameForOption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-22 17:30:18 -03:00
Maurício Meneghini Fauth
6625114b98 Fix database link in /server/databases 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-18 22:38:54 -03:00
Hugues Peccatte
c233a4364a Use right PHP function 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
12561a598d Remove direct access to server_databases.php 
Uses the router instead

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-09 21:51:49 -03:00
Maurício Meneghini Fauth
34a63c6a77 Add toArray method to Server\Plugin class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-02 00:57:53 -03:00
Maurício Meneghini Fauth
b9ec5071fe Add Server\Plugin value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-02 00:40:54 -03:00
Maurício Meneghini Fauth
711ef54eca Add Charsets::findCollationByName method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
4fe624fa93 Remove Charsets::getCollationDropdownBox method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-25 03:32:01 -03:00
Maurício Meneghini Fauth
02766cf370 Add Charset and Collation value types 
And refactor Charset class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-23 05:19:53 -03:00
William Desportes
a2268169ae
Use strict compare for count function 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:41:54 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
05ce6ffed4 Rename js/server_*.js to js/server/*.js 
Rename js/server_status_*.js to js/server/status/*.js

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-07 03:56:22 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271) 
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-06-01 15:13:41 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-19 01:54:44 +02:00
Maurício Meneghini Fauth
26a6a8dd4c Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-01 01:56:27 -03:00
William Desportes
ca3f027f7e
Fix #13178 - Issues with uppercase table and database names 
Fixes: #13178
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-28 21:32:31 +02:00
William Desportes
1524ec51c8
Merge branch 'QA_4_8' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-28 01:00:28 +02:00
Maurício Meneghini Fauth
5e828ec810 Create Server\ReplicationController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-06 20:26:06 -03:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController 
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
35e6b43ba8 Rename Status\Controller to Status\AbstractController 
Rename PhpMyAdmin\Controllers\Server\Status\Controller to
PhpMyAdmin\Controllers\Server\Status\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-11 15:26:57 -03:00
Maurício Meneghini Fauth
7c828f7327 Remove PhpMyAdmin\Server\Status\Data::getHtmlForRefreshList() 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-25 20:42:44 -03:00
Maurício Meneghini Fauth
2074be7eab Create Server\Status\VariablesController 
Extracts server_status_variables.php and Server\Status\Variables logic
to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-25 19:02:54 -03:00
Maurício Meneghini Fauth
e149a6188f Create Server\Status\QueriesController 
Extracts server_status_queries.php and Server\Status\Queries logic to
the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-25 00:53:57 -03:00
Maurício Meneghini Fauth
c485c311aa Create Server\Status\ProcessesController 
Extracts server_status_processes.php and Server\Status\Processes logic
to controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-21 23:25:30 -03:00
Maurício Meneghini Fauth
12ae5553a6 Create Server\Status\MonitorController 
Moves server_status_monitor.php logic to controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-21 02:23:23 -03:00
Maurício Meneghini Fauth
c9a31450fa Create server status abstract controller 
Create PhpMyAdmin\Controllers\Server\Status\Controller abstract
controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-19 17:13:48 -03:00
Maurício Meneghini Fauth
5368c151b4 Create Server\Status\StatusController 
- Extracts Server\Status and server_status.php logic to controller
- Extracts HTML to server/status/status/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-18 15:59:59 -03:00
Maurício Meneghini Fauth
fe931429f9 Extract HTML from Server\Status\Data::getMenuHtml() 
Extracts to server/status/base template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-17 16:52:02 -03:00
Maurício Meneghini Fauth
4bf6ad1952 Create Server\Status\AdvisorController 
- Moves PhpMyAdmin\Server\Status\Advisor and server_status_advisor.php
logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-17 16:03:09 -03:00
Maurício Meneghini Fauth
02a9fd371c Refactor Server\VariablesController 
- Moves request and response handling to server_variables.php
- Extracts and groups all HTML in server/variables/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-17 13:01:10 -03:00
Maurício Meneghini Fauth
20cccfd53b Refactor Server\PluginsController 
- Moves response handling to server_plugins.php
- Renames server/plugins/main to server/plugins/index

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-16 15:05:05 -02:00
Maurício Meneghini Fauth
d6dfb3eed6 Refactor Server\EnginesController 
- Moves request and response handling back to server_engines.php
- Rename templates
- Refactor tests

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-15 20:35:00 -02:00
Maurício Meneghini Fauth
c29d4005b4 Rename ServerVariablesController to VariablesController 
Renames PhpMyAdmin\Controllers\Server\ServerVariablesController to
PhpMyAdmin\Controllers\Server\VariablesController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-14 13:42:04 -02:00
Maurício Meneghini Fauth
798f76fdb0 Rename ServerPluginsController to PluginsController 
Renames PhpMyAdmin\Controllers\Server\ServerPluginsController to
PhpMyAdmin\Controllers\Server\PluginsController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-14 13:26:28 -02:00
Maurício Meneghini Fauth
b51e6eebc0 Rename ServerEnginesController to EnginesController 
Renames PhpMyAdmin\Controllers\Server\ServerEnginesController to
PhpMyAdmin\Controllers\Server\EnginesController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-13 22:34:28 -02:00
Maurício Meneghini Fauth
b80403b304 Rename ServerDatabasesController to DatabasesController 
Renames PhpMyAdmin\Controllers\Server\ServerDatabasesController to PhpMyAdmin\Controllers\Server\DatabasesController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-13 22:20:14 -02:00
Maurício Meneghini Fauth
7235eb055d Rename ServerCollationsController to CollationsController 
Renames PhpMyAdmin\Controllers\Server\ServerCollationsController to
PhpMyAdmin\Controllers\Server\CollationsController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-13 22:14:27 -02:00
Maurício Meneghini Fauth
58c1805925 Rename ServerBinlogController to BinlogController 
Renames PhpMyAdmin\Controllers\Server\ServerBinlogController to
PhpMyAdmin\Controllers\Server\BinlogController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-13 22:08:34 -02:00
Maurício Meneghini Fauth
3bb1337e90 Refactor ServerBinlogController 
Refactors PhpMyAdmin\Controllers\Server\ServerBinlogController.

- Moves request and response handling back to server_binlog.php
- Extracts and groups all HTML into server/binlog/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-13 21:33:36 -02:00
Maurício Meneghini Fauth
b068a0d639 Refactor ServerCollationsController 
Refactors PhpMyAdmin\Controllers\Server\ServerCollationsController.

- Moves response handling back to server_collations.php.
- Groups all HTML in templates/server/collations/index.twig.
- Improves unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-29 00:56:20 -02:00
Maurício Meneghini Fauth
32e83d9097 Refactor ServerDatabasesController 
Refactors PhpMyAdmin\Controllers\Server\ServerDatabasesController.

- Renames variables and methods to camelCase format.
- Moves request and response handling back to server_databases.php.
- Groups all HTML into templates/server/databases/index.twig.
- Improves unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-26 16:29:33 -02:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php 
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-22 18:18:21 -02:00
Hugues Peccatte
7f304c1154 Remove useless proxies 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 23:39:19 +01:00
Hugues Peccatte
6358cd49dc Fix wrong case in function names 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 13:36:27 +01:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements 
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:04:19 -02:00
Madhura Jayaratne
e7f1e2697a Retrieve parameters from $_POST in server variables 2018-12-04 19:08:16 +11:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign 
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
 2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values 
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
 2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
34972f0132 Retrieve parameters from $_POST in server binlog 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:59 -02:00
Madhura Jayaratne
5d781422fb Retrieve parameters from $_POST in server_databases page 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-11-10 20:48:58 -02:00
Gaurav Punjabi
6f64ff1545 Removing the default collation footer 
Removing the default server collation in the footer of the databases table.As the the default collation can be seen in the dropdown at the top of the page

Signed-off-by: Gaurav Punjabi <gaurav.punjabi6@icloud.com>
 2018-11-02 02:14:21 +05:30
Gaurav Punjabi
6b00d07810 Update ServerDatabasesController.php 
Just removing the default collation of the server on the database page since the server has no collation.
In reference to solve Issue  phpMyAdmin#14965
Signed-off-by: Gaurav-Punjabi <gaurav.punjabi6@icloud.com>
Signed-off-by: Gaurav Punjabi <gaurav.punjabi6@icloud.com>
 2018-11-02 02:14:21 +05:30
William Desportes
3dce65d913 phpstan level 1 (#14472) 
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-08-18 14:37:41 -03:00
William Desportes
38009efb65
Add support for MySQL/MariaDB variables documentation 
- Uses preferential mode MySQL docs for MySQL users and MariaDB docs for MariaDB users
- Unit tests now use data that only exists for tests
- Added package williamdes/mariadb-mysql-kbs

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-07-26 17:12:35 +02:00
Leonardo Strozzi
7dc44b2ea9 Fix tests for server_engine 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 22:27:37 -03:00
Leonardo Strozzi
36ceaee55a Refactor server_engines templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 20:23:26 -03:00
Leonardo Strozzi
28d890f7f7 Refactor server_plugins templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 18:05:29 -03:00
Leonardo Strozzi
217a0db2f8 Refactor server_variables templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 16:36:36 -03:00
Leonardo Strozzi
15ae8d7fe5 Refactor server_databases templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 16:36:36 -03:00
Isaac Bennetch
e4a76a1d12 Merge branch 'QA_4_8' 2018-06-29 10:58:50 -04:00
Lakshay arora
b0ec6b69e9 Fix for #14314, error while naming a database '0' 
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
 2018-06-29 10:40:54 -04:00
Leonardo Strozzi
f0eab56fc3 Fix code sniffer ServerDatabasesController error 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-25 23:07:05 -03:00
Leonardo Strozzi
05cff7ed58 Fix server databases statistics 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-25 18:06:20 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes 
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-05-29 23:06:31 -03:00
Maurício Meneghini Fauth
dce862d41b Remove dbi global from Controllers 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-22 16:51:03 -03:00
Maurício Meneghini Fauth
1c2a2bb768 Fix TypeError in ServerDatabasesController 
Fixes #14304

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-19 14:36:49 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
5f46a4ba52 Enable strict mode in Controllers classes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-15 01:18:52 -03:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage 
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 14:24:42 +01:00
Michal Čihař
868bb18c98 Better deal with unitialized page 
Fixes #13814

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 16:39:28 +01:00
Maurício Meneghini Fauth
cc2c4fc36d Replace globals with DI in Charsets class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-09 11:31:42 -02:00
Maurício Meneghini Fauth
452b624dc4 Move dependencies to outside of abstract controllers 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-04 12:41:57 -02:00
Maurício Meneghini Fauth
2ae2b8b54e Use template for server databases table 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-03 11:31:01 -02:00
Maurício Meneghini Fauth
ff38d5c5eb Move sub page header to index template 
Move server/sub_page_header template from ServerDatabasesController
to server/databases/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
79f6f88bff Use template for server sub page header 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
6672d4f2ea Use template for server databases index 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
d4464f948c Port server/databases/table_row template to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-29 12:18:28 -02:00
Maurício Meneghini Fauth
412020beea Port server/databases/table_header template to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-29 12:18:28 -02:00
Maurício Meneghini Fauth
0e867253dd Port server/databases/table_footer to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-29 12:18:28 -02:00
Michal Čihař
99e47a90d9 Always define correct connection type 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-25 10:21:18 +02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink'] 
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-25 10:21:18 +02:00
Maurício Meneghini Fauth
d70433bd62 Port server/engines/engine template to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-23 23:38:42 -02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 12:28:00 +02:00
Maurício Meneghini Fauth
582b1484ac Port server/databases/create template to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-07 21:34:05 -03:00
Maurício Meneghini Fauth
d8906b8236 Port server/binlog/log_selector template to Twig 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-10-07 18:32:40 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
f9fbb28f26 Fix server/variables/variable_row variable names 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-22 12:28:23 -03:00
Maurício Meneghini Fauth
a2b08bae7b Refactor check_user_privileges to static methods 
Refactor check_user_privileges.lib.php functions to static methods and move logic to check_user_privileges.inc.php.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-11 22:09:05 -03:00
Maurício Meneghini Fauth
f7051b2e5c Refactor server_common functions to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-08 00:28:06 -03:00
Manish Bisht
b4f32585e2 server variables out of table fixed 
Signed-off-by: Manish Bisht <manish.bisht490@gmail.com>
 2017-08-01 20:46:55 +05:30
Maurício Meneghini Fauth
95a409c4f2 Move controllers to PhpMyAdmin namespace 
- Move base controllers to PhpMyAdmin namespace
- Move database controllers to PhpMyAdmin namespace
- Move server controllers to PhpMyAdmin namespace
- Move table controllers to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-07-14 11:18:48 -03:00