gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

667 Commits

Author SHA1 Message Date
William Desportes
f77433b9b7
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-28 01:37:17 +02:00
Maximilian Krög
315426324d
Respect pos and limit in gis visualization 
Co-Authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-07-28 01:26:17 +02:00
William Desportes
cef66ddc19
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-27 02:59:31 +02:00
William Desportes
a8d9f44f96
Fix #17016, Fix #17037 - Display the error after structure change errored 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-26 18:55:58 +02:00
William Desportes
9373c8ec70
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 14:51:35 +02:00
William Desportes
d281dcc0bd
Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 12:59:54 +02:00
William Desportes
83053288c0
Ref #12586 - Remove un-expected message from Export table 
The message was wrong and was now shown due to some code-base changes.
Before output buffering was catching it and destroying it before output was flushed

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-21 23:21:41 +02:00
William Desportes
3a87667cab
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-20 17:52:16 +02:00
William Desportes
1645ee38fb
Remove InsertEdit::getUrlParameters 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-20 16:12:30 +02:00
William Desportes
fcd0a2393a
Fix coding standard issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:44:05 +02:00
William Desportes
8f77a9f29d
Ref #15247 - Remove defined('TESTSUITE') from ReplaceController and remove an exit 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:39:14 +02:00
William Desportes
c830c1e93a
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:34:29 +02:00
William Desportes
f724f648e1
Fix #16976 - Wrong link when a table is moved from a database to another 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:13:03 +02:00
Maurício Meneghini Fauth
1835ebb4fc
Replace mb_strpos !== false with str_contains 
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
e8c28d1883
Remove some globals from Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
069d8e13db
Fix error found by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-05 15:23:46 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
cc0cc79253
Accept only string for Response::addHTML method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-29 18:04:18 -03:00
William Desportes
6996e8dd28
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-27 19:01:02 +02:00
William Desportes
535b374163
Fix "Undefined index: clause_is_unique" on replace value in cell 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-27 18:27:38 +02:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-24 18:03:14 -03:00
William Desportes
300e835edb
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-16 01:10:11 +02:00
William Desportes
f09ead5e07
Fix code using relative path 
if (chdir('/tmp') === false) {
    die('Could not change dir');
}

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-15 22:24:30 +02:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
eff631ac1b
Extract HTML from the InsertEdit::getActionsPanel method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-27 12:06:17 -03:00
Maurício Meneghini Fauth
674bf8f97c
Remove db, table and dbi globals from Tracking class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-26 16:40:05 -03:00
Maurício Meneghini Fauth
5faf95016f
Use DatabaseName VO for db names in Table\Partition 
- Adds DatabaseName support for DatabaseInterface::selectDb method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-21 21:30:37 -03:00
Maurício Meneghini Fauth
4d09e19216
Add DatabaseName value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-21 16:17:28 -03:00
Maurício Meneghini Fauth
4dec56d883
Remove get_start_and_number_of_rows_panel() Twig function 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-17 17:56:34 -03:00
Maurício Meneghini Fauth
467ef3cd63
Extract the drop column action to a new controller 
Extracts the drop action method from Table\StructureController to the
Table\DropColumnController class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 12:42:40 -03:00
Maurício Meneghini Fauth
011915fe7b
Add the redirect method to controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 12:23:26 -03:00
Maurício Meneghini Fauth
5b2957bdc1
Add a redirection after dropping a column 
Instead of loading the page in the same action, redirect to the table
structure page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-07 11:24:12 -03:00
Maurício Meneghini Fauth
5f1084ff78
Extract new controller for drop column confirmation 
Extracts the Table\StructureController::dropConfirm action to the
Table\DropColumnConfirmationController controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-06 14:40:10 -03:00
William Desportes
db01d6a9da
Remove some else conditions by using early exits or moving code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 01:18:39 +02:00
William Desportes
d82e85f852
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-23 18:46:05 +02:00
William Desportes
45aeee579a
Fix #14773 - export raw query is not working 
Ref: #15064 (issue to track the export raw query feature)
Yes, this issue was closed with #15064 but I will close it anyway because it made sense as the feature was broken once more
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-23 17:46:26 +02:00
William Desportes
e0c1dea460
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-23 03:16:29 +02:00
liviuconcioiu
6dc79009f7
Fix #16810 - SQL query shown twice 
Fix SQL query shown twice on PRIMARY, UNIQUE, INDEX, SPATIAL, FULLTEXT, add to central columns, remove from central columns

Signed-off-by: Liviu Concioiu <liviu.concioiu@gmail.com>
 2021-04-23 03:05:46 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 21:51:45 +02:00
William Desportes
ec4df90ab6
Merge #16811 - Fix #16810 - Fix SQL query shown twice on drop 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 19:19:30 +02:00
William Desportes
ba35901594
Merge branch 'origin/QA_5_1' into master 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-17 00:53:14 +02:00
William Desportes
deac7cffde
Fix not working export to PNG, SVG, PDF on GIS visialization 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-17 00:28:38 +02:00
William Desportes
856145297f
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-13 17:46:06 +02:00
William Desportes
b78f8a094c
Fix #16790 - Undefined index field_name 
Unable to reproduce, adding a safety will make the code run properly.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 22:31:37 +02:00
Saksham Gupta
db5fc3fd7f Fix #16810 Fix SQL query shown twice on drop 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-04-12 23:20:48 +05:30
William Desportes
9f0fc40cdb
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-02 13:40:28 +02:00
William Desportes
700108ba90
Add missing stickfill script on zoom search 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-01 18:31:53 +02:00
Maurício Meneghini Fauth
bbb117b30b
Extract the HTML from InsertEdit::getFunctionColumn 
Removes positive tabindex from function and null cells.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-28 17:17:19 -03:00
Maurício Meneghini Fauth
44bdd1d390
Rename $url_params global to $urlParams 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 22:48:14 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 19:39:28 -03:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-23 01:13:58 +01:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class 
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-22 15:03:39 -03:00
Saksham Gupta
04d72a8291 Fix #16703 No SQL option on Export of rows from a table 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add null fallback

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Update yarn.lock
 2021-03-22 22:34:06 +05:30
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class 
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-21 15:25:45 -03:00
William Desportes
0b440f2652
Ref #16651 - Fix and improve the chart checking for int columns 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-15 01:30:35 +01:00
William Desportes
c71c11e787
Remove an exit by moving out the preview SQL code on table create add field 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-11 21:09:46 +01:00
William Desportes
7aabad9b7a
Move queries from Operations class to the Query\Generator class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-06 02:11:25 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-24 23:56:33 +01:00
William Desportes
7e42b5a7a3
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-19 01:13:50 +01:00
William Desportes
6be33c4eb6
Ref #16666 - Ref #16424 - Adjust the index like the zoom controller 
Even if this is not needed, better that it is the same in the 2 controllers

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-19 00:42:01 +01:00
Saksham Gupta
4da866ed94 Fix #16424 - Numerical search in table and zoom 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fixes #16667

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment and change variable name

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-02-19 00:33:10 +05:30
William Desportes
2acea7d4c0
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:39:50 +01:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit 
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:25:34 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
a1d1ab85cb
Split rte.js into routines.js, triggers.js and events.js 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-11 17:02:50 -03:00
Maurício Meneghini Fauth
89dba07132
Remove rte.js dependency from navigation.js 
Only loads the rte.js file for the RTE pages.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-10 12:43:12 -03:00
Maurício Meneghini Fauth
acd214c9b7
Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:58:18 -03:00
Maurício Meneghini Fauth
0ed9c23c1e
Fix uncaught TypeError when editing partitioning 
When the partition has subpartitions.
https://github.com/phpmyadmin/phpmyadmin/issues/14494

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:50:18 -03:00
Maurício Meneghini Fauth
3a25c96543
Create truncate table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:36:05 -03:00
Maurício Meneghini Fauth
f419ce4f2e
Create repair table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:32:34 -03:00
Maurício Meneghini Fauth
905f48184f
Create rebuild table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:29:01 -03:00
Maurício Meneghini Fauth
42cf71d8aa
Create optimize table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:22:19 -03:00
Maurício Meneghini Fauth
0c38913c15
Create drop table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:16:46 -03:00
Maurício Meneghini Fauth
b64be69dd8
Create analyze table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 21:29:27 -03:00
Maurício Meneghini Fauth
f8df25487f
Create check table partition page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 21:09:32 -03:00
Maurício Meneghini Fauth
73f21d6950
Extract drop partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 15:01:41 -03:00
Maurício Meneghini Fauth
194c8372cc
Extract truncate partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-29 17:02:03 -03:00
Maurício Meneghini Fauth
1d4dea8e47
Extract repair partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-29 16:44:32 -03:00
Maurício Meneghini Fauth
1c0218aff7
Extract rebuild partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-29 16:12:34 -03:00
Maurício Meneghini Fauth
5577d9ecb7
Extract optimize partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-29 15:26:37 -03:00
Maurício Meneghini Fauth
6e4a9e82a0
Extract check partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-29 14:20:38 -03:00
Maurício Meneghini Fauth
aeac7177da
Extract analyze partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-29 12:21:21 -03:00
William Desportes
3dad3b5e5d
Merge #15912 - Fix #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL 
Issue: #14953
Pull-request: #15912
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-13 23:47:33 +01:00
Maurício Meneghini Fauth
b268491bd8 Replace exit with return in GetFieldController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-13 19:28:21 -03:00
Kartik Kathuria
b2039444bf
Fixes #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL 
Co-Authored-By: William Desportes <williamdes@wdes.fr>

Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2020-11-05 15:22:16 +01:00
Maurício Meneghini Fauth
c11e8d5f64 Remove Common::database method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:56:58 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
36d93cf2f9 Remove Common::table method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
6b81080127 Remove Common::server method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
94483dd4b9 Extract the HTML from Table\TrackingController::index 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-14 17:13:34 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
e6ec9df84e Remove DBI dep from Controllers/AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
405b6277e7 Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-10 14:16:25 -03:00
Isaac Bennetch
93c93bc9ee Fix merge conflicts 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2020-10-09 22:14:49 -04:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
William Desportes
aecdfc80cb
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-10-04 00:29:04 +02:00
Petr Duda
661af18061 Fix #16377 Uncaught ReferenceError: Stickyfill is not defined 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-10-01 21:39:49 +02:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
ea163ffcae Move CentralColumns to the Database namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 10:14:22 -03:00
Petr Duda
1086b2a6ee Fix #12961 Indexes shown at both tbl_structure and tbl_relation 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-09-13 19:31:59 +02:00
Maurício Meneghini Fauth
5aa2856f7f Remove Util::buildActionTitles and the titles global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 22:50:08 -03:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-08 13:32:25 -03:00
Maurício Meneghini Fauth
37289a57b2 Remove url_query and url_params from Table/StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-07 14:24:41 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
bade581161 Check if multi table maintenance is disabled 
Checks if $cfg['DisableMultiTableMaintenance'] is true.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-28 16:07:35 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view 
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
3b02872cd3 Create the Table\Maintenance class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-28 00:35:13 -03:00
Maurício Meneghini Fauth
46f28b42c9 Extract the Table\MaintenanceController class 
Extracts the table maintenance action methods from
the Database\StructureController class to the
new Table\MaintenanceController class and adjust templates
and routes names.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 23:33:43 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table 
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 14:22:22 -03:00
Maurício Meneghini Fauth
55c5c80d37 Rename Display\ImportAjax class 
Renames to Import\Ajax.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-20 12:07:54 -03:00
Maurício Meneghini Fauth
fa67657b1a Remove Display\Import class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-20 00:21:26 -03:00
Maurício Meneghini Fauth
28436399dd Extract exit from Display\Import class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-19 02:28:02 -03:00
Maurício Meneghini Fauth
65b79af29e Refactor Plugins::getPlugins method 
Replaces parameters with explicit methods.
 - Plugins::getExport
 - Plugins::getImport
 - Plugins::getSchema

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-19 01:40:27 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes 
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
 2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class 
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc Extract HTML from server, db and table export controllers 
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
e26bde7e96 Fix coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-24 20:33:47 -03:00
William Desportes
47c70dacc7
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-23 19:57:46 +02:00
William Desportes
fe9e7ba89d
Fix #16255 - Tinyint(1) shown as INT in search page 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-23 19:53:52 +02:00
Maurício Meneghini Fauth
7b958b874f Create ExportTemplateController class 
Extracts export templates handling from Display\Export class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-17 16:27:37 -03:00
Maurício Meneghini Fauth
e5328434bf Extract response from Operations class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-14 20:18:03 -03:00
Maurício Meneghini Fauth
858e8dc666 Extract template render from ColumnsDefinition::displayForm 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 17:21:36 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee Remove Config\PageSettings::showGroup method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
918b1f38c6 Change return type of Sql::executeQueryAndSendQueryResponse 
Remove Response::addHTML call.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a3147c26e1 Extract exit; from Core::previewSQL method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-09 16:20:41 -03:00
William Desportes
06ffb871b4
Merge branch 'QA_5_0' and sync Search controllers 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-07 15:00:47 +02:00
Ankush Patil
69d49789ce
Fixes #16248: identifying searchType in validation function 
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
 2020-07-07 13:57:23 +02:00
Maurício Meneghini Fauth
d09ab9bc9d Check where clause signature in TableSearchController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-03 17:45:58 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
William Desportes
e89b02c08d
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-24 09:07:17 +02:00
William Desportes
40d01944a3
Fix #16088 - Do not add axis switch on MariaDB 
Ref: 969f43c82b

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-22 21:56:56 +02:00
Maurício Meneghini Fauth
41d401b95e Extract save action from table structure index method 
Closes #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-08 19:57:28 -03:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-08 18:20:48 -03:00
Maurício Meneghini Fauth
5df2c41d67 Extract add-key action from table structure index method 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-06 19:35:52 -03:00
Maurício Meneghini Fauth
4446963b5a Extract partitioning actions from index method 
Extracts from Table/StructureController::index method.

Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-06 17:20:10 -03:00
Maurício Meneghini Fauth
9d18234581 Refactor Util::getUniqueCondition method 
Passes the Statement instance directly instead of the
$analyzed_sql_results array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-05 13:49:44 -03:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names 
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-30 17:20:43 -03:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-24 15:25:56 +02:00
Maurício Meneghini Fauth
e638ac2104 Extract table structure reserved word check action 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-23 15:24:16 -03:00
Maurício Meneghini Fauth
1d17c55f36 Extract table structure move columns action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 20:20:47 -03:00
Maurício Meneghini Fauth
7902e28652 Remove duplicated code in Table\StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:46:26 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
a6d9818b3a Extract the change action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
765059def4 Extract central columns actions from index method 
Extracts the /table/structure/central-columns-add and
/table/structure/central-columns-remove routes from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 17:15:15 -03:00
Maurício Meneghini Fauth
7b5ed8634a Extract the ftext action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 15:43:09 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 02:12:36 -03:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-21 15:29:36 -03:00
Maurício Meneghini Fauth
115f79c959 Extract primary action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-20 19:59:55 -03:00
Maurício Meneghini Fauth
04590f5b4f Extract drop fields action from index action 
Extracts the /table/structure/drop route from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 13:37:16 -03:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action 
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 11:21:42 -03:00
William Desportes
a72203c514
Remove some unused code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 23:51:43 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
8218aadded Extract row actions to respective controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-07 20:31:08 -03:00
Maurício Meneghini Fauth
95c891c37f Remove $submit_mult global from RowActionController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-06 18:42:58 -03:00
Maurício Meneghini Fauth
740967bec7 Refactor RowActionController::delete method 
Removes some unneeded code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-02 01:25:32 -03:00
Maurício Meneghini Fauth
0e88a5ba0f Extract actions from /table/row-action route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-30 01:29:36 -03:00
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-28 23:18:59 +02:00
Maurício Meneghini Fauth
4a0bce1d53 Extract db structure bulk actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 23:13:35 -03:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
26c24938fa Use early exit for RowActionController::index 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 08:09:38 -03:00
Maurício Meneghini Fauth
f00bfe1f4e Extract the row_delete action from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 03:50:33 -03:00
William Desportes
e6d72f64f9
Fix merge issues 
Ref: 54e0250dae

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-20 00:15:55 +02:00
William Desportes
54e0250dae
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-18 12:50:30 +02:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-16 20:15:42 -03:00
Ankush Patil
66338ccaec fixes #16041: added regex validation for INT having MULTIPLE prop 
Signed-off-by: Ankush Patil <aspraz2658@gmail.com>

added proper error message

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>

Fixing ambguious js code

Signed-off-by: Ankush Patil <aspraz2658@gmail.com>
 2020-04-14 14:12:33 +05:30
Maurício Meneghini Fauth
1102bdfdb7 Move Rte classes to the Database namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-13 18:26:47 -03:00
Maurício Meneghini Fauth
92bc73483e Remove the $_PMA_RTE global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-13 17:23:51 -03:00
Maurício Meneghini Fauth
c1ca032da7 Use DI for RTE classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-11 16:09:35 -03:00
Maurício Meneghini Fauth
4471b1bced Remove the MaxFileSize HTML generator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-01 16:03:15 -03:00
Maurício Meneghini Fauth
d612215aab Remove dropdown field generator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-30 01:59:03 -03:00
Maurício Meneghini Fauth
db642ab19e Extract HTML from Index:getHtmlFromIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-29 23:43:18 -03:00
Maurício Meneghini Fauth
eb2804540f Extract HTML from Index::getHtmlForDisplayIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-29 16:09:50 -03:00
Maurício Meneghini Fauth
a7e8b0f67a Extract HTML from row formats dropdown 
Removes usage of DropDown::generate() in table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-27 20:23:40 -03:00
Maurício Meneghini Fauth
558226d78e Extract HTML from StorageEngine::getHtmlSelect() 
Renames the method to StorageEngine::getArray().

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-27 19:31:35 -03:00
Maurício Meneghini Fauth
5a54330ee0 Extract HTML from ListAbstract::getHtmlOptions() 
Renames the method to ListAbstract::getList().

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-27 17:14:49 -03:00
William Desportes
191a0a06ec
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-03-24 22:53:35 +01:00
Isaac Bennetch
095cb4d5a2 Fix phpcs test errors 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2020-03-22 23:08:22 -04:00
Isaac Bennetch
6efdd77483 Merge branch 'QA_5_0' 2020-03-20 22:50:16 -04:00
Isaac Bennetch
0d4c7c66a5 Merge branch 'QA_4_9' into QA_5_0 2020-03-20 22:01:14 -04:00
Maurício Meneghini Fauth
fbcce9c121 Extract method for edit row action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-10 13:35:46 -03:00
Maurício Meneghini Fauth
65233b574c Extract method for export row action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-10 13:35:46 -03:00
Maurício Meneghini Fauth
82db7444c3 Extract db_table_exists.inc.php to DbTableExists class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-02 17:01:26 -03:00
Maurício Meneghini Fauth
c8c2e9d793 Refactor tbl_columns_definition_form.inc.php 
Extracts the tbl_columns_definition_form.inc.php logic to the
PhpMyAdmin\Table\ColumnsDefinition::displayForm static method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-17 02:55:20 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:23:16 +01:00
William Desportes
517222ff59
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-13 00:07:11 +01:00
William Desportes
0b2937dd6a
Fix #15781 - Illegal string offset error on structure page of 'information_schema' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-12 23:11:41 +01:00
Maurício Meneghini Fauth
30b5fc46d2 Extract HTML from table operations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-24 20:00:13 -03:00
William Desportes
b736f0a79f
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-24 22:00:16 +01:00
William Desportes
36e4cf8f88
Fix after pull-request #15846 - add support for unsigned ints 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-24 21:24:53 +01:00
William Desportes
afce79c4bd
Merge #15846 - Fix #13326 - added Integer Validations on Search page 
Fixes: #13326
Pull-request: #15846
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-24 21:11:54 +01:00
Manthan Surkar
e92e51d42d Added: Integer Validations on Search page 
Signed-off-by: Manthan Surkar <manthan.surkar@gmail.com>
 2020-01-25 01:21:19 +05:30
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3c22f5e7b2 Add conding standard rule for useless method overrides 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:56:23 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:29:54 -03:00
William Desportes
ae0577ab1e
Merge #15820 - Fix #15797 - Relation view broken 
Fixes: #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa fixes url. 
fixes #15797

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
 2020-01-19 20:06:03 +05:30
William Desportes
fd036d7f4a
Merge #15808 - Fix #15312 - added LOCK=NONE to ALGORITHM=INPLACE 
Fixes: #15312
Pull-request: #15808
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-19 13:53:25 +01:00
Maurício Meneghini Fauth
a8acd7a42c Use Util::backquote in getDataRowAction 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-18 22:13:03 -03:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-17 19:44:00 -03:00
Kartik Kathuria
9054d1f673 Added LOCK=NONE 
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2020-01-17 20:42:09 +05:30
Kartik Kathuria
a439082dba Change ALTER ONLINE to ALGORITHM=INPLACE at required position 
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2020-01-17 13:36:06 +05:30
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-14 18:54:02 -03:00
Jayati Shrivastava
f14d675308
revert change introduced by pr #15718 and fix #15718 
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
 2020-01-12 18:46:23 +01:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code 
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0 Refactor database pages common code 
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
a1bcb9f0f3 Refactor server pages common code 
Extracts server_common.inc.php code to the Common::server() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
96ee3b8ab0 Remove the table structure entry point file 
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
7837ab81f2 Remove the table sql entry point file 
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
634c9f38e9 Remove the table replace entry point file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
4ffb6712ff Remove the table export entry point file 
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
d190c82f1e Remove the table change entry point file 
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
42468cb033 Remove the database sql entry point file 
Directly calls the controller instead of including the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
cbce3a66e3 Remove the sql entry point file 
Directly calls the controller instead of including the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 23:15:26 -03:00
William Desportes
77ffaa9d4c
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-07 00:15:26 +01:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller 
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 15:02:28 -03:00
Maurício Meneghini Fauth
363707890b Refactor Table\SqlController controller 
Moves the table sql entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 13:50:02 -03:00
Maurício Meneghini Fauth
fc9fcd1550 Create Table\ReplaceController controller 
Extracts the table replace entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 13:27:48 -03:00
Maurício Meneghini Fauth
a6e6555b73 Create Table\ExportController controller 
Extracts the table export entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-04 12:43:46 -03:00