gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

336 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
9f3b4f04e9
Wrap variable variables in curly braces 
See: https://www.php.net/manual/en/language.variables.variable.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 19:18:48 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method 
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-02 13:20:50 -03:00
William Desportes
880043961e
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-11 02:53:56 +02:00
William Desportes
5271b960bc
Fix #17039 - Unable to have 2FA working with a pmadb value != phpmyadmin 
Fixes #17039

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-10 23:55:50 +02:00
William Desportes
05f134c91b
Documentation and typo fixes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-11 22:05:30 +02:00
Josep Sanz
de1c381f23
Add suport to the Mroonga engine: with this patch you can see the size 
of the Mroonga's tables

Apply an optimization suggested

In reality, I have applied 2 optimizations, the first consists in filter by the object type as @williamdes suggested to me and the second is because we don't need to store all data of each mroonga object, we only need the name of the object that is used to compare with the tables names, thanks @williamdes by the optimization idea

Signed-off-by: Josep Sanz <josep.sanz@saltos.org>
 2021-07-11 21:22:06 +02:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
bcdb7e40fb
Replace strncmp === 0 with str_starts_with 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 19:14:30 -03:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
8f992a4fbf
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-15 18:49:37 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
5faf95016f
Use DatabaseName VO for db names in Table\Partition 
- Adds DatabaseName support for DatabaseInterface::selectDb method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-21 21:30:37 -03:00
William Desportes
db01d6a9da
Remove some else conditions by using early exits or moving code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 01:18:39 +02:00
William Desportes
a4bcd1cfc4
Move DBI getForeignKeyConstrains method to controller 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 00:19:02 +02:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 19:01:26 +02:00
William Desportes
e70c7c40ea
Improve debug SQL format 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 16:16:29 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-16 12:11:51 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
1ac9a165e0
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-25 18:44:47 +01:00
William Desportes
3e8b51214f
Fix a non working query that prevented events to show up right after adding them 
Ref: 535c1a4cb5

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-25 18:31:49 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-24 23:56:33 +01:00
William Desportes
8917e77bba
Fix #16595 - escape mysql wildcards on structure edit fields 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:30:56 +01:00
Prashant Tholia
ebff28171c
Fix #16463 - 'REFERENCES' privilege checkbox's title 
Set different title messages depending on database and database version for 'REFERENCES' field in user 'Edit Preferences' form.

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Prashant Tholia <prashant.tholia@gmail.com>
 2021-01-22 00:05:43 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base 
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
e4e274976e Extract cache methods from Util to SessionCache class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-25 22:45:56 -03:00
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
William Desportes
a53189def0
Fixes #16278 - Remove underscore prefix from property names of DBI class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:23:20 +02:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods 
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-29 20:32:04 -03:00
Maurício Meneghini Fauth
4cb24fe46e Fix return types of fetchArray and fetchRow methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-29 13:10:26 -03:00
Maurício Meneghini Fauth
3a6cd6be21 Fix return type declaration of fetchAssoc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-29 12:52:31 -03:00
William Desportes
b0021bf84d
Fixes: #16149 - Remove underscore prefix from all method names 
Ref: #16159

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-03 00:21:24 +02:00
William Desportes
f433d5e7bc
Remove a typehint and document the edge case for _fetchValue 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 22:50:51 +02:00
William Desportes
802797c176
Move getConnectionParams to Config class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 16:01:38 +02:00
William Desportes
36fa925914
Extract SQL query from DatabaseInterface::getColumnsFull 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 15:08:36 +02:00
William Desportes
73fb678d08
Extract SQL query from DatabaseInterface::getDatabasesFull 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 15:01:58 +02:00
William Desportes
ffcabac791
Simplify DatabaseInterface _fetchValue 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 14:54:33 +02:00
William Desportes
8e164bda85
Move _dbgQuery to Query\Utilities as debugLogQueryIntoSession 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 14:47:39 +02:00
William Desportes
eecab19b3e
Move versionToInt to Query\Utilities 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 14:18:03 +02:00
William Desportes
54e27c6a3d
Simplify DatabaseInterface fetchValue logic 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 14:17:01 +02:00
William Desportes
aadb6abfeb
Move usortComparisonCallback to Query\Utilities and remove 2 globals 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 10:34:02 +02:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 02:16:02 +02:00
William Desportes
585304b685
Move formatError into Query\Utilities 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:44:02 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities 
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:42:53 +02:00
William Desportes
312bf572f2
Move some compatibility handling into Query\Compatibility 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:26:07 +02:00
Maurício Meneghini Fauth
e2eac49ad2 Use closures to call private methods as callback 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-30 13:14:06 -03:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 18:30:57 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
11cb629bf0
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-24 01:27:19 +02:00
Petr Duda
ad00dfc24c Fix #16130 - Local documentation links 
Signed-off-by: Petr Duda <petrduda@seznam.cz>
 2020-05-23 17:36:57 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
8dd310fb6a Remove assignments in if conditions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 01:35:19 -03:00
William Desportes
fcd41f6c85
Remove some mysql extension assertions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 22:17:58 +02:00
Maurício Meneghini Fauth
064ba71ed4 Replace or operator in DatabaseInterface::query method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-15 16:42:59 -03:00
Maurício Meneghini Fauth
75fc2ed74f Remove dbi global from DatabaseInterface::load method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-15 16:24:14 -03:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-29 01:08:40 +02:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 17:06:52 +01:00
William Desportes
cc0c975e78
Fix _getSqlForTablesFull and getColumnsFull for Windows CI 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 16:59:26 +01:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 16:59:26 +01:00
William Desportes
0455dab6bb
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-15 11:40:12 +01:00
William Desportes
39284cc877
Use isset for errno 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-15 01:42:40 +01:00
William Desportes
47d00d85ef
Fix Uncaught TypeError for strtoupper caught on Windows unit test suite 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-15 01:32:44 +01:00
William Desportes
8f0d7d3fc1
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 23:10:20 +01:00
William Desportes
150d72bec4
Fix #15958 - Uncaught TypeError when sorting tables by size or by rows 
Fixes: #15958

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 23:08:35 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
e1c69c6a14 Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-22 00:26:45 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3f7204beb7 Add coding standard rule for self reference 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 23:31:20 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-16 18:39:42 +01:00
William Desportes
5b787e7b6d
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-06 20:14:46 +01:00
William Desportes
bd808c8d4f
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-06 15:23:34 +01:00
William Desportes
156231d5bf
Fix not isset $GLOBALS['dblist'] 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-06 15:22:35 +01:00
William Desportes
e3f9efe7e0
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-06 14:26:08 +01:00
William Desportes
d01dab811c
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-06 14:25:25 +01:00
William Desportes
6c35ea3be7
Fix #15724 - Fix 2FA disabled 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-06 14:17:03 +01:00
William Desportes
205790f6bd
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-30 17:55:50 +01:00
William Desportes
f9157f2ac4
Fix #15723 - Can't browse certain tables since 5.0.0 update 
Fixes: #15723
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-30 17:54:00 +01:00
Maurício Meneghini Fauth
a168ec2948 Fix conding standard issue 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-21 19:02:07 -03:00
William Desportes
06701ab562
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 21:48:59 +01:00
William Desportes
9633175165
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 21:38:13 +01:00
William Desportes
f402a8f2cf
Merge #15681 - Fix #15608 DisableIS is broken on pma 4.9.2 with controluser configured 
Fixes: #15608
Pull-request: #15681
Ref: 2bc8afea5f
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 21:34:05 +01:00
William Desportes
28e2814ee9
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 21:04:39 +01:00
William Desportes
aa2f369bf3
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 20:27:25 +01:00
Maurício Meneghini Fauth
542ba3025a Fix control user issue 
Partially reverts commit 2bc8afea5f.

Fixes #15608
Related to #14433

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-21 14:56:59 -03:00
Maurício Meneghini Fauth
9d3f7519c9 Revert "Fix #14433 - "You do not have privileges to manipulate with the users!" on root superadmin" 
This reverts commit b8650115be.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-21 14:54:40 -03:00
William Desportes
6e7e90169a
Fix a possibly undefined index as reported to our server 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-21 16:38:21 +01:00
William Desportes
31ee76f507
Fix a phpstan errpr 
Introduced-by: c01377b161
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-18 23:03:47 +01:00
William Desportes
cc57586f25
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-18 22:42:20 +01:00
William Desportes
02304bcebf
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-18 21:48:27 +01:00
William Desportes
c01377b161
Fix undefined index for proxysql on @@version_comment and @@version 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-18 18:40:21 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
5e203f625a Extract an interface from DatabaseInterface class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-06 14:24:01 -03:00
Maurício Meneghini Fauth
cd5306bab1 Rename PhpMyAdmin\Dbi to PhpMyAdmin\Dbal 
Rename Dbi (Database Interface) to Dbal (Database Abstraction Layer).

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-06 13:12:01 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
bcfeba36d8 Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-04 16:10:37 -03:00
Maurício Meneghini Fauth
e0ee0f8165 Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-04 16:09:23 -03:00
Hugues Peccatte
a52593e6ac Fix operators precedence possible issue 
As "==" has priority over "&", it was firstly checking the equality… which were always true…

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-02 00:45:59 +01:00
Maurício Meneghini Fauth
6dd961c8f3 Refactor server engines entry point 
Moves server engines entry point logic to the routes files and moves the
request parameters to the route parameter.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-26 12:55:54 -03:00
William Desportes
66bd7fb596
Merge branch 'QA_5_0' 
Sign-off: fc393eac39

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-21 13:36:44 +02:00
William Desportes
fc393eac39
Fix phpcs and ignore PSR2.Methods.FunctionCallSignature.Indent 2019-10-21 13:30:38 +02:00
William Desportes
14d73c1da0
Merge branch 'QA_5_0' into master 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-21 13:03:33 +02:00
Isaac Bennetch
f4978c8a8e Merge commit 'd15211db5c' into QA_5_0 2019-10-20 23:12:17 -04:00
Isaac Bennetch
dd28239a37 Merge commit '4e7fac843d' into QA_5_0 2019-10-20 23:11:42 -04:00
William Desportes
af344bb4c1
Fix #14433 - return an array with an empty user and empty host 
Fixes: 83602a6b72
This is an unexpected change, detected by unit tests

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-20 15:09:19 +02:00
William Desportes
83602a6b72
Fix #14433 - return an empty array 
Fixes: b8650115be

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-20 15:01:02 +02:00
William Desportes
b8650115be
Fix #14433 - "You do not have privileges to manipulate with the users!" on root superadmin 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-10-20 14:43:47 +02:00
Maurício Meneghini Fauth
13e1362f26 Add initial suport for prepared statements 
Creates the DbiExtension::prepare method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-06 11:46:40 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
84cb56ab4d Use the router for the logout page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-19 22:47:53 -03:00
Maurício Meneghini Fauth
88c28f095a Fix some errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-01 19:04:27 -03:00
Hugues Peccatte
1b744d0cc8 Simplify code regarding type hinting 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-07-16 23:21:25 -03:00
Hugues Peccatte
9c0806cfcf Fix static / non-static calls 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-07-16 23:21:25 -03:00
Hugues Peccatte
0d8f6a3a93 Merge isset and unset calls 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
cda99ea57f Use the router for the server_engines.php page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-09 21:51:49 -03:00
Maurício Meneghini Fauth
e99f3ace5c Move DbiDummy extension to the test directory 
DbiDummy extension is only used for testing purposes

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-28 18:00:36 -03:00
William Desportes
a2268169ae
Use strict compare for count function 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:44:49 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes 
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
6316967e01 Merge branch 'QA_4_9' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-19 13:11:41 -03:00
Maurício Meneghini Fauth
7ef47312db Remove remaining calls to old DI container 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 15:02:08 -03:00
Hugues Peccatte
1b5131863f Get rid of old container in DatabaseInterface 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-06-15 21:40:21 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
William Desportes
ec74b34010
Fix "logout and try as another user link" 
- I changed the link to not use ajax mode

Try the query 'GRANT PROXY ON 'root'@'localhost' TO 'root'@'localhost' WITH GRANT OPTION' to reproduce

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-09 17:15:16 +02:00
Maurício Meneghini Fauth
1f62d01470 Use spaceship operator instead of nested ternary operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-22 18:43:54 -03:00
Maurício Meneghini Fauth
83f56cdedf Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-22 18:35:35 -03:00