gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

84 Commits

Author SHA1 Message Date
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
d58057daec
Extract Database\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 17:13:23 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 16:25:39 -03:00
Rodrigo Pokemaobr
65ca2ee340 Changing value of to avoid js error on debugJson 
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
 2022-03-31 15:20:20 -03:00
Maurício Meneghini Fauth
642762c9b8
Extract console.js objects into console module 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-23 20:20:44 -03:00
Maurício Meneghini Fauth
3befb5f8d0
Remove debugSQLInfo JS global variable 
Replaces it with a ConsoleDebug property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-22 15:24:13 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Kamil Tekiela
47e81a5161 Remove $route global 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-27 11:47:40 +00:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method 
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
1061a85b5e
Extract the HTML from the Footer::getSelfLink method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-03 18:36:45 -03:00
William Desportes
75c148b885
Update psalm baseline and include ignores 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 00:43:20 +02:00
William Desportes
dcc52b063a
Fix doc blocks 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-29 00:36:13 +02:00
Maurício Meneghini Fauth
90778eecf7
Upgrade phpmyadmin/coding-standard to 3.0.0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-19 02:20:46 -03:00
Maurício Meneghini Fauth
045206429b
Extract the HTML from the Footer::getDemoMessage 
Renames getDemoMessage to getGitRevisionInfo.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-26 21:32:40 -03:00
Maurício Meneghini Fauth
d900172b87
Suppress Psalm MissingFile error for revision-info file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-26 20:33:00 -03:00
William Desportes
7c2ebb163c
Write revision info from a CLI 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-25 21:42:23 +01:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-16 12:11:51 -03:00
William Desportes
0c5aa81c78
Inject the error report modal and avoid sending depending on SendErrorReports 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-15 18:22:30 +01:00
Maurício Meneghini Fauth
207901e992
Remove the js/src/microhistory.js file 
There is no need for the MicroHistory anymore now that the History
API is available in all supported browsers.

Also removes the jQuery hashchange plugin.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-10 17:06:21 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:46:39 +02:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names 
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
 2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
William Desportes
718ceadeb6
Merge branch 'QA_5_0-security' into master-security 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-22 01:23:51 +01:00
William Desportes
28bdc02c3c
Merge branch 'QA_4_9-security' into QA_5_0-security 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-22 01:19:16 +01:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00