gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

88 Commits

Author SHA1 Message Date
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maximilian Krög
366daacc76
Trim label before passing it on 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-21 21:32:19 +01:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
7f898f9fc3
Refactor gis scale data set calculation (#18100) 
* Add better array types through automatic inference

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Create VO for ScaleData

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix bug with calculation of minimum X/Y

0.0 cannot be used as a sentinel value because it's one of the possible values.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-17 08:24:37 -03:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Maurício Meneghini Fauth
07594eda44
Remove Image\ImageWrapper::destroy method 
This method has no operation in PHP 8.0.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-13 10:34:12 -03:00
Maurício Meneghini Fauth
13890a947a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-16 11:53:18 -03:00
Maximilian Krög
a90cff2f7f
Fix centering of gis plot 
When the ratio in one or both dimensions is zero (all points at the same
width or height) place it in the center.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2022-12-10 22:26:42 +01:00
Maximilian Krög
ed9c607f01
Fix centering of gis data in plot 
The image was not centered because the border (either x or y) was
not included in the calculation

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2022-12-10 21:18:40 +01:00
MoonE
4e529ae399
Refactor gis color (#17895) 
* Use int srid in gis tests

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Typecheck gis color

Only use array<int> as color

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2022-11-30 14:49:06 -03:00
Maurício Meneghini Fauth
c0941401c1
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 14:26:19 -03:00
Maurício Meneghini Fauth
2653b2942b
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 13:02:15 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
William Desportes
1cad1f5808
Merge #17191 - Fix #17188 - GIS visualization with edited query 
Pull-request: #17191
Fixes: #17188

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-03-05 19:33:36 +01:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Maurício Meneghini Fauth
b1dc03365a
Bump TCPDF version to 6.4.4 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-31 16:58:34 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maximilian Krög
c0106e68c8
Fix visualization with edited query 
Strip semicolon at end of original query when it is used as a subquery

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-11-18 00:11:17 +01:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-13 15:29:11 -03:00
William Desportes
4c6061a04e
Merge #17075 - Use int as srid type 
Pull-request: #17075

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-31 01:36:18 +02:00
William Desportes
72800e2524
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-15 00:52:33 +02:00
Maximilian Krög
c8ddcf4adc
Use int as srid type 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-08-13 00:12:16 +02:00
Maximilian Krög
5dad1d0bb7
Fix: Don't add multiple OpenLayers maps, remove listeners on dispose 
With 5.1 the map is only created when it is first shown, but every second time
switching to the map a new instance is created because zero is returned when no new
map was created.

OpenLayers adds a resize listener to the window when a target is defined to
handle size adjustments, but this means setTarget(null) has to be called to
fully dispose of the added listener when the map is no longer needed.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-08-10 18:59:49 +02:00
Maurício Meneghini Fauth
c499dd18e5
Wrap GD functions with the ImageWrapper class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-06 19:27:59 -03:00
Maurício Meneghini Fauth
6b57a17ac3
Merge pull request #17021 from MoonE/mb_substr 
Use negative length with mb_substr where possible
 2021-07-20 16:00:53 -03:00
William Desportes
3a87667cab
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-20 17:52:16 +02:00
Maximilian Krög
c1c6b01195
Use correct min MySQL version for axis-order (8.0.1) 
There was no version 8.0.10
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-07-20 01:28:29 +02:00
Maximilian Krög
808cd82780
Use negative length with mb_substr where possible 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-07-18 23:59:46 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
90778eecf7
Upgrade phpmyadmin/coding-standard to 3.0.0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-19 02:20:46 -03:00
William Desportes
ba35901594
Merge branch 'origin/QA_5_1' into master 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-17 00:53:14 +02:00
William Desportes
df96ee24b3
Fix PHP type error on GIS nullable data 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-17 00:27:24 +02:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
97f0b16938
Fix #16706 - Error when visualizing nullable geometry column 
Fixes: #16706

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-04 17:52:39 +01:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Saksham Gupta
e1461d847c
Upgrade OpenLayers (#16303) 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2020-09-04 13:19:00 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
William Desportes
e89b02c08d
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-24 09:07:17 +02:00
William Desportes
40d01944a3
Fix #16088 - Do not add axis switch on MariaDB 
Ref: 969f43c82b

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-22 21:56:56 +02:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names 
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
 2020-06-02 16:44:16 +01:00