Maurício Meneghini Fauth
|
77957a69a5
|
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2023-02-24 20:48:46 -03:00 |
|
Kamil Tekiela
|
902d1a1e77
|
Add native return type hints (#18126)
* Add remaining native return type hints to flush out bugs
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Cast the mixed value to int
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* getAutoIncrement() is supposed to return string
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Cast values to string in DummyResult
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Make getCollation() return non-nullable string
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Cast seqInIndex to int
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Cast $cardinality to int
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* createFile may return false
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove redundant cast
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update baselines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2023-02-23 15:43:36 -03:00 |
|
Kamil Tekiela
|
87e42d591c
|
Use short closures where possible
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2023-02-14 13:44:42 +00:00 |
|
Kamil Tekiela
|
d76b240176
|
Remove redundant pass-by-ref
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2023-02-10 16:30:12 -03:00 |
|
Kamil Tekiela
|
6264f6f1ea
|
Various refactorings 2 (#17965)
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2022-12-24 12:54:23 -03:00 |
|
Kamil Tekiela
|
f835485588
|
Remove remaining bits of Sanitize::jsFormat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2022-10-17 21:31:07 +01:00 |
|
Kamil Tekiela
|
4035ec7e35
|
Make getJsValue use json_encode
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2022-10-17 21:28:56 +01:00 |
|
Maurício Meneghini Fauth
|
75cf045fa3
|
Extract url.php entry point into a route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2022-08-06 15:02:49 -03:00 |
|
Maurício Meneghini Fauth
|
44fe103b9c
|
Remove @access annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-12-22 11:43:45 -03:00 |
|
Maurício Meneghini Fauth
|
f00d70cccb
|
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-15 17:05:40 -03:00 |
|
Maurício Meneghini Fauth
|
9f3510d11a
|
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-09-14 20:11:51 -03:00 |
|
Maurício Meneghini Fauth
|
04d3c83559
|
Fix some errors found by PHPStan/Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-08-05 16:09:08 -03:00 |
|
Maurício Meneghini Fauth
|
bcdb7e40fb
|
Replace strncmp === 0 with str_starts_with
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-09 19:14:30 -03:00 |
|
Maurício Meneghini Fauth
|
a0d91ec153
|
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-07-06 14:00:44 -03:00 |
|
Maurício Meneghini Fauth
|
1c084de30b
|
Fix coding standard errors
Related to 62f142c9fa.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-06-03 16:50:33 -03:00 |
|
Maurício Meneghini Fauth
|
cd1b8a9b77
|
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-05-22 15:14:24 -03:00 |
|
Maurício Meneghini Fauth
|
7e33d227f5
|
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-08 15:03:12 -03:00 |
|
Maurício Meneghini Fauth
|
d83abf63e7
|
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-05 15:27:03 -03:00 |
|
Maurício Meneghini Fauth
|
0b8edc5bde
|
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2021-03-05 14:18:35 -03:00 |
|
Maurício Meneghini Fauth
|
bb32ba6d9c
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-04 12:31:43 -03:00 |
|
Maurício Meneghini Fauth
|
e7c8e20edb
|
Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-10-02 00:37:23 -03:00 |
|
Maurício Meneghini Fauth
|
f2e49a92c6
|
Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-09-30 19:23:01 -03:00 |
|
Maurício Meneghini Fauth
|
3b285ff17e
|
Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-07-10 18:06:29 -03:00 |
|
Maurício Meneghini Fauth
|
e81146e4b3
|
Remove useless return annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-07-07 10:30:27 -03:00 |
|
Maurício Meneghini Fauth
|
b30f06455c
|
Remove the blacklist/whitelist terminology
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-06-15 17:51:24 -03:00 |
|
Petr Duda
|
37b22a5c71
|
Fix #16102 - Broken error message
Signed-off-by: Petr Duda <petrduda@seznam.cz>
|
2020-05-31 17:41:49 +02:00 |
|
Maurício Meneghini Fauth
|
f4582e083e
|
Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-27 00:35:24 -03:00 |
|
Maurício Meneghini Fauth
|
2d02a15de3
|
Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-26 18:30:57 -03:00 |
|
Maurício Meneghini Fauth
|
3baad2eb1c
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-25 22:42:37 -03:00 |
|
William Desportes
|
11cb629bf0
|
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-05-24 01:27:19 +02:00 |
|
Petr Duda
|
ad00dfc24c
|
Fix #16130 - Local documentation links
Signed-off-by: Petr Duda <petrduda@seznam.cz>
|
2020-05-23 17:36:57 +02:00 |
|
William Desportes
|
73290bcdcf
|
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-05-19 00:10:11 +02:00 |
|
William Desportes
|
70329729e4
|
Fix #15996 - local setup doc links are broken, us the right links in FormDisplay
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-05-18 23:51:19 +02:00 |
|
William Desportes
|
dfa718c1c6
|
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-05-17 16:48:09 +02:00 |
|
William Desportes
|
db02eea620
|
Fix #15996 - local setup doc links are broken
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-05-17 16:03:13 +02:00 |
|
Maurício Meneghini Fauth
|
80a45fa0ae
|
Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-16 18:08:20 -03:00 |
|
Maurício Meneghini Fauth
|
a64393e7f5
|
Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-05-13 00:23:28 -03:00 |
|
William Desportes
|
cc82f092ce
|
Fix MissingClosureParamType errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-04-29 01:08:40 +02:00 |
|
William Desportes
|
b7af1364c6
|
Psalm auto fixes manualy reviewed and edited
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-04-28 23:18:59 +02:00 |
|
Maurício Meneghini Fauth
|
206199105e
|
Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-23 13:03:29 -03:00 |
|
Maurício Meneghini Fauth
|
6584b01824
|
Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-23 12:20:04 -03:00 |
|
Maurício Meneghini Fauth
|
6b7af13f8f
|
Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-23 00:33:24 -03:00 |
|
Maurício Meneghini Fauth
|
676f48349a
|
Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-21 22:13:36 -03:00 |
|
Maurício Meneghini Fauth
|
42166cac37
|
Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-21 19:47:56 -03:00 |
|
Maurício Meneghini Fauth
|
f80d3e3bd4
|
Remove unnecessary annotations
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-20 17:35:56 -03:00 |
|
Maurício Meneghini Fauth
|
285907991e
|
Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2020-01-19 22:29:54 -03:00 |
|
William Desportes
|
249ee4dbd2
|
Improve JS and phpdoc by removing useless spaces
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
2020-01-16 18:39:42 +01:00 |
|
Maurício Meneghini Fauth
|
f126e14599
|
Extract js variables from js/messages.php
Moves JavaScript variables to templates/javascript/variables.twig.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2019-12-18 16:48:41 -03:00 |
|
Maurício Meneghini Fauth
|
39f42f848b
|
Remove some useless docblock comments
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2019-12-13 21:15:00 -03:00 |
|
Maurício Meneghini Fauth
|
dd06cd38f8
|
Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
2019-12-01 14:10:07 -03:00 |
|