gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

251 Commits

Author SHA1 Message Date
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
0819043d0e
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-08 14:09:59 -03:00
William Desportes
2443570ce6
Merge #17851 - Fix #17028, #17683 - Re build query count management 
Pull-request: #17851
Fixes: #17028
Fixes: #17683

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:12:00 +01:00
Maurício Meneghini Fauth
ef385e2259
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-01 22:04:27 -03:00
Liviu-Mihail Concioiu
f45cd23222 Remove double quotes 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-01-31 22:57:56 +01:00
Maurício Meneghini Fauth
551c317aee
Merge pull request #17982 from kamil-tekiela/Elvis 
Remove usage of elvis operator

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-24 13:46:33 -03:00
Kamil Tekiela
6264f6f1ea
Various refactorings 2 (#17965) 
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-24 12:54:23 -03:00
Kamil Tekiela
9a8dc40ae9 Remove usage of elvis operator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 19:50:58 +00:00
William Desportes
b820730f84
Fix PR #17906 on master branch 
Pull-request: #17906

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:31:41 +01:00
William Desportes
a60437f04a
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:09:44 +01:00
iifawzi
b7bf83c24c Default to "Full texts" when running ANALYZE 
Signed-off-by: iifawzi <iifawzie@gmail.com>
 2022-11-18 17:00:10 +02:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00
William Desportes
86b93afdfd
Replace '*' in query to count results 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 14:44:40 +01:00
William Desportes
8a2fbda34a
Ref #17028 - Use statement build instead of replacing tokens 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 14:37:54 +01:00
Maurício Meneghini Fauth
9fa9a8d753
Fix a coding standard error 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-20 23:50:58 -03:00
Maurício Meneghini Fauth
b25dc2426e
Merge pull request #17806 from sivadasrajan/refactoring-db-table 
Refactored Bookmark::get() for DatabaseName
 2022-10-20 21:57:43 -03:00
SIVADAS P R
12656141f6 Refactored Bookmark::get() for DatabaseName 
Signed-off-by: SIVADAS P R <sivadasrajan@gmail.com>
 2022-10-21 01:52:09 +05:30
Kamil Tekiela
2c416128e5 Pass as argument to Table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 22:30:33 +01:00
Maurício Meneghini Fauth
d6b72de8aa
Improve return type of Index::getPrimary method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 23:25:20 -03:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
f57ea10921
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-12 21:13:24 -03:00
Kamil Tekiela
d075fa56a2 A table may be named "0" 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-08-04 21:40:18 +01:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-24 21:35:30 -03:00
Maurício Meneghini Fauth
6dc859cbc2
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-28 15:56:18 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency 
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-27 19:47:31 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
a70b08d62f
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:48:23 -03:00
Maurício Meneghini Fauth
f7f85bb450
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-21 12:37:29 -03:00
Maurício Meneghini Fauth
4848ccb481
Disable editing to system schemas 
- Fixes #16816

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-19 17:52:05 -03:00
Maurício Meneghini Fauth
dca5b1b893
Create the DisplayParts class 
Replaces the displayParts array with the DisplayParts object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-03 14:42:09 -03:00
Maurício Meneghini Fauth
c03cbdea88
Merge pull request #17276 from kamil-tekiela/microtime-sql 
Expose execution time as public property
 2022-01-19 12:13:12 -03:00
Kamil Tekiela
3e6e4fffbc Expose execution time as public property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 21:21:55 +00:00
Kamil Tekiela
84e899bb86 Fix parameter types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 18:21:21 +00:00
Kamil Tekiela
643c642c9d Remove redundant null coalesce 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 18:21:21 +00:00
Kamil Tekiela
8e035557a7 Refactor getMessageIfMissingColumnIndex 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 18:21:20 +00:00
Kamil Tekiela
caeb5fef29 Cleanup getHtmlForPreviousUpdateQuery 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
d280d724ed Add return type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
7f8c1355fa Add check for false value 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
b20922b773 Simplify getDefaultSqlQueryForBrowse 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
e8bfa5e4e6 Remove redundant condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
51207fff0b Set parameter type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00